Remove ignore tag for tests that don't fail any more

Check for execution correctness inside the test
Fix run_external to include compileKotlinAgainstKotlin

backend.native/tests/build.gradle

@@ -195,11 +195,7 @@ def createTestTasks(File testRoot, Class<Task> taskType, Closure taskConfigurati
 
 task run_external () {
     // Create tasks for external tests.
-    for (testDir in ["codegen", "compileKotlinAgainstKotlin"]) {
+    createTestTasks(externalTestsDir, RunExternalTestGroup) { }
-        createTestTasks(new File(externalTestsDir, testDir), RunExternalTestGroup) {
-            it.goldValue = "OK"
-        }
-    }
 
     // Set up dependencies.
     dependsOn(clean)

backend.native/tests/external/codegen/box/boxingOptimization/boxedRealsCmp.kt

@@ -1,4 +1,5 @@
-// IGNORE_BACKEND: JS, NATIVE
+//
+// IGNORE_BACKEND: JS
 
 inline fun ltx(a: Comparable<Any>, b: Any) = a < b
 inline fun lex(a: Comparable<Any>, b: Any) = a <= b

backend.native/tests/external/codegen/box/boxingOptimization/explicitEqualsOnDouble.kt

@@ -1,5 +1,4 @@
 // IGNORE_BACKEND: JS
-// IGNORE_BACKEND: NATIVE
 
 fun equals1(a: Double, b: Double) = a.equals(b)
 

backend.native/tests/external/codegen/box/bridges/strListContains.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 
 class StrList : List<String?> {
     override val size: Int

backend.native/tests/external/codegen/box/callableReference/bound/genericValOnLHS.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 
 class Generic<P : Any>(val p: P)
 

backend.native/tests/external/codegen/box/callableReference/function/genericCallableReferenceArguments.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 // WITH_REFLECT

backend.native/tests/external/codegen/box/callableReference/function/genericCallableReferencesWithNullableTypes.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 // WITH_REFLECT

backend.native/tests/external/codegen/box/callableReference/function/genericCallableReferencesWithOverload.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 // WITH_REFLECT

backend.native/tests/external/codegen/box/callableReference/function/local/equalsHashCode.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 fun box(): String {
     fun bar() {}

backend.native/tests/external/codegen/box/casts/functions/asFunKBig.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 // This is a big, ugly, semi-auto generated test.

backend.native/tests/external/codegen/box/casts/functions/reifiedAsFunKBig.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 // This is a big, ugly, semi-auto generated test.

backend.native/tests/external/codegen/box/casts/mutableCollections/asWithMutable.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: NATIVE
+
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/casts/mutableCollections/isWithMutable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/casts/mutableCollections/reifiedAsWithMutable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/casts/mutableCollections/reifiedIsWithMutable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/casts/mutableCollections/reifiedSafeAsWithMutable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/casts/mutableCollections/safeAsWithMutable.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 class Itr : Iterator<String> by ArrayList<String>().iterator()

backend.native/tests/external/codegen/box/classLiteral/bound/primitives.kt

@@ -1,5 +1,3 @@
-// IGNORE_BACKEND: NATIVE
-
 // WITH_RUNTIME
 
 import kotlin.test.assertEquals

backend.native/tests/external/codegen/box/classLiteral/bound/simple.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 
 fun box(): String {
     val x: CharSequence = ""

backend.native/tests/external/codegen/box/classLiteral/bound/smartCast.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // KT-16291 Smart cast doesn't work when getting class of instance
 
 class Foo(val s: String) {

backend.native/tests/external/codegen/box/classes/kt1157.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 public object SomeClass {
     private val work = object : Runnable {
         override fun run() {

backend.native/tests/external/codegen/box/classes/privateOuterFunctions.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 class C {
     private fun String.ext() : String = ""
     private fun f() {}

backend.native/tests/external/codegen/box/classes/privateOuterProperty.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 class C{
     private var v : Int = 0
 

backend.native/tests/external/codegen/box/controlStructures/kt513.kt

@@ -1,5 +1,3 @@
-// IGNORE_BACKEND: NATIVE
-
 // WITH_RUNTIME
 
 class A() {

backend.native/tests/external/codegen/box/controlStructures/kt772.kt

@@ -1,5 +1,3 @@
-// IGNORE_BACKEND: NATIVE
-
 package demo2
 
 fun print(o : Any?) {}

backend.native/tests/external/codegen/box/controlStructures/kt773.kt

@@ -1,5 +1,3 @@
-// IGNORE_BACKEND: NATIVE
-
 package demo2
 
 fun print(o : Any?) {}

backend.native/tests/external/codegen/box/coroutines/featureIntersection/breakWithNonEmptyStack.kt

@@ -1,6 +1,5 @@
 // WITH_RUNTIME
 // WITH_COROUTINES
-// IGNORE_BACKEND: NATIVE
 import helpers.*
 import kotlin.coroutines.experimental.*
 import kotlin.coroutines.experimental.intrinsics.*

backend.native/tests/external/codegen/box/coroutines/inlineSuspendFunction.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 // WITH_COROUTINES
 import helpers.*

backend.native/tests/external/codegen/box/coroutines/instanceOfContinuation.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 // WITH_COROUTINES
 import helpers.*

backend.native/tests/external/codegen/box/coroutines/multiModule/inlineMultiModule.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_COROUTINES
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/coroutines/multiModule/inlineMultiModuleOverride.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // IGNORE_BACKEND: JVM
 // WITH_COROUTINES
 // WITH_RUNTIME

backend.native/tests/external/codegen/box/coroutines/multiModule/inlineMultiModuleWithController.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_COROUTINES
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/coroutines/stackUnwinding/inlineSuspendFunction.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 // WITH_COROUTINES
 import helpers.*

backend.native/tests/external/codegen/box/coroutines/suspendInTheMiddleOfObjectConstructionEvaluationOrder.kt

@@ -1,6 +1,5 @@
 // WITH_RUNTIME
 // WITH_COROUTINES
-// IGNORE_BACKEND: NATIVE
 
 import helpers.*
 import kotlin.coroutines.experimental.*

backend.native/tests/external/codegen/box/dataClasses/doubleParam.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 val NAN = Double.NaN
 

backend.native/tests/external/codegen/box/dataClasses/floatParam.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 val NAN = Float.NaN
 

backend.native/tests/external/codegen/box/ieee754/comparableTypeCast.kt

@@ -1,4 +1,4 @@
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 fun box(): String {
     if ((-0.0 as Comparable<Double>) >= 0.0) return "fail 0"
     if ((-0.0F as Comparable<Float>) >= 0.0F) return "fail 1"

backend.native/tests/external/codegen/box/javaInterop/notNullAssertions/mapPut.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 
 fun <K: Any, V: Any> foo(k: K, v: V) {
     val map = HashMap<K, V>()

backend.native/tests/external/codegen/box/properties/lateinit/isInitializedAndDeinitialize/emptyLhs.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 
 package test

backend.native/tests/external/codegen/box/properties/lateinit/isInitializedAndDeinitialize/innerSubclass.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/properties/lateinit/isInitializedAndDeinitialize/propertyImportedFromObject.kt

@@ -1,5 +1,5 @@
 // WITH_RUNTIME
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 package test
 

backend.native/tests/external/codegen/box/properties/lateinit/isInitializedAndDeinitialize/sideEffects.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/properties/lateinit/isInitializedAndDeinitialize/topLevelProperty.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/properties/lateinit/local/uninitializedCapturedMemberAccess.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/properties/lateinit/local/uninitializedCapturedRead.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/properties/lateinit/local/uninitializedMemberAccess.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/properties/lateinit/local/uninitializedRead.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/properties/lateinit/topLevel/accessorException.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 // FILE: lateinit.kt
 private lateinit var s: String
 

backend.native/tests/external/codegen/box/properties/lateinit/topLevel/uninitializedMemberAccess.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/properties/lateinit/topLevel/uninitializedRead.kt

@@ -1,6 +1,5 @@
 // LANGUAGE_VERSION: 1.2
 // WITH_RUNTIME
-// IGNORE_BACKEND: NATIVE
 
 import kotlin.UninitializedPropertyAccessException
 

backend.native/tests/external/codegen/box/ranges/contains/inComparableRange.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/ranges/safeCallRangeTo.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/traits/kt2399.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 // on JS Parser.parse and MultiParser.parse clash in ProjectInfoJsonParser
 
 class JsonObject {

backend.native/tests/external/codegen/box/traits/traitImplGenericDelegation.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 interface A<T, U : Number, V : Any> {
     fun foo(t: T, u: U): V? {
         return null

backend.native/tests/external/codegen/box/when/integralWhenWithNoInlinedConstants.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/when/stringOptimization/duplicatingItemsSameHashCode.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/box/when/stringOptimization/sameHashCode.kt

@@ -1,5 +1,5 @@
 // TODO: muted automatically, investigate should it be ran for JS or not
-// IGNORE_BACKEND: JS, NATIVE
+// IGNORE_BACKEND: JS
 
 // WITH_RUNTIME
 

backend.native/tests/external/codegen/boxInline/property/reifiedVal.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 // WITH_REFLECT
 // FILE: 1.kt

backend.native/tests/external/codegen/boxInline/property/reifiedVar.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // WITH_RUNTIME
 // WITH_REFLECT
 // FILE: 1.kt

backend.native/tests/external/codegen/boxInline/reified/kt9637_2.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // FILE: 1.kt
 
 package test

backend.native/tests/external/compileKotlinAgainstKotlin/coroutinesBinary.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: NATIVE
 // FILE: A.kt
 // WITH_RUNTIME
 package a

buildSrc/plugins/src/main/groovy/org/jetbrains/kotlin/KonanTest.groovy

@@ -752,7 +752,8 @@ import kotlin.test.Test
 fun runTest() {
     @Suppress("UNUSED_VARIABLE")
     val result = box()
-    ${ (goldValue != null) ? "print(result)" : "" }
+    if (result != "OK") throw AssertionError("Test failed with: " + result)
+    print(result)
 }
 """     )
         createFile(file, text.toString())