azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Fix K2 behavior according to RULES1

Browse Source 
The compiler should only report diagnostics for
comparisons over builtins and identity-less types,
other incompatibilities should be reported
via inspections.

It's ok that in `equalityChecksOnIntegerTypes`
instead of `EQUALITY_NOT_APPLICABLE_WARNING` we get
`EQUALITY_NOT_APPLICABLE`, because
`ProperEqualityChecksInBuilderInferenceCalls`
is already active by default.

This change also replaces the notion of a representative superclass
with the least upper bound.
This makes complex types like
intersection/flexible transparent to
RULES1-based compatibility checks.
One way to look at it is to think
that this is an automatic way of handling
type parameters: automatic picking of
"interesting" bounds, and checking them against one another.

Note that `TypeIntersector.intersectTypes`
for `Int` and `T` where `T` is a type parameter
may return both `{Int & T}` or `null`
depending on `T`-s bounds. At the same time,
for type parameters `T` and `K` it will
always return `{T & K}`.

`ConeTypeIntersector.intersectTypes`, on the
other hand, will always return `{Int & T}`
irrespectively of the bounds. Meaning, the two
intersectors differ in corner cases.

`lowerBoundIfFlexible` call in `isLiterallyTypeParameter` is backed by
the `equalityOfFlexibleTypeParameters` test.

^KT-35134 #fixed-in-k2
^KT-22499 #fixed-in-k2
^KT-46383 #fixed-in-k2
This commit is contained in:
Nikolay Lunyak
2023-02-01 18:21:53 +02:00
committed by Space Team
parent 06e687addd
commit f0720c1d12
86 changed files with 1982 additions and 594 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/codegen/box/involvesIrInterpreter/dumpIrAndCheck/floatOperations.kt
Vendored
+33 -33
View File
@@ -1,7 +1,7 @@
// TARGET_BACKEND: JVM_IR
// TARGET_BACKEND: NATIVE
// TARGET_BACKEND: JS_IR
// IGNORE_BACKEND_K1: JVM_IR, NATIVE, JS_IR, JS_IR_ES6
// IGNORE_BACKEND_K1: NATIVE
const val minusOneVal = -1.0f
const val oneVal = 1.0f
@@ -101,59 +101,59 @@ fun box(): String {
if (compareTo7 != 0) return "Fail 1.7"
if (compareTo8 != 0) return "Fail 1.8"
if (plus1 != 3) return "Fail 2.1"
if (plus2 != 4) return "Fail 2.2"
if (plus3 != 5) return "Fail 2.3"
if (plus4 != 4) return "Fail 2.4"
if (plus5 != 4) return "Fail 2.5"
if (plus6 != 4) return "Fail 2.6"
if (plus1 != 3f) return "Fail 2.1"
if (plus2 != 4f) return "Fail 2.2"
if (plus3 != 5f) return "Fail 2.3"
if (plus4 != 4f) return "Fail 2.4"
if (plus5 != 4f) return "Fail 2.5"
if (plus6 != 4f) return "Fail 2.6"
if (plus7 != 4.0f) return "Fail 2.7"
if (plus8 != 4.0) return "Fail 2.8"
if (minus1 != -1) return "Fail 3.1"
if (minus2 != 0) return "Fail 3.2"
if (minus3 != 1) return "Fail 3.3"
if (minus4 != 0) return "Fail 3.4"
if (minus5 != 0) return "Fail 3.5"
if (minus6 != 0) return "Fail 3.6"
if (minus1 != -1f) return "Fail 3.1"
if (minus2 != 0f) return "Fail 3.2"
if (minus3 != 1f) return "Fail 3.3"
if (minus4 != 0f) return "Fail 3.4"
if (minus5 != 0f) return "Fail 3.5"
if (minus6 != 0f) return "Fail 3.6"
if (minus7 != 0.0f) return "Fail 3.7"
if (minus8 != 0.0) return "Fail 3.8"
if (times1 != 2) return "Fail 4.1"
if (times2 != 4) return "Fail 4.2"
if (times3 != 6) return "Fail 4.3"
if (times4 != 4) return "Fail 4.4"
if (times5 != 4) return "Fail 4.5"
if (times6 != 4) return "Fail 4.6"
if (times1 != 2f) return "Fail 4.1"
if (times2 != 4f) return "Fail 4.2"
if (times3 != 6f) return "Fail 4.3"
if (times4 != 4f) return "Fail 4.4"
if (times5 != 4f) return "Fail 4.5"
if (times6 != 4f) return "Fail 4.6"
if (times7 != 4.0f) return "Fail 4.7"
if (times8 != 4.0) return "Fail 4.8"
if (div1 != 0.5f) return "Fail 5.1"
if (div2 != 1.0f) return "Fail 5.2"
if (div3 != 1.5f) return "Fail 5.3"
if (div4 != 1) return "Fail 5.4"
if (div5 != 1) return "Fail 5.5"
if (div6 != 1) return "Fail 5.6"
if (div4 != 1f) return "Fail 5.4"
if (div5 != 1f) return "Fail 5.5"
if (div6 != 1f) return "Fail 5.6"
if (div7 != 1.0f) return "Fail 5.7"
if (div8 != 1.0) return "Fail 5.8"
if (rem1 != 1) return "Fail 6.1"
if (rem2 != 0) return "Fail 6.2"
if (rem3 != 1) return "Fail 6.3"
if (rem4 != 0) return "Fail 6.4"
if (rem5 != 0) return "Fail 6.5"
if (rem6 != 0) return "Fail 6.6"
if (rem1 != 1f) return "Fail 6.1"
if (rem2 != 0f) return "Fail 6.2"
if (rem3 != 1f) return "Fail 6.3"
if (rem4 != 0f) return "Fail 6.4"
if (rem5 != 0f) return "Fail 6.5"
if (rem6 != 0f) return "Fail 6.6"
if (rem7 != 0.0f) return "Fail 6.7"
if (rem8 != 0.0) return "Fail 6.8"
if (unaryPlus1 != 1) return "Fail 7.1"
if (unaryPlus2 != -1) return "Fail 7.2"
if (unaryMinus1 != -1) return "Fail 7.3"
if (unaryMinus2 != 1) return "Fail 7.4"
if (unaryPlus1 != 1f) return "Fail 7.1"
if (unaryPlus2 != -1f) return "Fail 7.2"
if (unaryMinus1 != -1f) return "Fail 7.3"
if (unaryMinus2 != 1f) return "Fail 7.4"
if (convert1 != '') return "Fail 8.1"
if (convert2 != 1) return "Fail 8.2"
if (convert3 != 1) return "Fail 8.3"
if (convert3 != 1L) return "Fail 8.3"
if (convert4 != 1.0f) return "Fail 8.4"
if (convert5 != 1.0) return "Fail 8.5"