Switch to 193 platform

idea/idea-completion/testData/injava/InterfaceDefaultImplsNonImported.java

@@ -4,8 +4,8 @@ public class Testing {
     }
 }
 
-// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractFun)" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractFunWithExpressionBody)" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractProperty)" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractPropertyWithBody)" }
-// ABSENT:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.AllAbstract)" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractFun" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractFunWithExpressionBody" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractProperty" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractPropertyWithBody" }
+// ABSENT:  { lookupString: "DefaultImpls", tailText: " defaultImpls.AllAbstract" }

idea/idea-completion/testData/injava/InterfaceDefaultImplsNonImported.java.192

@@ -0,0 +1,11 @@
+public class Testing {
+    public static void test() {
+        DefaultImpl<caret>
+    }
+}
+
+// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractFun)" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractFunWithExpressionBody)" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractProperty)" }
+// EXIST:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.NonAbstractPropertyWithBody)" }
+// ABSENT:  { lookupString: "DefaultImpls", tailText: " (defaultImpls.AllAbstract)" }

idea/idea-completion/testData/injava/InterfaceDefaultImplsNonImported.java.193

@@ -1,11 +0,0 @@
-public class Testing {
-    public static void test() {
-        DefaultImpl<caret>
-    }
-}
-
-// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractFun" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractFunWithExpressionBody" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractProperty" }
-// EXIST:  { lookupString: "DefaultImpls", tailText: " defaultImpls.NonAbstractPropertyWithBody" }
-// ABSENT:  { lookupString: "DefaultImpls", tailText: " defaultImpls.AllAbstract" }

idea/idea-completion/testData/injava/stdlib/List.java

@@ -5,5 +5,5 @@ public class Testing {
 }
 
 // EXIST: EmptyList
-// EXIST: { lookupString:List,tailText:"<E> (java.util)" }
-// ABSENT:  { lookupString:List,tailText:"<E> (kotlin.collections)" }
+// EXIST: { lookupString:List,tailText:"<E> java.util" }
+// ABSENT:  { lookupString:List,tailText:"<E> kotlin.collections" }

idea/idea-completion/testData/injava/stdlib/List.java.192

@@ -0,0 +1,9 @@
+public class Testing {
+    public static void test() {
+        List<caret>
+    }
+}
+
+// EXIST: EmptyList
+// EXIST: { lookupString:List,tailText:"<E> (java.util)" }
+// ABSENT:  { lookupString:List,tailText:"<E> (kotlin.collections)" }

idea/idea-completion/testData/injava/stdlib/List.java.193

@@ -1,9 +0,0 @@
-public class Testing {
-    public static void test() {
-        List<caret>
-    }
-}
-
-// EXIST: EmptyList
-// EXIST: { lookupString:List,tailText:"<E> java.util" }
-// ABSENT:  { lookupString:List,tailText:"<E> kotlin.collections" }

idea/idea-completion/tests/org/jetbrains/kotlin/idea/completion/test/AbstractKotlinSourceInJavaCompletionTest.kt

@@ -27,7 +27,7 @@ abstract class AbstractKotlinSourceInJavaCompletionTest : KotlinFixtureCompletio
 
         val paths = collectPaths(mockLibDir).toTypedArray()
         paths.forEach { path ->
-            val vFile = myFixture.copyFileToProject(path, path.substring(mockPath.length))
+            val vFile = myFixture.copyFileToProject(path.substringAfter(testDataPath), path.substring(mockPath.length))
             myFixture.configureFromExistingVirtualFile(vFile)
         }
 

idea/idea-completion/tests/org/jetbrains/kotlin/idea/completion/test/AbstractKotlinSourceInJavaCompletionTest.kt.192

@@ -27,7 +27,7 @@ abstract class AbstractKotlinSourceInJavaCompletionTest : KotlinFixtureCompletio
 
         val paths = collectPaths(mockLibDir).toTypedArray()
         paths.forEach { path ->
-            val vFile = myFixture.copyFileToProject(path.substringAfter(testDataPath), path.substring(mockPath.length))
+            val vFile = myFixture.copyFileToProject(path, path.substring(mockPath.length))
             myFixture.configureFromExistingVirtualFile(vFile)
         }
 

idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/dependencies/JavaClassesInScriptDependenciesShortNameCache.kt

@@ -46,8 +46,6 @@ class JavaClassesInScriptDependenciesShortNameCache(private val project: Project
 
     override fun getAllMethodNames() = emptyArray<String>()
 
-    override fun getAllMethodNames(set: HashSet<String>) {}
-
     override fun getFieldsByName(name: String, scope: GlobalSearchScope) = PsiField.EMPTY_ARRAY
 
     override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int) = PsiMethod.EMPTY_ARRAY
@@ -56,7 +54,5 @@ class JavaClassesInScriptDependenciesShortNameCache(private val project: Project
 
     override fun getAllFieldNames() = emptyArray<String>()
 
-    override fun getAllFieldNames(set: HashSet<String>) {}
-
     override fun getFieldsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int) = PsiField.EMPTY_ARRAY
 }

idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/dependencies/JavaClassesInScriptDependenciesShortNameCache.kt.192

@@ -46,6 +46,8 @@ class JavaClassesInScriptDependenciesShortNameCache(private val project: Project
 
     override fun getAllMethodNames() = emptyArray<String>()
 
+    override fun getAllMethodNames(set: HashSet<String>) {}
+
     override fun getFieldsByName(name: String, scope: GlobalSearchScope) = PsiField.EMPTY_ARRAY
 
     override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int) = PsiMethod.EMPTY_ARRAY
@@ -54,5 +56,7 @@ class JavaClassesInScriptDependenciesShortNameCache(private val project: Project
 
     override fun getAllFieldNames() = emptyArray<String>()
 
+    override fun getAllFieldNames(set: HashSet<String>) {}
+
     override fun getFieldsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int) = PsiField.EMPTY_ARRAY
 }

idea/idea-git/src/org/jetbrains/kotlin/git/KotlinExplicitMovementProvider.kt

@@ -7,17 +7,12 @@ package org.jetbrains.kotlin.git
 
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Couple
-import com.intellij.openapi.util.registry.Registry
 import com.intellij.openapi.vcs.FilePath
 import git4idea.checkin.GitCheckinExplicitMovementProvider
 import org.jetbrains.kotlin.idea.actions.pathBeforeJ2K
 import java.util.*
 
 class KotlinExplicitMovementProvider : GitCheckinExplicitMovementProvider() {
-    init {
-        Registry.get("git.explicit.commit.renames.prohibit.multiple.calls").setValue(false)
-    }
-
     override fun isEnabled(project: Project): Boolean {
         return true
     }

idea/idea-git/src/org/jetbrains/kotlin/git/KotlinExplicitMovementProvider.kt.192

@@ -7,12 +7,17 @@ package org.jetbrains.kotlin.git
 
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Couple
+import com.intellij.openapi.util.registry.Registry
 import com.intellij.openapi.vcs.FilePath
 import git4idea.checkin.GitCheckinExplicitMovementProvider
 import org.jetbrains.kotlin.idea.actions.pathBeforeJ2K
 import java.util.*
 
 class KotlinExplicitMovementProvider : GitCheckinExplicitMovementProvider() {
+    init {
+        Registry.get("git.explicit.commit.renames.prohibit.multiple.calls").setValue(false)
+    }
+
     override fun isEnabled(project: Project): Boolean {
         return true
     }

idea/idea-gradle/src/org/jetbrains/kotlin/idea/actions/ShowKotlinGradleDslLogs.kt

@@ -26,18 +26,19 @@ class ShowKotlinGradleDslLogs : IntentionAction, AnAction(), DumbAware {
     }
 
     override fun actionPerformed(e: AnActionEvent) {
-        openLogsDirIfPresent(e.project)
+        val project = e.project ?: return
+        openLogsDirIfPresent(project)
     }
 
     override fun isAvailable(project: Project, editor: Editor?, file: PsiFile?) = ShowFilePathAction.isSupported()
 
     override fun update(e: AnActionEvent) {
         val presentation = e.presentation
-        presentation.isVisible = ShowFilePathAction.isSupported()
+        presentation.isEnabledAndVisible = e.project != null && ShowFilePathAction.isSupported()
         presentation.text = NAME
     }
 
-    private fun openLogsDirIfPresent(project: Project?) {
+    private fun openLogsDirIfPresent(project: Project) {
         val logsDir = findLogsDir()
         if (logsDir != null) {
             ShowFilePathAction.openDirectory(logsDir)

idea/idea-gradle/src/org/jetbrains/kotlin/idea/actions/ShowKotlinGradleDslLogs.kt.192

@@ -26,19 +26,18 @@ class ShowKotlinGradleDslLogs : IntentionAction, AnAction(), DumbAware {
     }
 
     override fun actionPerformed(e: AnActionEvent) {
-        val project = e.project ?: return
-        openLogsDirIfPresent(project)
+        openLogsDirIfPresent(e.project)
     }
 
     override fun isAvailable(project: Project, editor: Editor?, file: PsiFile?) = ShowFilePathAction.isSupported()
 
     override fun update(e: AnActionEvent) {
         val presentation = e.presentation
-        presentation.isEnabledAndVisible = e.project != null && ShowFilePathAction.isSupported()
+        presentation.isVisible = ShowFilePathAction.isSupported()
         presentation.text = NAME
     }
 
-    private fun openLogsDirIfPresent(project: Project) {
+    private fun openLogsDirIfPresent(project: Project?) {
         val logsDir = findLogsDir()
         if (logsDir != null) {
             ShowFilePathAction.openDirectory(logsDir)

idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinGradleAbstractMultiplatformModuleBuilder.kt

@@ -10,10 +10,8 @@ import com.intellij.ide.util.projectWizard.WizardContext
 import com.intellij.openapi.externalSystem.ExternalSystemModulePropertyManager
 import com.intellij.openapi.externalSystem.model.ProjectSystemId
 import com.intellij.openapi.externalSystem.model.project.ModuleData
-import com.intellij.openapi.externalSystem.service.project.wizard.ExternalModuleSettingsStep
 import com.intellij.openapi.externalSystem.util.ExternalSystemApiUtil
 import com.intellij.openapi.module.Module
-import com.intellij.openapi.roots.ui.configuration.ModulesProvider
 import com.intellij.openapi.vfs.VfsUtil
 import com.intellij.openapi.vfs.VirtualFile
 import org.jetbrains.kotlin.idea.KotlinIcons
@@ -23,11 +21,13 @@ import org.jetbrains.kotlin.konan.target.KonanTarget
 import org.jetbrains.kotlin.konan.target.TargetSupportException
 import org.jetbrains.plugins.gradle.frameworkSupport.BuildScriptDataBuilder
 import org.jetbrains.plugins.gradle.service.project.wizard.GradleModuleBuilder
-import org.jetbrains.plugins.gradle.service.settings.GradleProjectSettingsControl
 import org.jetbrains.plugins.gradle.settings.DistributionType
 import com.intellij.openapi.externalSystem.model.project.ProjectData
+import com.intellij.openapi.externalSystem.service.project.wizard.ExternalModuleSettingsStep
+import com.intellij.openapi.roots.ui.configuration.ModulesProvider
 import org.jetbrains.kotlin.idea.statistics.FUSEventGroups
 import org.jetbrains.kotlin.idea.statistics.KotlinFUSLogger
+import org.jetbrains.plugins.gradle.service.settings.GradleProjectSettingsControl
 import javax.swing.Icon
 
 abstract class KotlinGradleAbstractMultiplatformModuleBuilder(
@@ -38,6 +38,20 @@ abstract class KotlinGradleAbstractMultiplatformModuleBuilder(
 
     override fun getNodeIcon(): Icon = KotlinIcons.MPP
 
+	/*
+    This overriding is a temporary workaround of a problem with how we use GradleModuleBuilder().
+    IDEA implies that we will create new GradleModuleBuilder every time we call Kotlin New Project Wizard.
+    But we create it once for every kind of GradleModuleBuilder-based New Project Wizard and the just reuse it.
+    How the problem looks for a user: KT-34229
+    Ticket that should properly fix it: KT-34591
+     */
+    override fun cleanup() {
+        super.cleanup()
+        this.name = null
+        this.contentEntryPath = null
+        this.moduleFilePath = null
+    }
+
     override fun createWizardSteps(wizardContext: WizardContext, modulesProvider: ModulesProvider): Array<ModuleWizardStep> {
         super.createWizardSteps(wizardContext, modulesProvider)  // initializes GradleModuleBuilder.myWizardContext
         return arrayOf(

idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinGradleAbstractMultiplatformModuleBuilder.kt.192

@@ -10,8 +10,10 @@ import com.intellij.ide.util.projectWizard.WizardContext
 import com.intellij.openapi.externalSystem.ExternalSystemModulePropertyManager
 import com.intellij.openapi.externalSystem.model.ProjectSystemId
 import com.intellij.openapi.externalSystem.model.project.ModuleData
+import com.intellij.openapi.externalSystem.service.project.wizard.ExternalModuleSettingsStep
 import com.intellij.openapi.externalSystem.util.ExternalSystemApiUtil
 import com.intellij.openapi.module.Module
+import com.intellij.openapi.roots.ui.configuration.ModulesProvider
 import com.intellij.openapi.vfs.VfsUtil
 import com.intellij.openapi.vfs.VirtualFile
 import org.jetbrains.kotlin.idea.KotlinIcons
@@ -21,13 +23,11 @@ import org.jetbrains.kotlin.konan.target.KonanTarget
 import org.jetbrains.kotlin.konan.target.TargetSupportException
 import org.jetbrains.plugins.gradle.frameworkSupport.BuildScriptDataBuilder
 import org.jetbrains.plugins.gradle.service.project.wizard.GradleModuleBuilder
+import org.jetbrains.plugins.gradle.service.settings.GradleProjectSettingsControl
 import org.jetbrains.plugins.gradle.settings.DistributionType
 import com.intellij.openapi.externalSystem.model.project.ProjectData
-import com.intellij.openapi.externalSystem.service.project.wizard.ExternalModuleSettingsStep
-import com.intellij.openapi.roots.ui.configuration.ModulesProvider
 import org.jetbrains.kotlin.idea.statistics.FUSEventGroups
 import org.jetbrains.kotlin.idea.statistics.KotlinFUSLogger
-import org.jetbrains.plugins.gradle.service.settings.GradleProjectSettingsControl
 import javax.swing.Icon
 
 abstract class KotlinGradleAbstractMultiplatformModuleBuilder(
@@ -38,20 +38,6 @@ abstract class KotlinGradleAbstractMultiplatformModuleBuilder(
 
     override fun getNodeIcon(): Icon = KotlinIcons.MPP
 
-	/*
-    This overriding is a temporary workaround of a problem with how we use GradleModuleBuilder().
-    IDEA implies that we will create new GradleModuleBuilder every time we call Kotlin New Project Wizard.
-    But we create it once for every kind of GradleModuleBuilder-based New Project Wizard and the just reuse it.
-    How the problem looks for a user: KT-34229
-    Ticket that should properly fix it: KT-34591
-     */
-    override fun cleanup() {
-        super.cleanup()
-        this.name = null
-        this.contentEntryPath = null
-        this.moduleFilePath = null
-    }
-
     override fun createWizardSteps(wizardContext: WizardContext, modulesProvider: ModulesProvider): Array<ModuleWizardStep> {
         super.createWizardSteps(wizardContext, modulesProvider)  // initializes GradleModuleBuilder.myWizardContext
         return arrayOf(

idea/idea-gradle/src/org/jetbrains/kotlin/idea/scripting/gradle/importing/KotlinDslScriptModelResolver.kt

@@ -7,9 +7,11 @@ package org.jetbrains.kotlin.idea.scripting.gradle.importing
 
 import com.intellij.openapi.externalSystem.model.DataNode
 import com.intellij.openapi.externalSystem.model.project.ProjectData
+import org.gradle.tooling.model.GradleProject
 import org.gradle.tooling.model.idea.IdeaProject
 import org.gradle.tooling.model.kotlin.dsl.KotlinDslScriptsModel
 import org.jetbrains.kotlin.idea.scripting.gradle.kotlinDslScriptsModelImportSupported
+import org.jetbrains.plugins.gradle.model.Build
 
 class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
     override fun getModelProvider() = KotlinDslScriptModelProvider()
@@ -19,7 +21,7 @@ class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
         super.populateProjectExtraModels(gradleProject, ideProject)
 
         if (kotlinDslScriptsModelImportSupported(resolverCtx.projectGradleVersion)) {
-            populateBuildModels(gradleProject, ideProject)
+            populateBuildModels(resolverCtx.models.mainBuild, ideProject)
 
             resolverCtx.models.includedBuilds.forEach { includedRoot ->
                 populateBuildModels(includedRoot, ideProject)
@@ -28,12 +30,12 @@ class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
     }
 
     private fun populateBuildModels(
-        root: IdeaProject,
+        root: Build,
         ideProject: DataNode<ProjectData>
     ) {
-        root.modules.forEach {
-            if (it.gradleProject.parent == null) {
-                resolverCtx.getExtraProject(it, KotlinDslScriptsModel::class.java)?.let { model ->
+        root.projects.forEach {
+            if ((it as? GradleProject)?.parent == null) {
+                resolverCtx.models.getModel(it, KotlinDslScriptsModel::class.java)?.let { model ->
                     ideProject.KOTLIN_DSL_SCRIPT_MODELS.addAll(model.toListOfScriptModels())
                 }
             }

idea/idea-gradle/src/org/jetbrains/kotlin/idea/scripting/gradle/importing/KotlinDslScriptModelResolver.kt.192

@@ -7,11 +7,9 @@ package org.jetbrains.kotlin.idea.scripting.gradle.importing
 
 import com.intellij.openapi.externalSystem.model.DataNode
 import com.intellij.openapi.externalSystem.model.project.ProjectData
-import org.gradle.tooling.model.GradleProject
 import org.gradle.tooling.model.idea.IdeaProject
 import org.gradle.tooling.model.kotlin.dsl.KotlinDslScriptsModel
 import org.jetbrains.kotlin.idea.scripting.gradle.kotlinDslScriptsModelImportSupported
-import org.jetbrains.plugins.gradle.model.Build
 
 class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
     override fun getModelProvider() = KotlinDslScriptModelProvider()
@@ -21,7 +19,7 @@ class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
         super.populateProjectExtraModels(gradleProject, ideProject)
 
         if (kotlinDslScriptsModelImportSupported(resolverCtx.projectGradleVersion)) {
-            populateBuildModels(resolverCtx.models.mainBuild, ideProject)
+            populateBuildModels(gradleProject, ideProject)
 
             resolverCtx.models.includedBuilds.forEach { includedRoot ->
                 populateBuildModels(includedRoot, ideProject)
@@ -30,12 +28,12 @@ class KotlinDslScriptModelResolver : KotlinDslScriptModelResolverCommon() {
     }
 
     private fun populateBuildModels(
-        root: Build,
+        root: IdeaProject,
         ideProject: DataNode<ProjectData>
     ) {
-        root.projects.forEach {
-            if ((it as? GradleProject)?.parent == null) {
-                resolverCtx.models.getModel(it, KotlinDslScriptsModel::class.java)?.let { model ->
+        root.modules.forEach {
+            if (it.gradleProject.parent == null) {
+                resolverCtx.getExtraProject(it, KotlinDslScriptsModel::class.java)?.let { model ->
                     ideProject.KOTLIN_DSL_SCRIPT_MODELS.addAll(model.toListOfScriptModels())
                 }
             }

idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/actions/RunScratchAction.kt

@@ -21,7 +21,10 @@ import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.keymap.KeymapManager
 import com.intellij.openapi.keymap.KeymapUtil
 import com.intellij.openapi.project.DumbService
+import com.intellij.task.ProjectTaskContext
 import com.intellij.task.ProjectTaskManager
+import com.intellij.task.ProjectTaskNotification
+import com.intellij.task.ProjectTaskResult
 import org.jetbrains.kotlin.idea.KotlinBundle
 import org.jetbrains.kotlin.idea.scratch.*
 import org.jetbrains.kotlin.idea.scratch.printDebugMessage
@@ -72,19 +75,21 @@ class RunScratchAction : ScratchAction(
 
             if (!isAutoRun && module != null && isMakeBeforeRun) {
                 val project = scratchFile.project
-                ProjectTaskManager.getInstance(project).build(arrayOf(module)) { result ->
-                    if (result.isAborted || result.errors > 0) {
-                        executor.errorOccurs("There were compilation errors in module ${module.name}")
-                    }
+                ProjectTaskManager.getInstance(project).build(arrayOf(module), object : ProjectTaskNotification {
+                    override fun finished(context: ProjectTaskContext, executionResult: ProjectTaskResult) {
+                        if (executionResult.isAborted || executionResult.errors > 0) {
+                            executor.errorOccurs("There were compilation errors in module ${module.name}")
+                        }
 
-                    if (DumbService.isDumb(project)) {
-                        DumbService.getInstance(project).smartInvokeLater {
+                        if (DumbService.isDumb(project)) {
+                            DumbService.getInstance(project).smartInvokeLater {
+                                executeScratch()
+                            }
+                        } else {
                             executeScratch()
                         }
-                    } else {
-                        executeScratch()
                     }
-                }
+                })
             } else {
                 executeScratch()
             }

idea/idea-jvm/src/org/jetbrains/kotlin/idea/scratch/actions/RunScratchAction.kt.192

@@ -21,10 +21,7 @@ import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.keymap.KeymapManager
 import com.intellij.openapi.keymap.KeymapUtil
 import com.intellij.openapi.project.DumbService
-import com.intellij.task.ProjectTaskContext
 import com.intellij.task.ProjectTaskManager
-import com.intellij.task.ProjectTaskNotification
-import com.intellij.task.ProjectTaskResult
 import org.jetbrains.kotlin.idea.KotlinBundle
 import org.jetbrains.kotlin.idea.scratch.*
 import org.jetbrains.kotlin.idea.scratch.printDebugMessage
@@ -75,21 +72,19 @@ class RunScratchAction : ScratchAction(
 
             if (!isAutoRun && module != null && isMakeBeforeRun) {
                 val project = scratchFile.project
-                ProjectTaskManager.getInstance(project).build(arrayOf(module), object : ProjectTaskNotification {
-                    override fun finished(context: ProjectTaskContext, executionResult: ProjectTaskResult) {
-                        if (executionResult.isAborted || executionResult.errors > 0) {
-                            executor.errorOccurs("There were compilation errors in module ${module.name}")
-                        }
+                ProjectTaskManager.getInstance(project).build(arrayOf(module)) { result ->
+                    if (result.isAborted || result.errors > 0) {
+                        executor.errorOccurs("There were compilation errors in module ${module.name}")
+                    }
 
-                        if (DumbService.isDumb(project)) {
-                            DumbService.getInstance(project).smartInvokeLater {
-                                executeScratch()
-                            }
-                        } else {
+                    if (DumbService.isDumb(project)) {
+                        DumbService.getInstance(project).smartInvokeLater {
                             executeScratch()
                         }
+                    } else {
+                        executeScratch()
                     }
-                })
+                }
             } else {
                 executeScratch()
             }

idea/idea-repl/src/org/jetbrains/kotlin/console/ConsoleCompilerHelper.kt

@@ -22,7 +22,10 @@ import com.intellij.execution.ui.RunContentDescriptor
 import com.intellij.openapi.compiler.CompilerManager
 import com.intellij.openapi.module.Module
 import com.intellij.openapi.project.Project
+import com.intellij.task.ProjectTaskContext
 import com.intellij.task.ProjectTaskManager
+import com.intellij.task.ProjectTaskNotification
+import com.intellij.task.ProjectTaskResult
 
 class ConsoleCompilerHelper(
     private val project: Project,
@@ -39,11 +42,13 @@ class ConsoleCompilerHelper(
 
     fun compileModule() {
         if (ExecutionManager.getInstance(project).contentManager.removeRunContent(executor, contentDescriptor)) {
-            ProjectTaskManager.getInstance(project).build(arrayOf(module)) { result ->
-                if (!module.isDisposed) {
-                    KotlinConsoleKeeper.getInstance(project).run(module, previousCompilationFailed = result.errors > 0)
+            ProjectTaskManager.getInstance(project).build(arrayOf(module), object : ProjectTaskNotification {
+                override fun finished(context: ProjectTaskContext, executionResult: ProjectTaskResult) {
+                    if (!module.isDisposed) {
+                        KotlinConsoleKeeper.getInstance(project).run(module, previousCompilationFailed = executionResult.errors > 0)
+                    }
                 }
-            }
+            })
         }
     }
 }

idea/idea-repl/src/org/jetbrains/kotlin/console/ConsoleCompilerHelper.kt.192

@@ -22,10 +22,7 @@ import com.intellij.execution.ui.RunContentDescriptor
 import com.intellij.openapi.compiler.CompilerManager
 import com.intellij.openapi.module.Module
 import com.intellij.openapi.project.Project
-import com.intellij.task.ProjectTaskContext
 import com.intellij.task.ProjectTaskManager
-import com.intellij.task.ProjectTaskNotification
-import com.intellij.task.ProjectTaskResult
 
 class ConsoleCompilerHelper(
     private val project: Project,
@@ -42,13 +39,11 @@ class ConsoleCompilerHelper(
 
     fun compileModule() {
         if (ExecutionManager.getInstance(project).contentManager.removeRunContent(executor, contentDescriptor)) {
-            ProjectTaskManager.getInstance(project).build(arrayOf(module), object : ProjectTaskNotification {
-                override fun finished(context: ProjectTaskContext, executionResult: ProjectTaskResult) {
-                    if (!module.isDisposed) {
-                        KotlinConsoleKeeper.getInstance(project).run(module, previousCompilationFailed = executionResult.errors > 0)
-                    }
+            ProjectTaskManager.getInstance(project).build(arrayOf(module)) { result ->
+                if (!module.isDisposed) {
+                    KotlinConsoleKeeper.getInstance(project).run(module, previousCompilationFailed = result.errors > 0)
                 }
-            })
+            }
         }
     }
 }

idea/idea-test-framework/test/org/jetbrains/kotlin/idea/test/KotlinLightCodeInsightFixtureTestCase.kt

@@ -86,9 +86,9 @@ abstract class KotlinLightCodeInsightFixtureTestCase : KotlinLightCodeInsightFix
         UnusedSymbolInspection()
 
         (StartupManager.getInstance(project) as StartupManagerImpl).runPostStartupActivities()
-        VfsRootAccess.allowRootAccess(KotlinTestUtils.getHomeDirectory())
+        VfsRootAccess.allowRootAccess(project, KotlinTestUtils.getHomeDirectory())
 
-        project.getComponent(EditorTracker::class.java)?.projectOpened()
+        EditorTracker.getInstance(project)
 
         invalidateLibraryCache(project)
 
@@ -105,8 +105,6 @@ abstract class KotlinLightCodeInsightFixtureTestCase : KotlinLightCodeInsightFix
     override fun tearDown() {
         LoggedErrorProcessor.restoreDefaultProcessor()
 
-        VfsRootAccess.disallowRootAccess(KotlinTestUtils.getHomeDirectory())
-
         super.tearDown()
 
         if (exceptions.isNotEmpty()) {

idea/idea-test-framework/test/org/jetbrains/kotlin/idea/test/KotlinLightCodeInsightFixtureTestCase.kt.192

@@ -86,9 +86,9 @@ abstract class KotlinLightCodeInsightFixtureTestCase : KotlinLightCodeInsightFix
         UnusedSymbolInspection()
 
         (StartupManager.getInstance(project) as StartupManagerImpl).runPostStartupActivities()
-        VfsRootAccess.allowRootAccess(project, KotlinTestUtils.getHomeDirectory())
+        VfsRootAccess.allowRootAccess(KotlinTestUtils.getHomeDirectory())
 
-        EditorTracker.getInstance(project)
+        project.getComponent(EditorTracker::class.java)?.projectOpened()
 
         invalidateLibraryCache(project)
 
@@ -105,6 +105,8 @@ abstract class KotlinLightCodeInsightFixtureTestCase : KotlinLightCodeInsightFix
     override fun tearDown() {
         LoggedErrorProcessor.restoreDefaultProcessor()
 
+        VfsRootAccess.disallowRootAccess(KotlinTestUtils.getHomeDirectory())
+
         super.tearDown()
 
         if (exceptions.isNotEmpty()) {

idea/idea-test-framework/test/org/jetbrains/kotlin/idea/test/KotlinLightProjectDescriptor.java

@@ -17,8 +17,7 @@
 package org.jetbrains.kotlin.idea.test;
 
 import com.intellij.openapi.module.Module;
-import com.intellij.openapi.module.ModuleType;
-import com.intellij.openapi.module.StdModuleTypes;
+import com.intellij.openapi.module.ModuleTypeId;
 import com.intellij.openapi.projectRoots.Sdk;
 import com.intellij.openapi.roots.ContentEntry;
 import com.intellij.openapi.roots.ModifiableRootModel;
@@ -30,10 +29,11 @@ public class KotlinLightProjectDescriptor extends LightProjectDescriptor {
     }
     
     public static final KotlinLightProjectDescriptor INSTANCE = new KotlinLightProjectDescriptor();
-    
+
+    @NotNull
     @Override
-    public ModuleType getModuleType() {
-        return StdModuleTypes.JAVA;
+    public String getModuleTypeId() {
+        return ModuleTypeId.JAVA_MODULE;
     }
 
     @Override

idea/idea-test-framework/test/org/jetbrains/kotlin/idea/test/KotlinLightProjectDescriptor.java.192

@@ -17,7 +17,8 @@
 package org.jetbrains.kotlin.idea.test;
 
 import com.intellij.openapi.module.Module;
-import com.intellij.openapi.module.ModuleTypeId;
+import com.intellij.openapi.module.ModuleType;
+import com.intellij.openapi.module.StdModuleTypes;
 import com.intellij.openapi.projectRoots.Sdk;
 import com.intellij.openapi.roots.ContentEntry;
 import com.intellij.openapi.roots.ModifiableRootModel;
@@ -29,11 +30,10 @@ public class KotlinLightProjectDescriptor extends LightProjectDescriptor {
     }
     
     public static final KotlinLightProjectDescriptor INSTANCE = new KotlinLightProjectDescriptor();
-
-    @NotNull
+    
     @Override
-    public String getModuleTypeId() {
-        return ModuleTypeId.JAVA_MODULE;
+    public ModuleType getModuleType() {
+        return StdModuleTypes.JAVA;
     }
 
     @Override

idea/jvm-debugger/jvm-debugger-coroutine/src/org/jetbrains/kotlin/idea/debugger/coroutine/CoroutineDebugConfigurationExtension.kt

@@ -20,7 +20,7 @@ class CoroutineDebugConfigurationExtension : RunConfigurationExtension() {
 
     override fun <T : RunConfigurationBase<*>?> updateJavaParameters(
         configuration: T,
-        params: JavaParameters?,
+        params: JavaParameters,
         runnerSettings: RunnerSettings?
     ) {
         if (runnerSettings is DebuggingRunnerData && configuration is RunConfigurationBase<*>) {

idea/jvm-debugger/jvm-debugger-coroutine/src/org/jetbrains/kotlin/idea/debugger/coroutine/CoroutineDebugConfigurationExtension.kt.192

@@ -20,7 +20,7 @@ class CoroutineDebugConfigurationExtension : RunConfigurationExtension() {
 
     override fun <T : RunConfigurationBase<*>?> updateJavaParameters(
         configuration: T,
-        params: JavaParameters,
+        params: JavaParameters?,
         runnerSettings: RunnerSettings?
     ) {
         if (runnerSettings is DebuggingRunnerData && configuration is RunConfigurationBase<*>) {

idea/performanceTests/org/jetbrains/kotlin/idea/testFramework/projectRoutines.kt

@@ -18,10 +18,11 @@ import com.intellij.openapi.project.ex.ProjectManagerEx
 import com.intellij.openapi.startup.StartupManager
 import com.intellij.psi.PsiDocumentManager
 import com.intellij.psi.impl.PsiDocumentManagerBase
-import com.intellij.testFramework.PlatformTestUtil
+import com.intellij.testFramework.ExtensionTestUtil
 import com.intellij.testFramework.runInEdtAndWait
 import com.intellij.util.ui.UIUtil
 import org.jetbrains.kotlin.idea.parameterInfo.HintType
+import java.nio.file.Paths
 import java.io.PrintWriter
 import java.io.StringWriter
 
@@ -66,7 +67,7 @@ fun dispatchAllInvocationEvents() {
 }
 
 fun loadProjectWithName(path: String, name: String): Project? =
-    ProjectManagerEx.getInstanceEx().loadProject(name, path)
+    ProjectManagerEx.getInstanceEx().loadProject(Paths.get(path), name)
 
 fun closeProject(project: Project) {
     dispatchAllInvocationEvents()
@@ -76,7 +77,7 @@ fun closeProject(project: Project) {
 
 fun runStartupActivities(project: Project) {
     with(StartupManager.getInstance(project) as StartupManagerImpl) {
-        scheduleInitialVfsRefresh()
+        //scheduleInitialVfsRefresh()
         runStartupActivities()
         runPostStartupActivities()
     }
@@ -87,7 +88,7 @@ fun waitForAllEditorsFinallyLoaded(project: Project) {
 }
 
 fun replaceWithCustomHighlighter(parentDisposable: Disposable, fromImplementationClass: String, toImplementationClass: String) {
-    val pointName = ExtensionPointName.create<LanguageExtensionPoint<Annotator>>(LanguageAnnotators.EP_NAME)
+    val pointName = ExtensionPointName.create<LanguageExtensionPoint<Annotator>>(LanguageAnnotators.EP_NAME.name)
     val extensionPoint = pointName.getPoint(null)
 
     val point = LanguageExtensionPoint<Annotator>()
@@ -100,7 +101,7 @@ fun replaceWithCustomHighlighter(parentDisposable: Disposable, fromImplementatio
             .toList()
     // custom highlighter is already registered if filteredExtensions has the same size as extensions
     if (filteredExtensions.size < extensions.size) {
-        PlatformTestUtil.maskExtensions(pointName, filteredExtensions + listOf(point), parentDisposable)
+        ExtensionTestUtil.maskExtensions(pointName, filteredExtensions + listOf(point), parentDisposable)
     }
 }
 

idea/performanceTests/org/jetbrains/kotlin/idea/testFramework/projectRoutines.kt.192

@@ -18,11 +18,10 @@ import com.intellij.openapi.project.ex.ProjectManagerEx
 import com.intellij.openapi.startup.StartupManager
 import com.intellij.psi.PsiDocumentManager
 import com.intellij.psi.impl.PsiDocumentManagerBase
-import com.intellij.testFramework.ExtensionTestUtil
+import com.intellij.testFramework.PlatformTestUtil
 import com.intellij.testFramework.runInEdtAndWait
 import com.intellij.util.ui.UIUtil
 import org.jetbrains.kotlin.idea.parameterInfo.HintType
-import java.nio.file.Paths
 import java.io.PrintWriter
 import java.io.StringWriter
 
@@ -67,7 +66,7 @@ fun dispatchAllInvocationEvents() {
 }
 
 fun loadProjectWithName(path: String, name: String): Project? =
-    ProjectManagerEx.getInstanceEx().loadProject(Paths.get(path), name)
+    ProjectManagerEx.getInstanceEx().loadProject(name, path)
 
 fun closeProject(project: Project) {
     dispatchAllInvocationEvents()
@@ -77,7 +76,7 @@ fun closeProject(project: Project) {
 
 fun runStartupActivities(project: Project) {
     with(StartupManager.getInstance(project) as StartupManagerImpl) {
-        //scheduleInitialVfsRefresh()
+        scheduleInitialVfsRefresh()
         runStartupActivities()
         runPostStartupActivities()
     }
@@ -88,7 +87,7 @@ fun waitForAllEditorsFinallyLoaded(project: Project) {
 }
 
 fun replaceWithCustomHighlighter(parentDisposable: Disposable, fromImplementationClass: String, toImplementationClass: String) {
-    val pointName = ExtensionPointName.create<LanguageExtensionPoint<Annotator>>(LanguageAnnotators.EP_NAME.name)
+    val pointName = ExtensionPointName.create<LanguageExtensionPoint<Annotator>>(LanguageAnnotators.EP_NAME)
     val extensionPoint = pointName.getPoint(null)
 
     val point = LanguageExtensionPoint<Annotator>()
@@ -101,7 +100,7 @@ fun replaceWithCustomHighlighter(parentDisposable: Disposable, fromImplementatio
             .toList()
     // custom highlighter is already registered if filteredExtensions has the same size as extensions
     if (filteredExtensions.size < extensions.size) {
-        ExtensionTestUtil.maskExtensions(pointName, filteredExtensions + listOf(point), parentDisposable)
+        PlatformTestUtil.maskExtensions(pointName, filteredExtensions + listOf(point), parentDisposable)
     }
 }
 

idea/resources/META-INF/plugin.xml

@@ -13,13 +13,13 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
   <version>@snapshot@</version>
   <vendor url="http://www.jetbrains.com">JetBrains</vendor>
 
-  <idea-version since-build="192.7142.36" until-build="192.*"/>
+  <idea-version since-build="193.4099.13" until-build="201.*"/>
 
   <depends>com.intellij.modules.platform</depends>
 
   <depends optional="true" config-file="junit.xml">JUnit</depends>
-  <depends optional="true" config-file="gradle.xml">org.jetbrains.plugins.gradle</depends>
-  <depends optional="true" config-file="gradle-java.xml">org.jetbrains.plugins.gradle.java</depends>
+  <depends optional="true" config-file="gradle.xml">com.intellij.gradle</depends>
+  <depends optional="true" config-file="gradle-java.xml">org.jetbrains.plugins.gradle</depends>
   <depends optional="true" config-file="gradle-groovy.xml">org.intellij.groovy</depends>
   <depends optional="true" config-file="maven.xml">org.jetbrains.idea.maven</depends>
   <depends optional="true" config-file="testng-j.xml">TestNG-J</depends>
@@ -82,10 +82,7 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
       <statistics.projectUsagesCollector implementation="org.jetbrains.kotlin.idea.statistics.ProjectConfigurationCollector"/>
 
       <fileTypeUsageSchemaDescriptor schema="Gradle Script" implementationClass="org.jetbrains.kotlin.idea.core.script.KotlinGradleScriptFileTypeSchemaDetector"/>
+
+      <completion.ml.model implementation="org.jetbrains.kotlin.idea.completion.ml.KotlinMLRankingProvider"/>
     </extensions>
-
-  <extensions defaultExtensionNs="com.intellij">
-    <focusModeProvider language="kotlin" implementationClass="org.jetbrains.kotlin.idea.core.KotlinFocusModeProvider" />
-  </extensions>
-
 </idea-plugin>

idea/resources/META-INF/plugin.xml.192

@@ -13,13 +13,13 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
   <version>@snapshot@</version>
   <vendor url="http://www.jetbrains.com">JetBrains</vendor>
 
-  <idea-version since-build="193.4099.13" until-build="201.*"/>
+  <idea-version since-build="192.7142.36" until-build="192.*"/>
 
   <depends>com.intellij.modules.platform</depends>
 
   <depends optional="true" config-file="junit.xml">JUnit</depends>
-  <depends optional="true" config-file="gradle.xml">com.intellij.gradle</depends>
-  <depends optional="true" config-file="gradle-java.xml">org.jetbrains.plugins.gradle</depends>
+  <depends optional="true" config-file="gradle.xml">org.jetbrains.plugins.gradle</depends>
+  <depends optional="true" config-file="gradle-java.xml">org.jetbrains.plugins.gradle.java</depends>
   <depends optional="true" config-file="gradle-groovy.xml">org.intellij.groovy</depends>
   <depends optional="true" config-file="maven.xml">org.jetbrains.idea.maven</depends>
   <depends optional="true" config-file="testng-j.xml">TestNG-J</depends>
@@ -82,7 +82,10 @@ The Kotlin plugin provides language support in IntelliJ IDEA and Android Studio.
       <statistics.projectUsagesCollector implementation="org.jetbrains.kotlin.idea.statistics.ProjectConfigurationCollector"/>
 
       <fileTypeUsageSchemaDescriptor schema="Gradle Script" implementationClass="org.jetbrains.kotlin.idea.core.script.KotlinGradleScriptFileTypeSchemaDetector"/>
-
-      <completion.ml.model implementation="org.jetbrains.kotlin.idea.completion.ml.KotlinMLRankingProvider"/>
     </extensions>
+
+  <extensions defaultExtensionNs="com.intellij">
+    <focusModeProvider language="kotlin" implementationClass="org.jetbrains.kotlin.idea.core.KotlinFocusModeProvider" />
+  </extensions>
+
 </idea-plugin>

idea/src/org/jetbrains/kotlin/idea/actions/internal/benchmark/AbstractCompletionBenchmarkAction.kt

@@ -83,9 +83,7 @@ abstract class AbstractCompletionBenchmarkAction : AnAction() {
             generateSequence { this.randomElement(random) }.distinct()
 
         internal fun collectSuitableKotlinFiles(project: Project, filePredicate: (KtFile) -> Boolean): MutableList<KtFile> {
-            val scope = object : DelegatingGlobalSearchScope(GlobalSearchScope.allScope(project)) {
-                override fun isSearchOutsideRootModel(): Boolean = false
-            }
+            val scope = GlobalSearchScope.allScope(project)
 
             fun KtFile.isUsableForBenchmark(): Boolean {
                 val moduleInfo = this.getNullableModuleInfo() ?: return false

idea/src/org/jetbrains/kotlin/idea/actions/internal/benchmark/AbstractCompletionBenchmarkAction.kt.192

@@ -83,7 +83,9 @@ abstract class AbstractCompletionBenchmarkAction : AnAction() {
             generateSequence { this.randomElement(random) }.distinct()
 
         internal fun collectSuitableKotlinFiles(project: Project, filePredicate: (KtFile) -> Boolean): MutableList<KtFile> {
-            val scope = GlobalSearchScope.allScope(project)
+            val scope = object : DelegatingGlobalSearchScope(GlobalSearchScope.allScope(project)) {
+                override fun isSearchOutsideRootModel(): Boolean = false
+            }
 
             fun KtFile.isUsableForBenchmark(): Boolean {
                 val moduleInfo = this.getNullableModuleInfo() ?: return false

idea/src/org/jetbrains/kotlin/idea/migration/kotlinMigrationProfile.kt

@@ -5,8 +5,6 @@
 
 package org.jetbrains.kotlin.idea.migration
 
-import com.intellij.codeInspection.InspectionEP
-import com.intellij.codeInspection.InspectionProfileEntry
 import com.intellij.codeInspection.ex.InspectionManagerEx
 import com.intellij.codeInspection.ex.InspectionProfileImpl
 import com.intellij.codeInspection.ex.InspectionToolWrapper
@@ -56,7 +54,7 @@ fun createMigrationProfile(
 
 fun applicableMigrationTools(migrationInfo: MigrationInfo) = applicableMigrationToolsImpl(migrationInfo)
 
-private fun applicableMigrationToolsImpl(migrationInfo: MigrationInfo?): List<InspectionToolWrapper<InspectionProfileEntry, InspectionEP>> {
+private fun applicableMigrationToolsImpl(migrationInfo: MigrationInfo?): List<InspectionToolWrapper<*, *>> {
     val rootProfile = InspectionProfileManager.getInstance().currentProfile
 
     return rootProfile.allTools.asSequence()

idea/src/org/jetbrains/kotlin/idea/migration/kotlinMigrationProfile.kt.192

@@ -5,6 +5,8 @@
 
 package org.jetbrains.kotlin.idea.migration
 
+import com.intellij.codeInspection.InspectionEP
+import com.intellij.codeInspection.InspectionProfileEntry
 import com.intellij.codeInspection.ex.InspectionManagerEx
 import com.intellij.codeInspection.ex.InspectionProfileImpl
 import com.intellij.codeInspection.ex.InspectionToolWrapper
@@ -54,7 +56,7 @@ fun createMigrationProfile(
 
 fun applicableMigrationTools(migrationInfo: MigrationInfo) = applicableMigrationToolsImpl(migrationInfo)
 
-private fun applicableMigrationToolsImpl(migrationInfo: MigrationInfo?): List<InspectionToolWrapper<*, *>> {
+private fun applicableMigrationToolsImpl(migrationInfo: MigrationInfo?): List<InspectionToolWrapper<InspectionProfileEntry, InspectionEP>> {
     val rootProfile = InspectionProfileManager.getInstance().currentProfile
 
     return rootProfile.allTools.asSequence()

idea/src/org/jetbrains/kotlin/idea/refactoring/kotlinRefactoringUtil.kt

@@ -41,7 +41,6 @@ import com.intellij.refactoring.BaseRefactoringProcessor.ConflictsInTestsExcepti
 import com.intellij.refactoring.changeSignature.ChangeSignatureUtil
 import com.intellij.refactoring.listeners.RefactoringEventData
 import com.intellij.refactoring.listeners.RefactoringEventListener
-import com.intellij.refactoring.rename.PsiElementRenameHandler
 import com.intellij.refactoring.ui.ConflictsDialog
 import com.intellij.refactoring.util.ConflictsUtil
 import com.intellij.refactoring.util.RefactoringUIUtil
@@ -485,7 +484,7 @@ private fun <T> copyTypeParameters(
         inserter(to, factory.createTypeParameterList())
         val targetTypeParamList = to.typeParameterList
         val newTypeParams = templateTypeParams.map {
-            factory.createTypeParameter(it.name, it.extendsList.referencedTypes)
+            factory.createTypeParameter(it.name!!, it.extendsList.referencedTypes)
         }
         ChangeSignatureUtil.synchronizeList(
             targetTypeParamList,
@@ -960,20 +959,17 @@ fun checkSuperMethodsWithPopup(
         append(" of ")
         append(SymbolPresentationUtil.getSymbolPresentableText(superClass))
     }
-
+    val list = JBList<String>(renameBase, renameCurrent)
     JBPopupFactory.getInstance()
-        .createPopupChooserBuilder(listOf(renameBase, renameCurrent))
+        .createListPopupBuilder(list)
         .setTitle(title)
         .setMovable(false)
         .setResizable(false)
         .setRequestFocus(true)
-        .setItemChosenCallback { selected ->
-            if (selected == renameBase) {
-                val ableToRename = declaration.project.let { project ->
-                    deepestSuperMethods.all { PsiElementRenameHandler.canRename(project, editor, it) }
-                }
-                if (ableToRename) action(deepestSuperMethods + declaration)
-            } else action(listOf(declaration))
+        .setItemChoosenCallback {
+            val value = list.selectedValue ?: return@setItemChoosenCallback
+            val chosenElements = if (value == renameBase) deepestSuperMethods + declaration else listOf(declaration)
+            action(chosenElements)
         }
         .createPopup()
         .showInBestPositionFor(editor)

idea/src/org/jetbrains/kotlin/idea/refactoring/kotlinRefactoringUtil.kt.192

@@ -41,6 +41,7 @@ import com.intellij.refactoring.BaseRefactoringProcessor.ConflictsInTestsExcepti
 import com.intellij.refactoring.changeSignature.ChangeSignatureUtil
 import com.intellij.refactoring.listeners.RefactoringEventData
 import com.intellij.refactoring.listeners.RefactoringEventListener
+import com.intellij.refactoring.rename.PsiElementRenameHandler
 import com.intellij.refactoring.ui.ConflictsDialog
 import com.intellij.refactoring.util.ConflictsUtil
 import com.intellij.refactoring.util.RefactoringUIUtil
@@ -484,7 +485,7 @@ private fun <T> copyTypeParameters(
         inserter(to, factory.createTypeParameterList())
         val targetTypeParamList = to.typeParameterList
         val newTypeParams = templateTypeParams.map {
-            factory.createTypeParameter(it.name!!, it.extendsList.referencedTypes)
+            factory.createTypeParameter(it.name, it.extendsList.referencedTypes)
         }
         ChangeSignatureUtil.synchronizeList(
             targetTypeParamList,
@@ -959,17 +960,20 @@ fun checkSuperMethodsWithPopup(
         append(" of ")
         append(SymbolPresentationUtil.getSymbolPresentableText(superClass))
     }
-    val list = JBList<String>(renameBase, renameCurrent)
+
     JBPopupFactory.getInstance()
-        .createListPopupBuilder(list)
+        .createPopupChooserBuilder(listOf(renameBase, renameCurrent))
         .setTitle(title)
         .setMovable(false)
         .setResizable(false)
         .setRequestFocus(true)
-        .setItemChoosenCallback {
-            val value = list.selectedValue ?: return@setItemChoosenCallback
-            val chosenElements = if (value == renameBase) deepestSuperMethods + declaration else listOf(declaration)
-            action(chosenElements)
+        .setItemChosenCallback { selected ->
+            if (selected == renameBase) {
+                val ableToRename = declaration.project.let { project ->
+                    deepestSuperMethods.all { PsiElementRenameHandler.canRename(project, editor, it) }
+                }
+                if (ableToRename) action(deepestSuperMethods + declaration)
+            } else action(listOf(declaration))
         }
         .createPopup()
         .showInBestPositionFor(editor)

idea/src/org/jetbrains/kotlin/idea/util/ProgressIndicatorUtils.kt

@@ -10,5 +10,5 @@ import java.util.concurrent.Future
 object ProgressIndicatorUtils {
     @JvmStatic
     fun <T> awaitWithCheckCanceled(future: Future<T>) =
-        com.intellij.openapi.progress.util.BackgroundTaskUtil.awaitWithCheckCanceled(future)
+        com.intellij.openapi.progress.util.ProgressIndicatorUtils.awaitWithCheckCanceled(future)
 }

idea/src/org/jetbrains/kotlin/idea/util/ProgressIndicatorUtils.kt.192

@@ -10,5 +10,5 @@ import java.util.concurrent.Future
 object ProgressIndicatorUtils {
     @JvmStatic
     fun <T> awaitWithCheckCanceled(future: Future<T>) =
-        com.intellij.openapi.progress.util.ProgressIndicatorUtils.awaitWithCheckCanceled(future)
+        com.intellij.openapi.progress.util.BackgroundTaskUtil.awaitWithCheckCanceled(future)
 }