Add more tests for PropertyAccessorDescriptor.isDeafult() usages

compiler/testData/diagnostics/tests/constructorConsistency/backing.kt

@@ -14,7 +14,13 @@ class My {
             field = value + if (w == "") 1 else 0
         }
 
+    var m: Int = 2
+        set
+
     init {
+        <!DEBUG_INFO_LEAKING_THIS!>x<!> = 3
+        <!DEBUG_INFO_LEAKING_THIS!>m<!> = 6
+
         // Writing properties using setters is dangerous
         <!DEBUG_INFO_LEAKING_THIS!>y<!> = 4
         this.<!DEBUG_INFO_LEAKING_THIS!>z<!> = 5

compiler/testData/diagnostics/tests/constructorConsistency/backing.txt

@@ -2,6 +2,7 @@ package
 
 public final class My {
     public constructor My()
+    public final var m: kotlin.Int
     public final val w: kotlin.String = "6"
     public final var x: kotlin.Int
     public final var y: kotlin.Int

compiler/testData/diagnostics/tests/constructorConsistency/getset.kt

@@ -8,7 +8,16 @@ class My(var x: String) {
 
     val z: String
 
+    var d: String = ""
+        get
+        set
+
+    val z1: String
+
     init {
+        <!DEBUG_INFO_LEAKING_THIS!>d<!> = "d"
+        if (<!DEBUG_INFO_LEAKING_THIS!>d<!> != "") z1 = this.<!DEBUG_INFO_LEAKING_THIS!>d<!> else z1 = <!DEBUG_INFO_LEAKING_THIS!>d<!>
+
         // Dangerous: setter!
         <!DEBUG_INFO_LEAKING_THIS!>y<!> = "x"
         // Dangerous: getter!

compiler/testData/diagnostics/tests/constructorConsistency/getset.txt

@@ -2,9 +2,11 @@ package
 
 public final class My {
     public constructor My(/*0*/ x: kotlin.String)
+    public final var d: kotlin.String
     public final var x: kotlin.String
     public final var y: kotlin.String
     public final val z: kotlin.String
+    public final val z1: kotlin.String
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
     public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String

compiler/testData/diagnostics/tests/modifiers/const/applicability.kt

@@ -44,6 +44,9 @@ const val delegated: Int <!CONST_VAL_WITH_DELEGATE!>by Delegate()<!>
 const val withGetter: Int
 <!CONST_VAL_WITH_GETTER!>get() = 13<!>
 
+const val withExplicitDefaultGetter: Int = 1
+    <!CONST_VAL_WITH_GETTER!>get<!>
+
 fun foo(): Int {
     <!WRONG_MODIFIER_TARGET!>const<!> val local: Int = 14
     return 15

compiler/testData/diagnostics/tests/modifiers/const/applicability.txt

@@ -11,6 +11,7 @@ private val privateTopLevel: kotlin.Int = 3
 public const var topLeveLVar: kotlin.Int
 public const val topLevel: kotlin.Int = 0
 public const val topLevelInferred: kotlin.Int = 1
+public const val withExplicitDefaultGetter: kotlin.Int = 1
 public const val withGetter: kotlin.Int
 public fun foo(): kotlin.Int
 

compiler/testData/diagnostics/tests/smartCasts/explicitDefaultGetter.kt

@@ -0,0 +1,11 @@
+class ExplicitAccessorForAnnotation {
+    val tt: String? = "good"
+        get
+
+    fun foo(): String {
+        if (tt is String) {
+            return <!SMARTCAST_IMPOSSIBLE!>tt<!>
+        }
+        return ""
+    }
+}

compiler/testData/diagnostics/tests/smartCasts/explicitDefaultGetter.txt

@@ -0,0 +1,10 @@
+package
+
+public final class ExplicitAccessorForAnnotation {
+    public constructor ExplicitAccessorForAnnotation()
+    public final val tt: kotlin.String? = "good"
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public final fun foo(): kotlin.String
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}

compiler/testData/diagnostics/testsWithStdLib/annotations/jvmField/jvmFieldApplicability.kt

@@ -4,6 +4,8 @@ fun foo() {
     <!WRONG_ANNOTATION_TARGET!>@kotlin.jvm.JvmField<!> val x = "A"
 }
 
+annotation class DemoAnnotation
+
 <!WRONG_ANNOTATION_TARGET!>@JvmField<!>
 abstract class C : I{
 
@@ -23,6 +25,22 @@ abstract class C : I{
     val customGetter: String = ""
         get() = field
 
+    <!INAPPLICABLE_JVM_FIELD!>@JvmField<!>
+    val explicitDefaultGetter: String = ""
+        get
+
+    <!INAPPLICABLE_JVM_FIELD!>@JvmField<!>
+    var explicitDefaultSetter: String = ""
+        set
+
+    <!INAPPLICABLE_JVM_FIELD!>@JvmField<!>
+    val explicitDefaultAnnotatedGetter: String = ""
+        @DemoAnnotation get
+
+    <!INAPPLICABLE_JVM_FIELD!>@JvmField<!>
+    var explicitDefaultAnnotatedSetter: String = ""
+        @DemoAnnotation set
+
     <!INAPPLICABLE_JVM_FIELD!>@JvmField<!>
     var customSetter: String = ""
         set(s) {

compiler/testData/diagnostics/testsWithStdLib/annotations/jvmField/jvmFieldApplicability.txt

@@ -14,6 +14,10 @@ package
     @kotlin.jvm.JvmField() public abstract val c: kotlin.Int
     @kotlin.jvm.JvmField() public final val customGetter: kotlin.String = ""
     @kotlin.jvm.JvmField() public final var customSetter: kotlin.String
+    @kotlin.jvm.JvmField() public final val explicitDefaultAnnotatedGetter: kotlin.String = ""
+    @kotlin.jvm.JvmField() public final var explicitDefaultAnnotatedSetter: kotlin.String
+    @kotlin.jvm.JvmField() public final val explicitDefaultGetter: kotlin.String = ""
+    @kotlin.jvm.JvmField() public final var explicitDefaultSetter: kotlin.String
     @kotlin.jvm.JvmField() public final val noBackingField: kotlin.String
     @kotlin.jvm.JvmField() private final val private: kotlin.Int = 3
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
@@ -22,6 +26,13 @@ package
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
 }
 
+public final annotation class DemoAnnotation : kotlin.Annotation {
+    public constructor DemoAnnotation()
+    public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
+    public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
+    public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
+}
+
 public final class G {
     public constructor G()
     @kotlin.jvm.JvmField() public final lateinit var lateInit: kotlin.String