FIR: Minor. Clarify name for containingClassForStaticMemberAttr

This commit is contained in:
Denis.Zharkov
2021-07-26 13:47:49 +03:00
committed by teamcityserver
parent 956bf22191
commit edf9f5e647
11 changed files with 23 additions and 23 deletions
@@ -17,7 +17,7 @@ import org.jetbrains.kotlin.fir.analysis.checkers.modality
import org.jetbrains.kotlin.fir.analysis.diagnostics.DiagnosticReporter import org.jetbrains.kotlin.fir.analysis.diagnostics.DiagnosticReporter
import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors import org.jetbrains.kotlin.fir.analysis.diagnostics.FirErrors
import org.jetbrains.kotlin.fir.analysis.diagnostics.reportOn import org.jetbrains.kotlin.fir.analysis.diagnostics.reportOn
import org.jetbrains.kotlin.fir.containingClassAttr import org.jetbrains.kotlin.fir.containingClassForStaticMemberAttr
import org.jetbrains.kotlin.fir.declarations.* import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertyAccessor import org.jetbrains.kotlin.fir.declarations.impl.FirDefaultPropertyAccessor
import org.jetbrains.kotlin.fir.declarations.utils.* import org.jetbrains.kotlin.fir.declarations.utils.*
@@ -207,7 +207,7 @@ internal fun FirRegularClassSymbol.isInlineOrValueClass(): Boolean {
internal val FirDeclaration.isEnumEntryInitializer: Boolean internal val FirDeclaration.isEnumEntryInitializer: Boolean
get() { get() {
if (this !is FirConstructor || !this.isPrimary) return false if (this !is FirConstructor || !this.isPrimary) return false
return (containingClassAttr as? ConeClassLookupTagWithFixedSymbol)?.symbol?.classKind == ClassKind.ENUM_ENTRY return (containingClassForStaticMemberAttr as? ConeClassLookupTagWithFixedSymbol)?.symbol?.classKind == ClassKind.ENUM_ENTRY
} }
// contract: returns(true) implies (this is FirMemberDeclaration<*>) // contract: returns(true) implies (this is FirMemberDeclaration<*>)
@@ -176,7 +176,7 @@ fun deserializeClassToSymbol(
} }
resolvePhase = FirResolvePhase.ANALYZED_DEPENDENCIES resolvePhase = FirResolvePhase.ANALYZED_DEPENDENCIES
}.apply { }.apply {
containingClassAttr = context.dispatchReceiver!!.lookupTag containingClassForStaticMemberAttr = context.dispatchReceiver!!.lookupTag
} }
property property
@@ -501,7 +501,7 @@ class FirMemberDeserializer(private val c: FirDeserializationContext) {
containerSource = c.containerSource containerSource = c.containerSource
deprecation = annotations.getDeprecationInfosFromAnnotations(c.session.languageVersionSettings.apiVersion, false) deprecation = annotations.getDeprecationInfosFromAnnotations(c.session.languageVersionSettings.apiVersion, false)
}.build().apply { }.build().apply {
containingClassAttr = c.dispatchReceiver!!.lookupTag containingClassForStaticMemberAttr = c.dispatchReceiver!!.lookupTag
versionRequirementsTable = c.versionRequirementTable versionRequirementsTable = c.versionRequirementTable
} }
} }
@@ -404,7 +404,7 @@ class JavaSymbolProvider(
origin = FirDeclarationOrigin.Java origin = FirDeclarationOrigin.Java
addAnnotationsFrom(this@JavaSymbolProvider.session, javaField, javaTypeParameterStack) addAnnotationsFrom(this@JavaSymbolProvider.session, javaField, javaTypeParameterStack)
}.apply { }.apply {
containingClassAttr = ConeClassLikeLookupTagImpl(classId) containingClassForStaticMemberAttr = ConeClassLikeLookupTagImpl(classId)
} }
else -> buildJavaField { else -> buildJavaField {
source = (javaField as? JavaElementImpl<*>)?.psi?.toFirPsiSourceElement() source = (javaField as? JavaElementImpl<*>)?.psi?.toFirPsiSourceElement()
@@ -434,7 +434,7 @@ class JavaSymbolProvider(
} }
}.apply { }.apply {
if (javaField.isStatic) { if (javaField.isStatic) {
containingClassAttr = ConeClassLikeLookupTagImpl(classId) containingClassForStaticMemberAttr = ConeClassLikeLookupTagImpl(classId)
} }
} }
} }
@@ -493,7 +493,7 @@ class JavaSymbolProvider(
} }
}.apply { }.apply {
if (javaMethod.isStatic) { if (javaMethod.isStatic) {
containingClassAttr = ConeClassLikeLookupTagImpl(classId) containingClassForStaticMemberAttr = ConeClassLikeLookupTagImpl(classId)
} }
} }
} }
@@ -554,7 +554,7 @@ class JavaSymbolProvider(
annotationBuilder = { emptyList() } annotationBuilder = { emptyList() }
} }
}.apply { }.apply {
containingClassAttr = ownerClassBuilder.symbol.toLookupTag() containingClassForStaticMemberAttr = ownerClassBuilder.symbol.toLookupTag()
} }
} }
@@ -578,7 +578,7 @@ class JavaSymbolProvider(
isPrimary = true isPrimary = true
annotationBuilder = { emptyList() } annotationBuilder = { emptyList() }
}.apply { }.apply {
containingClassAttr = ownerClassBuilder.symbol.toLookupTag() containingClassForStaticMemberAttr = ownerClassBuilder.symbol.toLookupTag()
} }
} }
@@ -734,7 +734,7 @@ class DeclarationsConverter(
} }
} }
}.also { }.also {
it.containingClassAttr = currentDispatchReceiverType()!!.lookupTag it.containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
} }
} }
@@ -848,7 +848,7 @@ class DeclarationsConverter(
delegatedConstructor = firDelegatedCall delegatedConstructor = firDelegatedCall
this.body = null this.body = null
}.apply { }.apply {
containingClassAttr = currentDispatchReceiverType()!!.lookupTag containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
}, valueParameters }, valueParameters
) )
} }
@@ -920,7 +920,7 @@ class DeclarationsConverter(
this.body = body this.body = body
context.firFunctionTargets.removeLast() context.firFunctionTargets.removeLast()
}.also { }.also {
it.containingClassAttr = currentDispatchReceiverType()!!.lookupTag it.containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
target.bind(it) target.bind(it)
} }
} }
@@ -793,7 +793,7 @@ open class RawFirBuilder(
this@toFirConstructor?.extractValueParametersTo(this) this@toFirConstructor?.extractValueParametersTo(this)
this.body = body this.body = body
}.apply { }.apply {
containingClassAttr = currentDispatchReceiverType()!!.lookupTag containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
} }
} }
@@ -895,7 +895,7 @@ open class RawFirBuilder(
} }
} }
}.apply { }.apply {
containingClassAttr = currentDispatchReceiverType()!!.lookupTag containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
} }
} }
@@ -1335,7 +1335,7 @@ open class RawFirBuilder(
this.body = body this.body = body
this@RawFirBuilder.context.firFunctionTargets.removeLast() this@RawFirBuilder.context.firFunctionTargets.removeLast()
}.also { }.also {
it.containingClassAttr = currentDispatchReceiverType()!!.lookupTag it.containingClassForStaticMemberAttr = currentDispatchReceiverType()!!.lookupTag
bindFunctionTarget(target, it) bindFunctionTarget(target, it)
} }
} }
@@ -1178,7 +1178,7 @@ abstract class BaseFirBuilder<T>(val baseSession: FirSession, val context: Conte
protected fun FirCallableDeclaration.initContainingClassAttr() { protected fun FirCallableDeclaration.initContainingClassAttr() {
val currentDispatchReceiverType = currentDispatchReceiverType() ?: return val currentDispatchReceiverType = currentDispatchReceiverType() ?: return
containingClassAttr = currentDispatchReceiverType.lookupTag containingClassForStaticMemberAttr = currentDispatchReceiverType.lookupTag
} }
private fun FirVariable.toQualifiedAccess(): FirQualifiedAccessExpression = buildQualifiedAccessExpression { private fun FirVariable.toQualifiedAccess(): FirQualifiedAccessExpression = buildQualifiedAccessExpression {
@@ -407,7 +407,7 @@ private fun initialTypeOfCandidate(candidate: Candidate, typeRef: FirResolvedTyp
return candidate.substitutor.substituteOrSelf(typeRef.type) return candidate.substitutor.substituteOrSelf(typeRef.type)
} }
fun FirCallableDeclaration.getContainingClass(session: FirSession): FirRegularClass? = this.containingClassAttr?.let { lookupTag -> fun FirCallableDeclaration.getContainingClass(session: FirSession): FirRegularClass? = this.containingClassForStaticMemberAttr?.let { lookupTag ->
session.symbolProvider.getSymbolByLookupTag(lookupTag)?.fir as? FirRegularClass session.symbolProvider.getSymbolByLookupTag(lookupTag)?.fir as? FirRegularClass
} }
@@ -9,7 +9,7 @@ import org.jetbrains.kotlin.descriptors.ClassKind
import org.jetbrains.kotlin.descriptors.EffectiveVisibility import org.jetbrains.kotlin.descriptors.EffectiveVisibility
import org.jetbrains.kotlin.descriptors.Modality import org.jetbrains.kotlin.descriptors.Modality
import org.jetbrains.kotlin.fir.FirSession import org.jetbrains.kotlin.fir.FirSession
import org.jetbrains.kotlin.fir.containingClassAttr import org.jetbrains.kotlin.fir.containingClassForStaticMemberAttr
import org.jetbrains.kotlin.fir.declarations.* import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.declarations.builder.FirTypeParameterBuilder import org.jetbrains.kotlin.fir.declarations.builder.FirTypeParameterBuilder
import org.jetbrains.kotlin.fir.declarations.builder.buildSimpleFunction import org.jetbrains.kotlin.fir.declarations.builder.buildSimpleFunction
@@ -217,7 +217,7 @@ class FirSamResolverImpl(
resolvePhase = FirResolvePhase.BODY_RESOLVE resolvePhase = FirResolvePhase.BODY_RESOLVE
}.apply { }.apply {
containingClassAttr = outerClassManager?.outerClass(firRegularClass.symbol)?.toLookupTag() containingClassForStaticMemberAttr = outerClassManager?.outerClass(firRegularClass.symbol)?.toLookupTag()
} }
} }
@@ -29,14 +29,14 @@ fun FirCallableDeclaration.dispatchReceiverClassOrNull(): ConeClassLikeLookupTag
fun FirCallableSymbol<*>.containingClass(): ConeClassLikeLookupTag? = fir.containingClass() fun FirCallableSymbol<*>.containingClass(): ConeClassLikeLookupTag? = fir.containingClass()
fun FirCallableDeclaration.containingClass(): ConeClassLikeLookupTag? { fun FirCallableDeclaration.containingClass(): ConeClassLikeLookupTag? {
return (containingClassAttr ?: dispatchReceiverClassOrNull()) return (containingClassForStaticMemberAttr ?: dispatchReceiverClassOrNull())
} }
fun FirRegularClass.containingClassForLocal(): ConeClassLikeLookupTag? = fun FirRegularClass.containingClassForLocal(): ConeClassLikeLookupTag? =
if (isLocal) containingClassForLocalAttr else null if (isLocal) containingClassForLocalAttr else null
private object ContainingClassKey : FirDeclarationDataKey() private object ContainingClassKey : FirDeclarationDataKey()
var FirCallableDeclaration.containingClassAttr: ConeClassLikeLookupTag? by FirDeclarationDataRegistry.data(ContainingClassKey) var FirCallableDeclaration.containingClassForStaticMemberAttr: ConeClassLikeLookupTag? by FirDeclarationDataRegistry.data(ContainingClassKey)
var FirRegularClass.containingClassForLocalAttr: ConeClassLikeLookupTag? by FirDeclarationDataRegistry.data(ContainingClassKey) var FirRegularClass.containingClassForLocalAttr: ConeClassLikeLookupTag? by FirDeclarationDataRegistry.data(ContainingClassKey)
val FirCallableDeclaration.isIntersectionOverride: Boolean get() = origin == FirDeclarationOrigin.IntersectionOverride val FirCallableDeclaration.isIntersectionOverride: Boolean get() = origin == FirDeclarationOrigin.IntersectionOverride
@@ -60,7 +60,7 @@ fun FirRegularClassBuilder.generateValuesFunction(
it.replaceTypeRef(returnTypeRef) it.replaceTypeRef(returnTypeRef)
} }
}.apply { }.apply {
containingClassAttr = this@generateValuesFunction.symbol.toLookupTag() containingClassForStaticMemberAttr = this@generateValuesFunction.symbol.toLookupTag()
} }
} }
@@ -104,7 +104,7 @@ fun FirRegularClassBuilder.generateValueOfFunction(
it.replaceTypeRef(returnTypeRef) it.replaceTypeRef(returnTypeRef)
} }
}.apply { }.apply {
containingClassAttr = this@generateValueOfFunction.symbol.toLookupTag() containingClassForStaticMemberAttr = this@generateValueOfFunction.symbol.toLookupTag()
} }
} }