From edce35a643ee200124341dc6dcc0941e4bceaeb6 Mon Sep 17 00:00:00 2001 From: Alexander Udalov Date: Fri, 21 Jun 2019 19:48:02 +0200 Subject: [PATCH] Minor, remove obsolete coroutines-related code from mapBuiltInType --- .../load/kotlin/typeSignatureMapping.kt | 19 +++---------------- .../kotlin/builtins/suspendFunctionTypes.kt | 5 ++--- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/core/descriptors.jvm/src/org/jetbrains/kotlin/load/kotlin/typeSignatureMapping.kt b/core/descriptors.jvm/src/org/jetbrains/kotlin/load/kotlin/typeSignatureMapping.kt index 6852aab0982..c7b40b02031 100644 --- a/core/descriptors.jvm/src/org/jetbrains/kotlin/load/kotlin/typeSignatureMapping.kt +++ b/core/descriptors.jvm/src/org/jetbrains/kotlin/load/kotlin/typeSignatureMapping.kt @@ -5,14 +5,14 @@ package org.jetbrains.kotlin.load.kotlin -import org.jetbrains.kotlin.builtins.* +import org.jetbrains.kotlin.builtins.KotlinBuiltIns +import org.jetbrains.kotlin.builtins.isSuspendFunctionType import org.jetbrains.kotlin.builtins.jvm.JavaToKotlinClassMap +import org.jetbrains.kotlin.builtins.transformSuspendFunctionToRuntimeFunctionType import org.jetbrains.kotlin.descriptors.* import org.jetbrains.kotlin.load.java.typeEnhancement.hasEnhancedNullability -import org.jetbrains.kotlin.name.ClassId import org.jetbrains.kotlin.name.Name import org.jetbrains.kotlin.name.SpecialNames -import org.jetbrains.kotlin.resolve.DescriptorUtils import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe import org.jetbrains.kotlin.resolve.jvm.JvmClassName import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType @@ -205,13 +205,6 @@ fun hasVoidReturnType(descriptor: CallableDescriptor): Boolean { && descriptor !is PropertyGetterDescriptor } -private fun continuationInternalName(releaseCoroutines: Boolean): String { - val fqName = - if (releaseCoroutines) DescriptorUtils.CONTINUATION_INTERFACE_FQ_NAME_RELEASE - else DescriptorUtils.CONTINUATION_INTERFACE_FQ_NAME_EXPERIMENTAL - return JvmClassName.byClassId(ClassId.topLevel(fqName)).internalName -} - private fun mapBuiltInType( type: KotlinType, typeFactory: JvmTypeFactory, @@ -219,12 +212,6 @@ private fun mapBuiltInType( ): T? { val descriptor = type.constructor.declarationDescriptor as? ClassDescriptor ?: return null - if (descriptor === FAKE_CONTINUATION_CLASS_DESCRIPTOR_EXPERIMENTAL) { - return typeFactory.createObjectType(continuationInternalName(false)) - } else if (descriptor == FAKE_CONTINUATION_CLASS_DESCRIPTOR_RELEASE) { - return typeFactory.createObjectType(continuationInternalName(true)) - } - val primitiveType = KotlinBuiltIns.getPrimitiveType(descriptor) if (primitiveType != null) { val jvmType = typeFactory.createFromString(JvmPrimitiveType.get(primitiveType).desc) diff --git a/core/descriptors/src/org/jetbrains/kotlin/builtins/suspendFunctionTypes.kt b/core/descriptors/src/org/jetbrains/kotlin/builtins/suspendFunctionTypes.kt index a099fafe6bd..9e8b4e5d2e5 100644 --- a/core/descriptors/src/org/jetbrains/kotlin/builtins/suspendFunctionTypes.kt +++ b/core/descriptors/src/org/jetbrains/kotlin/builtins/suspendFunctionTypes.kt @@ -16,13 +16,12 @@ import org.jetbrains.kotlin.descriptors.impl.TypeParameterDescriptorImpl import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.name.Name import org.jetbrains.kotlin.resolve.DescriptorUtils -import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe import org.jetbrains.kotlin.storage.LockBasedStorageManager import org.jetbrains.kotlin.types.* import org.jetbrains.kotlin.types.typeUtil.asTypeProjection import org.jetbrains.kotlin.types.typeUtil.builtIns -val FAKE_CONTINUATION_CLASS_DESCRIPTOR_EXPERIMENTAL = +private val FAKE_CONTINUATION_CLASS_DESCRIPTOR_EXPERIMENTAL = MutableClassDescriptor( EmptyPackageFragmentDescriptor(ErrorUtils.getErrorModule(), DescriptorUtils.COROUTINES_PACKAGE_FQ_NAME_EXPERIMENTAL), ClassKind.INTERFACE, /* isInner = */ false, /* isExternal = */ false, @@ -38,7 +37,7 @@ val FAKE_CONTINUATION_CLASS_DESCRIPTOR_EXPERIMENTAL = createTypeConstructor() } -val FAKE_CONTINUATION_CLASS_DESCRIPTOR_RELEASE = +private val FAKE_CONTINUATION_CLASS_DESCRIPTOR_RELEASE = MutableClassDescriptor( EmptyPackageFragmentDescriptor(ErrorUtils.getErrorModule(), DescriptorUtils.COROUTINES_PACKAGE_FQ_NAME_RELEASE), ClassKind.INTERFACE, /* isInner = */ false, /* isExternal = */ false,