diff --git a/compiler/backend/src/org/jetbrains/jet/codegen/state/BuilderFactoryForDuplicateSignatureDiagnostics.kt b/compiler/backend/src/org/jetbrains/jet/codegen/state/BuilderFactoryForDuplicateSignatureDiagnostics.kt index fda9db6b113..3c1c27a6e1c 100644 --- a/compiler/backend/src/org/jetbrains/jet/codegen/state/BuilderFactoryForDuplicateSignatureDiagnostics.kt +++ b/compiler/backend/src/org/jetbrains/jet/codegen/state/BuilderFactoryForDuplicateSignatureDiagnostics.kt @@ -21,7 +21,6 @@ import com.intellij.util.containers.MultiMap import org.jetbrains.jet.codegen.ClassBuilderFactory import org.jetbrains.jet.codegen.SignatureCollectingClassBuilderFactory import org.jetbrains.jet.lang.descriptors.* -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder import org.jetbrains.jet.lang.resolve.BindingContext import org.jetbrains.jet.lang.resolve.java.diagnostics.* import java.util.* @@ -31,11 +30,12 @@ import org.jetbrains.jet.utils.addIfNotNull import org.jetbrains.jet.codegen.ClassBuilderMode import org.jetbrains.jet.lang.resolve.java.descriptor.SamAdapterDescriptor import org.jetbrains.jet.lang.resolve.DescriptorToSourceUtils +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink class BuilderFactoryForDuplicateSignatureDiagnostics( builderFactory: ClassBuilderFactory, bindingContext: BindingContext, - private val diagnostics: DiagnosticHolder + private val diagnostics: DiagnosticSink ) : SignatureCollectingClassBuilderFactory(builderFactory) { // Avoid errors when some classes are not loaded for some reason diff --git a/compiler/backend/src/org/jetbrains/jet/codegen/state/GenerationState.java b/compiler/backend/src/org/jetbrains/jet/codegen/state/GenerationState.java index c872d036635..fb25e6537da 100644 --- a/compiler/backend/src/org/jetbrains/jet/codegen/state/GenerationState.java +++ b/compiler/backend/src/org/jetbrains/jet/codegen/state/GenerationState.java @@ -26,7 +26,7 @@ import org.jetbrains.jet.codegen.optimization.OptimizationClassBuilderFactory; import org.jetbrains.jet.codegen.when.MappingsClassesForWhenByEnum; import org.jetbrains.jet.lang.descriptors.ModuleDescriptor; import org.jetbrains.jet.lang.descriptors.ScriptDescriptor; -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder; +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink; import org.jetbrains.jet.lang.psi.JetClassOrObject; import org.jetbrains.jet.lang.psi.JetFile; import org.jetbrains.jet.lang.reflect.ReflectionTypes; @@ -120,7 +120,7 @@ public class GenerationState { @NotNull List files ) { this(project, builderFactory, Progress.DEAF, module, bindingContext, files, true, true, GenerateClassFilter.GENERATE_ALL, - false, false, null, null, DiagnosticHolder.DO_NOTHING, null); + false, false, null, null, DiagnosticSink.DO_NOTHING, null); } public GenerationState( @@ -137,7 +137,7 @@ public class GenerationState { boolean disableOptimization, @Nullable Collection packagesWithRemovedFiles, @Nullable String moduleId, - @NotNull DiagnosticHolder diagnostics, + @NotNull DiagnosticSink diagnostics, @Nullable File outDirectory ) { this.project = project; diff --git a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/kotlin/JavaDeclarationCheckerProvider.kt b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/kotlin/JavaDeclarationCheckerProvider.kt index e7bd4bb46da..99ac3d99051 100644 --- a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/kotlin/JavaDeclarationCheckerProvider.kt +++ b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/kotlin/JavaDeclarationCheckerProvider.kt @@ -17,11 +17,9 @@ package org.jetbrains.jet.lang.resolve.kotlin import org.jetbrains.jet.lang.resolve.AdditionalCheckerProvider -import com.google.common.collect.Lists import org.jetbrains.jet.lang.resolve.AnnotationChecker import org.jetbrains.jet.lang.psi.JetDeclaration import org.jetbrains.jet.lang.descriptors.MemberDescriptor -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder import org.jetbrains.jet.lang.resolve.annotations.hasPlatformStaticAnnotation import org.jetbrains.jet.lang.psi.JetNamedFunction import org.jetbrains.jet.lang.resolve.DescriptorUtils @@ -30,6 +28,7 @@ import org.jetbrains.jet.lang.resolve.java.diagnostics.ErrorsJvm import org.jetbrains.jet.lexer.JetTokens import org.jetbrains.jet.lang.psi.JetProperty import org.jetbrains.jet.lang.descriptors.PropertyDescriptor +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink public object JavaDeclarationCheckerProvider : AdditionalCheckerProvider { @@ -38,7 +37,7 @@ public object JavaDeclarationCheckerProvider : AdditionalCheckerProvider { public class PlatformStaticAnnotationChecker : AnnotationChecker { - override fun check(declaration: JetDeclaration, descriptor: MemberDescriptor, diagnosticHolder: DiagnosticHolder) { + override fun check(declaration: JetDeclaration, descriptor: MemberDescriptor, diagnosticHolder: DiagnosticSink) { if (descriptor.hasPlatformStaticAnnotation()) { if (declaration is JetNamedFunction) { val insideObject = DescriptorUtils.containerKindIs(descriptor, ClassKind.OBJECT) diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticHolder.java b/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticSink.java similarity index 90% rename from compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticHolder.java rename to compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticSink.java index 7e5e3a42115..2a89442d0da 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticHolder.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/diagnostics/DiagnosticSink.java @@ -23,13 +23,13 @@ import org.jetbrains.jet.lang.diagnostics.rendering.DefaultErrorMessages; import java.util.List; -public interface DiagnosticHolder { - DiagnosticHolder DO_NOTHING = new DiagnosticHolder() { +public interface DiagnosticSink { + DiagnosticSink DO_NOTHING = new DiagnosticSink() { @Override public void report(@NotNull Diagnostic diagnostic) { } }; - DiagnosticHolder THROW_EXCEPTION = new DiagnosticHolder() { + DiagnosticSink THROW_EXCEPTION = new DiagnosticSink() { @Override public void report(@NotNull Diagnostic diagnostic) { if (diagnostic.getSeverity() == Severity.ERROR) { diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnalyzingUtils.java b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnalyzingUtils.java index 9325329d687..f795a3548a0 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnalyzingUtils.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnalyzingUtils.java @@ -21,7 +21,7 @@ import com.intellij.psi.PsiErrorElement; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import org.jetbrains.jet.lang.diagnostics.Diagnostic; -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder; +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink; import org.jetbrains.jet.lang.diagnostics.DiagnosticUtils; import org.jetbrains.jet.lang.psi.JetElement; import org.jetbrains.jet.lang.psi.JetTreeVisitorVoid; @@ -60,7 +60,7 @@ public class AnalyzingUtils { public static void throwExceptionOnErrors(BindingContext bindingContext) { for (Diagnostic diagnostic : bindingContext.getDiagnostics()) { - DiagnosticHolder.THROW_EXCEPTION.report(diagnostic); + DiagnosticSink.THROW_EXCEPTION.report(diagnostic); } } diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnnotationChecker.kt b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnnotationChecker.kt index b1aa120bf0a..4fb1b601a59 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnnotationChecker.kt +++ b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/AnnotationChecker.kt @@ -17,13 +17,11 @@ package org.jetbrains.jet.lang.resolve import org.jetbrains.jet.lang.psi.JetDeclaration -import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor import org.jetbrains.jet.lang.descriptors.MemberDescriptor -import org.jetbrains.jet.lang.psi.JetDeclarationModifierList -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink public trait AnnotationChecker { - public fun check(declaration: JetDeclaration, descriptor: MemberDescriptor, diagnosticHolder: DiagnosticHolder); + public fun check(declaration: JetDeclaration, descriptor: MemberDescriptor, diagnosticHolder: DiagnosticSink); } \ No newline at end of file diff --git a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/BindingTrace.java b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/BindingTrace.java index b02b262592a..3d2afd8c575 100644 --- a/compiler/frontend/src/org/jetbrains/jet/lang/resolve/BindingTrace.java +++ b/compiler/frontend/src/org/jetbrains/jet/lang/resolve/BindingTrace.java @@ -18,13 +18,13 @@ package org.jetbrains.jet.lang.resolve; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder; +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink; import org.jetbrains.jet.util.slicedmap.ReadOnlySlice; import org.jetbrains.jet.util.slicedmap.WritableSlice; import java.util.Collection; -public interface BindingTrace extends DiagnosticHolder { +public interface BindingTrace extends DiagnosticSink { @NotNull BindingContext getBindingContext(); diff --git a/idea/src/org/jetbrains/jet/plugin/internal/KotlinBytecodeToolWindow.java b/idea/src/org/jetbrains/jet/plugin/internal/KotlinBytecodeToolWindow.java index ff6ef862c61..142afab296f 100644 --- a/idea/src/org/jetbrains/jet/plugin/internal/KotlinBytecodeToolWindow.java +++ b/idea/src/org/jetbrains/jet/plugin/internal/KotlinBytecodeToolWindow.java @@ -43,7 +43,7 @@ import org.jetbrains.jet.codegen.CompilationErrorHandler; import org.jetbrains.jet.codegen.KotlinCodegenFacade; import org.jetbrains.jet.codegen.state.GenerationState; import org.jetbrains.jet.codegen.state.Progress; -import org.jetbrains.jet.lang.diagnostics.DiagnosticHolder; +import org.jetbrains.jet.lang.diagnostics.DiagnosticSink; import org.jetbrains.jet.lang.psi.JetFile; import org.jetbrains.jet.plugin.util.ProjectRootsUtil; import org.jetbrains.jet.plugin.caches.resolve.ResolvePackage; @@ -116,7 +116,7 @@ public class KotlinBytecodeToolWindow extends JPanel implements Disposable { Collections.singletonList(jetFile), true, true, GenerationState.GenerateClassFilter.GENERATE_ALL, !enableInline.isSelected(), !enableOptimization.isSelected(), null, null, - DiagnosticHolder.DO_NOTHING, null); + DiagnosticSink.DO_NOTHING, null); KotlinCodegenFacade.compileCorrectFiles(state, CompilationErrorHandler.THROW_EXCEPTION); } catch (ProcessCanceledException e) {