azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR2IR] Remove obsolete TODO

Browse Source 
#KT-62865
This commit is contained in:
Kirill Rakhman
2023-12-15 10:33:22 +01:00
committed by Space Team
parent 0c5a925b6e
commit eb0f4167b3
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/AdapterGenerator.kt
+2 -6
View File
@@ -443,8 +443,7 @@ internal class AdapterGenerator(
argumentConeType: ConeKotlinType, argumentConeType: ConeKotlinType,
samType: ConeKotlinType, samType: ConeKotlinType,
): IrExpression { ): IrExpression {
// The rule for SAM conversions is: // The rule for SAM conversions is: the argument must be a subtype of the required function type.
// the argument must be a non-reflection function type and be a subtype of the required function type.
// We handle intersection types, captured types, etc. by approximating both expected and actual types. // We handle intersection types, captured types, etc. by approximating both expected and actual types.
val approximatedConeKotlinFunctionType = getFunctionTypeForPossibleSamType(samType)?.approximateForIrOrSelf() ?: return argument val approximatedConeKotlinFunctionType = getFunctionTypeForPossibleSamType(samType)?.approximateForIrOrSelf() ?: return argument
@@ -453,10 +452,7 @@ internal class AdapterGenerator(
// tests from FirBlackBoxCodegenTestGenerated relevant to INDY start failing once this line is removed. // tests from FirBlackBoxCodegenTestGenerated relevant to INDY start failing once this line is removed.
val approximateArgumentConeType = argumentConeType.approximateForIrOrSelf() val approximateArgumentConeType = argumentConeType.approximateForIrOrSelf()
if (approximateArgumentConeType.isSubtypeOf(approximatedConeKotlinFunctionType, session) if (approximateArgumentConeType.isSubtypeOf(approximatedConeKotlinFunctionType, session)) {
// TODO uncomment when KT-63510 is fixed, probably fixes KT-62865
// && approximateArgumentConeType.lowerBoundIfFlexible().functionTypeKind(session)?.isReflectType == false
) {
return argument return argument
} }