WhenWithOnlyElse: don't remove when subject variable if needed

#KT-30975 Fixed

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/multiReference.kt

@@ -0,0 +1,14 @@
+fun test() {
+    when (val a = create()) {
+        else -> {
+            use(a, a)
+            foo()
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/multiReference.kt.after

@@ -0,0 +1,11 @@
+fun test() {
+    <caret>val a = create()
+    use(a, a)
+    foo()
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/noReference.kt

@@ -0,0 +1,14 @@
+fun test() {
+    when (val a = create()) {
+        else -> {
+            use("")
+            foo()
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/noReference.kt.after

@@ -0,0 +1,11 @@
+fun test() {
+    <caret>val a = create()
+    use("")
+    foo()
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/noReference2.kt

@@ -0,0 +1,12 @@
+fun test() {
+    when (val a = 42) {
+        else -> {
+            use("")
+            foo()
+        }
+    }<caret>
+}
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/noReference2.kt.after

@@ -0,0 +1,8 @@
+fun test() {
+    <caret>use("")
+    foo()
+}
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/singleReference.kt

@@ -0,0 +1,14 @@
+fun test() {
+    when (val a = create()) {
+        else -> {
+            use(a)
+            foo()
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElse/singleReference.kt.after

@@ -0,0 +1,10 @@
+fun test() {
+    <caret>use(create())
+    foo()
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+fun foo() {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/multiReference.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> {
+            use(a, a)
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/multiReference.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        val a = create()
+        use(a, a)
+    }
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/noReference.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> {
+            use("")
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/noReference.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        val a = create()
+        use("")
+    }
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/noReference2.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = 42) {
+        else -> {
+            use("")
+        }
+    }<caret>
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/noReference2.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        use("")
+    }
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/singleReference.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> {
+            use(a)
+        }
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/blockElseUsedAsExpression/singleReference.kt.after

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        use(create())
+    }
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasAnnotation.kt

@@ -0,0 +1,11 @@
+fun hasAnnotation() {
+    when (@Bar val a = create()) {
+        else -> use(a)
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+annotation class Bar

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasAnnotation.kt.after

@@ -0,0 +1,10 @@
+fun hasAnnotation() {
+    <caret>@Bar val a = create()
+    use(a)
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}
+
+annotation class Bar

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>when (val a = 42) {
+        else -> use(a, a)
+    }
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable.kt.after

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>run {
+        val a = 42
+        use(a, a)
+    }
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable2.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>when (val a = 42) {
+        else -> {
+            use(a, a)
+            use(a, a)
+        }
+    }
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable2.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    <caret>run {
+        val a = 42
+        use(a, a)
+        use(a, a)
+    }
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable3.kt

@@ -0,0 +1,9 @@
+fun test() {
+    <caret>when (val a = 42) {
+        else -> use(a)
+    }
+
+    val a = 33
+}
+
+fun use(i: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable3.kt.after

@@ -0,0 +1,7 @@
+fun test() {
+    <caret>use(42)
+
+    val a = 33
+}
+
+fun use(i: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable4.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>when (val a = 42) {
+        else -> use(a, a)
+    }
+
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/hasSameNameVariable4.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        val a = 42
+        use(a, a)
+    }
+
+    val a = 33
+}
+
+fun use(i: Int, j: Int) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/multiReference.kt

@@ -0,0 +1,9 @@
+fun test() {
+    when (val a = create()) {
+        else -> use(a, a)
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/multiReference.kt.after

@@ -0,0 +1,8 @@
+fun test() {
+    <caret>val a = create()
+    use(a, a)
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/multiReferenceUsedAsExpression.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> use(a, a)
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/multiReferenceUsedAsExpression.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        val a = create()
+        use(a, a)
+    }
+}
+
+fun create(): String = ""
+
+fun use(s: String, t: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReference.kt

@@ -0,0 +1,9 @@
+fun test() {
+    when (val a = create()) {
+        else -> use("")
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReference.kt.after

@@ -0,0 +1,8 @@
+fun test() {
+    <caret>val a = create()
+    use("")
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReference2.kt

@@ -0,0 +1,7 @@
+fun test() {
+    when (val a = 42) {
+        else -> use("")
+    }<caret>
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReference2.kt.after

@@ -0,0 +1,5 @@
+fun test() {
+    <caret>use("")
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReferenceUsedAsExpression.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> use("")
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReferenceUsedAsExpression.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>run {
+        val a = create()
+        use("")
+    }
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReferenceUsedAsExpression2.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = 42) {
+        else -> use("")
+    }<caret>
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/noReferenceUsedAsExpression2.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>use("")
+}
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/singleReference.kt

@@ -0,0 +1,9 @@
+fun test() {
+    when (val a = create()) {
+        else -> use(a)
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/singleReference.kt.after

@@ -0,0 +1,7 @@
+fun test() {
+    <caret>use(create())
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/singleReferenceUsedAsExpression.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+fun test() {
+    val x = when (val a = create()) {
+        else -> use(a)
+    }<caret>
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}

idea/testData/inspectionsLocal/whenWithOnlyElse/subjectVariable/singleElse/singleReferenceUsedAsExpression.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+fun test() {
+    val x = <caret>use(create())
+}
+
+fun create(): String = ""
+
+fun use(s: String) {}