Minor: refactoring ConvertMemberToExtensionIntention

This commit is contained in:
Dmitry Gridin
2019-03-20 22:42:38 +07:00
parent e11072b8c2
commit e8eb9c3d58
@@ -37,14 +37,19 @@ import org.jetbrains.kotlin.idea.intentions.SelfTargetingRangeIntention
import org.jetbrains.kotlin.idea.quickfix.createFromUsage.callableBuilder.getReturnTypeReference import org.jetbrains.kotlin.idea.quickfix.createFromUsage.callableBuilder.getReturnTypeReference
import org.jetbrains.kotlin.idea.refactoring.withExpectedActuals import org.jetbrains.kotlin.idea.refactoring.withExpectedActuals
import org.jetbrains.kotlin.idea.references.KtReference import org.jetbrains.kotlin.idea.references.KtReference
import org.jetbrains.kotlin.idea.util.* import org.jetbrains.kotlin.idea.util.ImportInsertHelper
import org.jetbrains.kotlin.idea.util.actualsForExpected
import org.jetbrains.kotlin.idea.util.application.runWriteAction import org.jetbrains.kotlin.idea.util.application.runWriteAction
import org.jetbrains.kotlin.idea.util.isExpectDeclaration
import org.jetbrains.kotlin.idea.util.liftToExpected
import org.jetbrains.kotlin.lexer.KtTokens import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.* import org.jetbrains.kotlin.psi.psiUtil.*
import org.jetbrains.kotlin.utils.addIfNotNull import org.jetbrains.kotlin.utils.addIfNotNull
class ConvertMemberToExtensionIntention : SelfTargetingRangeIntention<KtCallableDeclaration>(KtCallableDeclaration::class.java, "Convert member to extension"), LowPriorityAction { class ConvertMemberToExtensionIntention :
SelfTargetingRangeIntention<KtCallableDeclaration>(KtCallableDeclaration::class.java, "Convert member to extension"),
LowPriorityAction {
private fun isApplicable(element: KtCallableDeclaration): Boolean { private fun isApplicable(element: KtCallableDeclaration): Boolean {
val classBody = element.parent as? KtClassBody ?: return false val classBody = element.parent as? KtClassBody ?: return false
if (classBody.parent !is KtClass) return false if (classBody.parent !is KtClass) return false
@@ -93,8 +98,7 @@ class ConvertMemberToExtensionIntention : SelfTargetingRangeIntention<KtCallable
bodyToSelect.siblings(forward = true, withItself = false).lastOrNull() bodyToSelect.siblings(forward = true, withItself = false).lastOrNull()
val endOffset = lastSibling?.endOffset ?: range.endOffset val endOffset = lastSibling?.endOffset ?: range.endOffset
selectionModel.setSelection(range.startOffset, endOffset) selectionModel.setSelection(range.startOffset, endOffset)
} } else {
else {
moveCaret(extension.textOffset, ScrollType.CENTER) moveCaret(extension.textOffset, ScrollType.CENTER)
} }
} }
@@ -142,8 +146,7 @@ class ConvertMemberToExtensionIntention : SelfTargetingRangeIntention<KtCallable
if (typeParameterList != null) { if (typeParameterList != null) {
if (extension.typeParameterList != null) { if (extension.typeParameterList != null) {
extension.typeParameterList!!.replace(typeParameterList) extension.typeParameterList!!.replace(typeParameterList)
} } else {
else {
extension.addBefore(typeParameterList, extension.receiverTypeReference) extension.addBefore(typeParameterList, extension.receiverTypeReference)
extension.addBefore(psiFactory.createWhiteSpace(), extension.receiverTypeReference) extension.addBefore(psiFactory.createWhiteSpace(), extension.receiverTypeReference)
} }
@@ -196,8 +199,7 @@ class ConvertMemberToExtensionIntention : SelfTargetingRangeIntention<KtCallable
getter = extension.addAfter(templateGetter, extension.typeReference) as KtPropertyAccessor getter = extension.addAfter(templateGetter, extension.typeReference) as KtPropertyAccessor
extension.addBefore(psiFactory.createNewLine(), getter) extension.addBefore(psiFactory.createNewLine(), getter)
selectBody(getter) selectBody(getter)
} } else if (!getter.hasBody()) {
else if (!getter.hasBody()) {
getter = getter.replace(templateGetter) as KtPropertyAccessor getter = getter.replace(templateGetter) as KtPropertyAccessor
selectBody(getter) selectBody(getter)
} }
@@ -208,8 +210,7 @@ class ConvertMemberToExtensionIntention : SelfTargetingRangeIntention<KtCallable
setter = extension.addAfter(templateSetter, getter) as KtPropertyAccessor setter = extension.addAfter(templateSetter, getter) as KtPropertyAccessor
extension.addBefore(psiFactory.createNewLine(), setter) extension.addBefore(psiFactory.createNewLine(), setter)
selectBody(setter) selectBody(setter)
} } else if (!setter.hasBody()) {
else if (!setter.hasBody()) {
setter = setter.replace(templateSetter) as KtPropertyAccessor setter = setter.replace(templateSetter) as KtPropertyAccessor
selectBody(setter) selectBody(setter)
} }