From e8b0ce00e1c68614d57bddaaadcc25252b3d734a Mon Sep 17 00:00:00 2001 From: Dmitriy Novozhilov Date: Wed, 26 Feb 2020 10:47:59 +0300 Subject: [PATCH] [FIR] Remove useless `file` argument from `FirCallResolver` --- .../resolve/src/org/jetbrains/kotlin/fir/FirCallResolver.kt | 4 ++-- .../body/resolve/FirExpressionsResolveTransformer.kt | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/FirCallResolver.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/FirCallResolver.kt index f7e894d4e12..025de4f0ff4 100644 --- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/FirCallResolver.kt +++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/FirCallResolver.kt @@ -66,7 +66,7 @@ class FirCallResolver( inferenceComponents.session.callConflictResolverFactory .create(TypeSpecificityComparator.NONE, inferenceComponents) - fun resolveCallAndSelectCandidate(functionCall: FirFunctionCall, file: FirFile): FirFunctionCall { + fun resolveCallAndSelectCandidate(functionCall: FirFunctionCall): FirFunctionCall { qualifiedResolver.reset() @Suppress("NAME_SHADOWING") var functionCall = functionCall.transformExplicitReceiver(transformer, ResolutionMode.ContextIndependent) @@ -150,7 +150,7 @@ class FirCallResolver( return ResolutionResult(info, result.currentApplicability, reducedCandidates) } - fun resolveVariableAccessAndSelectCandidate(qualifiedAccess: T, file: FirFile): FirStatement { + fun resolveVariableAccessAndSelectCandidate(qualifiedAccess: T): FirStatement { val callee = qualifiedAccess.calleeReference as? FirSimpleNamedReference ?: return qualifiedAccess qualifiedResolver.initProcessingQualifiedAccess(qualifiedAccess, callee) diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirExpressionsResolveTransformer.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirExpressionsResolveTransformer.kt index 0476bb2ba15..e66edc305c7 100644 --- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirExpressionsResolveTransformer.kt +++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/transformers/body/resolve/FirExpressionsResolveTransformer.kt @@ -128,7 +128,7 @@ class FirExpressionsResolveTransformer(transformer: FirBodyResolveTransformer) : qualifiedAccessExpression } else -> { - val transformedCallee = callResolver.resolveVariableAccessAndSelectCandidate(qualifiedAccessExpression, file) + val transformedCallee = callResolver.resolveVariableAccessAndSelectCandidate(qualifiedAccessExpression) // NB: here we can get raw expression because of dropped qualifiers (see transform callee), // so candidate existence must be checked before calling completion if (transformedCallee is FirQualifiedAccessExpression && transformedCallee.candidate() != null) { @@ -158,7 +158,7 @@ class FirExpressionsResolveTransformer(transformer: FirBodyResolveTransformer) : val completeInference = try { val initialExplicitReceiver = functionCall.explicitReceiver - val resultExpression = callResolver.resolveCallAndSelectCandidate(functionCall, file) + val resultExpression = callResolver.resolveCallAndSelectCandidate(functionCall) val resultExplicitReceiver = resultExpression.explicitReceiver if (initialExplicitReceiver !== resultExplicitReceiver && resultExplicitReceiver is FirQualifiedAccess) { // name.invoke() case @@ -400,7 +400,7 @@ class FirExpressionsResolveTransformer(transformer: FirBodyResolveTransformer) : ): CompositeTransformResult { // val resolvedAssignment = transformCallee(variableAssignment) variableAssignment.annotations.forEach { it.accept(this, data) } - val resolvedAssignment = callResolver.resolveVariableAccessAndSelectCandidate(variableAssignment, file) + val resolvedAssignment = callResolver.resolveVariableAccessAndSelectCandidate(variableAssignment) val result = if (resolvedAssignment is FirVariableAssignment) { val completeAssignment = callCompleter.completeCall(resolvedAssignment, noExpectedType) // TODO: check val expectedType = components.typeFromCallee(completeAssignment)