From e87f7c5cb4a165078375e4c21137809c97f82fbd Mon Sep 17 00:00:00 2001
From: Dmitriy Novozhilov <dmitriy.novozhilov@jetbrains.com>
Date: Tue, 21 Sep 2021 12:48:34 +0300
Subject: [PATCH] [FIR] Update dummy checker in allopen plugin

---
 .../kotlin/fir/plugin/checkers/AllOpenErrors.kt    | 14 ++++++++++++++
 .../kotlin/fir/plugin/checkers/DummyNameChecker.kt |  5 +++--
 .../testData/checkers/simple.kt                    | 10 +++++-----
 3 files changed, 22 insertions(+), 7 deletions(-)
 create mode 100644 plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/AllOpenErrors.kt

diff --git a/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/AllOpenErrors.kt b/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/AllOpenErrors.kt
new file mode 100644
index 00000000000..099c3bd8825
--- /dev/null
+++ b/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/AllOpenErrors.kt
@@ -0,0 +1,14 @@
+/*
+ * Copyright 2010-2021 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.fir.plugin.checkers
+
+import com.intellij.psi.PsiElement
+import org.jetbrains.kotlin.fir.analysis.diagnostics.SourceElementPositioningStrategies
+import org.jetbrains.kotlin.fir.analysis.diagnostics.warning1
+
+object AllOpenErrors {
+    val FUNCTION_WITH_DUMMY_NAME by warning1<PsiElement, String>(SourceElementPositioningStrategies.DECLARATION_NAME)
+}
diff --git a/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/DummyNameChecker.kt b/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/DummyNameChecker.kt
index d14bcc3a136..ce0e85c849c 100644
--- a/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/DummyNameChecker.kt
+++ b/plugins/fir/fir-plugin-prototype/src/org/jetbrains/kotlin/fir/plugin/checkers/DummyNameChecker.kt
@@ -14,8 +14,9 @@ import org.jetbrains.kotlin.fir.declarations.FirSimpleFunction
 
 object DummyNameChecker : FirSimpleFunctionChecker() {
     override fun check(declaration: FirSimpleFunction, context: CheckerContext, reporter: DiagnosticReporter) {
-        if (declaration.name.asString() == "dummy") {
-            reporter.reportOn(declaration.source, FirErrors.SYNTAX, context)
+        val name = declaration.name.asString()
+        if (name == "dummy") {
+            reporter.reportOn(declaration.source, AllOpenErrors.FUNCTION_WITH_DUMMY_NAME, name, context)
         }
     }
 }
diff --git a/plugins/fir/fir-plugin-prototype/testData/checkers/simple.kt b/plugins/fir/fir-plugin-prototype/testData/checkers/simple.kt
index 4e874e967a7..599a28693ca 100644
--- a/plugins/fir/fir-plugin-prototype/testData/checkers/simple.kt
+++ b/plugins/fir/fir-plugin-prototype/testData/checkers/simple.kt
@@ -1,13 +1,13 @@
-<!SYNTAX_ERROR!>fun dummy(x: Int) {
+fun <!FUNCTION_WITH_DUMMY_NAME!>dummy<!>(x: Int) {
 
-}<!>
+}
 
 class A {
-    <!SYNTAX_ERROR!>fun dummy() {
+    fun <!FUNCTION_WITH_DUMMY_NAME!>dummy<!>() {
 
-    }<!>
+    }
 }
 
 class B {
     val dummy: Int = 1
-}
\ No newline at end of file
+}