azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR: don't emit SENSELESS_NULL_IN_WHEN when value is always null

Browse Source 
This case (value is always null) contradicts the error message which says
"Expression under 'when' is never equal to null".
This commit is contained in:
pyos
2022-11-08 14:26:49 +01:00
committed by teamcity
parent fbb54f0300
commit e7b4927b6c
5 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/tests-spec/testData/diagnostics/notLinked/dfa/pos/37.fir.kt
Vendored
+1 -1
View File
@@ -199,7 +199,7 @@ fun case_17(x: Boolean?, y: Boolean?) {
else -> if (true) if (true) if (true) if (true) if (true) x!! else x!! else x!! else x!! else x!! else x!!
}
<!SENSELESS_COMPARISON!>false<!> -> x!!
<!SENSELESS_NULL_IN_WHEN!>null<!> -> if (true) if (true) if (true) if (true) if (true) x!! else x!! else x!! else x!! else x!! else x!!
<!SENSELESS_COMPARISON!>null<!> -> if (true) if (true) if (true) if (true) if (true) x!! else x!! else x!! else x!! else x!! else x!!
} else x!! else x!! else x!! else x!! else x!!
}
break@loop
compiler/tests-spec/testData/diagnostics/notLinked/dfa/pos/62.fir.kt
Vendored
+4 -4
View File
@@ -154,7 +154,7 @@ fun case_10(x: Any): String {
fun case_11(x: Any?): String? {
if (x is Nothing?) {
return when(x) {
<!SENSELESS_NULL_IN_WHEN!>null<!> -> null
<!SENSELESS_COMPARISON!>null<!> -> null
}
}
return ""
@@ -168,7 +168,7 @@ fun case_11(x: Any?): String? {
fun case_12(x: Any?): String? {
if (x == null) {
return when(x) {
<!SENSELESS_NULL_IN_WHEN!>null<!> -> null
<!SENSELESS_COMPARISON!>null<!> -> null
}
}
return ""
@@ -182,7 +182,7 @@ fun case_12(x: Any?): String? {
fun case_13(x: Any?): String? {
if (x === null) {
return when(x) {
<!SENSELESS_NULL_IN_WHEN!>null<!> -> null
<!SENSELESS_COMPARISON!>null<!> -> null
}
}
return ""
@@ -196,7 +196,7 @@ fun case_13(x: Any?): String? {
fun case_14(x: Any?): String? {
x as Nothing?
return when(x) {
<!SENSELESS_NULL_IN_WHEN!>null<!> -> null
<!SENSELESS_COMPARISON!>null<!> -> null
}
}