[AA] getExpectForActual analysis-api now returns compatible or weakly incompatible

^KTIJ-27522 Fixed

It's the only reasonable behavior for this API in it's current shape
(when it returns a list of declarations)

It's a common mistake to take only Compatible from
expectActualMatchingMap. The problem will be gone after I fix KT-62590

Motivation to fix this bug, is because it will be easier for me to split
expect-actual matcher-checker-monster thing KT-62590

Review: https://jetbrains.team/p/kt/reviews/12750/timeline

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirMultiplatformInfoProvider.kt

@@ -14,7 +14,7 @@ import org.jetbrains.kotlin.fir.declarations.expectForActual
 import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol
 import org.jetbrains.kotlin.fir.symbols.impl.FirClassSymbol
 import org.jetbrains.kotlin.fir.symbols.impl.FirTypeAliasSymbol
-import org.jetbrains.kotlin.resolve.multiplatform.ExpectActualCompatibility
+import org.jetbrains.kotlin.resolve.multiplatform.isCompatibleOrWeaklyIncompatible
 
 internal class KtFirMultiplatformInfoProvider(
     override val analysisSession: KtFirAnalysisSession,
@@ -31,7 +31,10 @@ internal class KtFirMultiplatformInfoProvider(
         }
         if (status?.isActual != true) return emptyList()
 
-        val expectsForActual = firSymbol.expectForActual?.get(ExpectActualCompatibility.Compatible) ?: return emptyList()
-        return expectsForActual.map { analysisSession.firSymbolBuilder.buildSymbol(it) as KtDeclarationSymbol }
+        return firSymbol.expectForActual.orEmpty().asSequence()
+            .filter { it.key.isCompatibleOrWeaklyIncompatible }
+            .flatMap { it.value }
+            .map { analysisSession.firSymbolBuilder.buildSymbol(it) as KtDeclarationSymbol }
+            .toList()
     }
-}
+}

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/components/multiplatformInfoProvider/FirIdeDependentAnalysisSourceModuleExpectForActualTestGenerated.java

@@ -52,6 +52,12 @@ public class FirIdeDependentAnalysisSourceModuleExpectForActualTestGenerated ext
         KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/multiplatformInfoProvider/expectForActual"), Pattern.compile("^(.+)\\.kt$"), null, true);
     }
 
+    @Test
+    @TestMetadata("matchingButIncompatibleExpect.kt")
+    public void testMatchingButIncompatibleExpect() throws Exception {
+        runTest("analysis/analysis-api/testData/components/multiplatformInfoProvider/expectForActual/matchingButIncompatibleExpect.kt");
+    }
+
     @Test
     @TestMetadata("multipleExpects.kt")
     public void testMultipleExpects() throws Exception {

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/components/multiplatformInfoProvider/FirIdeNormalAnalysisSourceModuleExpectForActualTestGenerated.java

@@ -52,6 +52,12 @@ public class FirIdeNormalAnalysisSourceModuleExpectForActualTestGenerated extend
         KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/multiplatformInfoProvider/expectForActual"), Pattern.compile("^(.+)\\.kt$"), null, true);
     }
 
+    @Test
+    @TestMetadata("matchingButIncompatibleExpect.kt")
+    public void testMatchingButIncompatibleExpect() throws Exception {
+        runTest("analysis/analysis-api/testData/components/multiplatformInfoProvider/expectForActual/matchingButIncompatibleExpect.kt");
+    }
+
     @Test
     @TestMetadata("multipleExpects.kt")
     public void testMultipleExpects() throws Exception {