azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR checker: differentiate UNSAFE_CALL from INAPPLICABLE_CANDIDATE

Browse Source 
To do so, inside the root cause of inapplicable candidate errors,
we will record expected/actual type of receiver, if any.
That will help identifying inapplicable calls on nullable receiver.
This commit is contained in:
Jinseong Jeon
2021-01-26 16:03:27 -08:00
committed by Mikhail Glukhikh
parent 4b823eca21
commit e72ddbcbfe
275 changed files with 1426 additions and 1388 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/smartCasts/complexConditionsWithExcl.fir.kt
Vendored
+10 -10
View File
@@ -1,26 +1,26 @@
fun foo(x: String?, y: String?, z: String?) {
if ((x!!.hashCode() == 0 || y!!.hashCode() == 1) && z!!.hashCode() == 2) {
x.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
// condition is true => z!! after and is called
z.length
}
else {
x.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
z.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
z.<!UNSAFE_CALL!>length<!>
}
// First element is always analyzed
x.length
var xx = y ?: z
if ((xx!!.hashCode() == 0 && y!!.hashCode() == 1) || z!!.hashCode() == 2) {
xx.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
z.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
z.<!UNSAFE_CALL!>length<!>
}
else {
xx.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
// condition is false => z!! after or is called
z.length
}
@@ -35,16 +35,16 @@ fun foo(x: String?, y: String?, z: String?) {
}
else {
xx.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
z.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
z.<!UNSAFE_CALL!>length<!>
}
// First element is always analyzed
x.length
xx = y ?: z
if (xx!!.hashCode() == 0 || y!!.hashCode() == 1 || z!!.hashCode() == 2) {
xx.length
y.<!INAPPLICABLE_CANDIDATE!>length<!>
z.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!UNSAFE_CALL!>length<!>
z.<!UNSAFE_CALL!>length<!>
}
else {
// all three are called