FIR checker: differentiate UNSAFE_CALL from INAPPLICABLE_CANDIDATE

To do so, inside the root cause of inapplicable candidate errors,
we will record expected/actual type of receiver, if any.
That will help identifying inapplicable calls on nullable receiver.
This commit is contained in:
Jinseong Jeon
2021-01-26 16:03:27 -08:00
committed by Mikhail Glukhikh
parent 4b823eca21
commit e72ddbcbfe
275 changed files with 1426 additions and 1388 deletions
@@ -6,30 +6,30 @@ fun foo(x : String?, y : String?) {
y.length
}
else {
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
if (y != null || x == y) {
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
else {
// y == null but x != y
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
if (y == null && x != y) {
// y == null but x != y
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
else {
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
if (y == null || x != y) {
x.<!INAPPLICABLE_CANDIDATE!>length<!>
y.<!INAPPLICABLE_CANDIDATE!>length<!>
x.<!UNSAFE_CALL!>length<!>
y.<!UNSAFE_CALL!>length<!>
}
else {
// Both not null