IR: fix SAM conversion for types with contravariant intersection argument type

In the added test, the problem was that the SAM type as computed by
`SamTypeFactory.createByValueParameter` was `Consumer<{BaseClass &
BaseInterface}>`, which was latter approximated in psi2ir during the
KotlinType->IrType conversion to `Consumer<out Any?>` (here:
https://github.com/JetBrains/kotlin/blob/3034d9d791cf1f9033104e12448e0d262d3bc3ce/compiler/ir/ir.psi2ir/src/org/jetbrains/kotlin/psi2ir/generators/ArgumentsGenerationUtils.kt#L606),
because intersection type argument is approximated to `out Any?`.

To avoid this, replace intersection type in immediate arguments of a SAM
type with the common supertype of its components at the same place where
we're getting rid of projections.

 #KT-45945 Fixed
This commit is contained in:
Alexander Udalov
2021-04-09 15:26:47 +02:00
parent ac0af39660
commit e6c089ef40
16 changed files with 450 additions and 7 deletions
@@ -9,6 +9,8 @@ import org.jetbrains.kotlin.builtins.KotlinBuiltIns
import org.jetbrains.kotlin.descriptors.ClassDescriptor
import org.jetbrains.kotlin.descriptors.SimpleFunctionDescriptor
import org.jetbrains.kotlin.descriptors.ValueParameterDescriptor
import org.jetbrains.kotlin.resolve.calls.NewCommonSuperTypeCalculator
import org.jetbrains.kotlin.resolve.calls.commonSuperType
import org.jetbrains.kotlin.resolve.sam.getAbstractMembers
import org.jetbrains.kotlin.types.*
import org.jetbrains.kotlin.types.typeUtil.replaceArgumentsWithNothing
@@ -80,11 +82,19 @@ open class SamTypeFactory {
}
private fun KotlinType.removeExternalProjections(): KotlinType {
val newArguments = arguments.map { TypeProjectionImpl(Variance.INVARIANT, it.type) }
val newArguments = arguments.map {
val type = it.type
TypeProjectionImpl(
Variance.INVARIANT,
if (type.constructor is IntersectionTypeConstructor)
NewCommonSuperTypeCalculator.commonSuperType(type.constructor.supertypes.map(KotlinType::unwrap))
else type
)
}
return replace(newArguments)
}
companion object {
val INSTANCE = SamTypeFactory()
}
}
}
@@ -87,11 +87,6 @@ fun CallableMemberDescriptor.createTypeParameterWithNewName(
return newDescriptor
}
fun KotlinType.removeExternalProjections(): KotlinType {
val newArguments = arguments.map { TypeProjectionImpl(Variance.INVARIANT, it.type) }
return replace(newArguments)
}
fun isInlineClassConstructorAccessor(descriptor: FunctionDescriptor): Boolean =
descriptor is AccessorForConstructorDescriptor &&
descriptor.calleeDescriptor.constructedClass.isInlineClass()
@@ -15446,6 +15446,24 @@ public class FirBlackBoxCodegenTestGenerated extends AbstractFirBlackBoxCodegenT
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
@@ -37754,6 +37772,24 @@ public class FirBlackBoxCodegenTestGenerated extends AbstractFirBlackBoxCodegenT
runTest("compiler/testData/codegen/box/sam/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("differentFqNames.kt")
public void testDifferentFqNames() throws Exception {
@@ -0,0 +1,38 @@
// IGNORE_BACKEND: WASM
// WASM_MUTE_REASON: SAM_CONVERSIONS
// CHECK_BYTECODE_TEXT
// 0 java/lang/invoke/LambdaMetafactory
abstract class BaseClass
interface BaseInterface
class ConcreteType : BaseClass(), BaseInterface
class ConcreteType2 : BaseClass(), BaseInterface
fun box(): String {
example(0)
return "OK"
}
fun example(input: Int) {
val instance = when (input) {
0 -> GenericHolder<ConcreteType>()
else -> GenericHolder<ConcreteType2>()
}
instance.doOnSuccess {}
instance.doOnSuccess(::functionReference)
}
fun functionReference(x: Any) {}
class GenericHolder<T> {
fun doOnSuccess(onSuccess: Consumer<in T>) {
onSuccess.accept(object : BaseClass() {} as T)
}
}
fun interface Consumer<T> {
fun accept(t: T)
}
@@ -0,0 +1,42 @@
// IGNORE_BACKEND: WASM
// WASM_MUTE_REASON: SAM_CONVERSIONS
// CHECK_BYTECODE_TEXT
// 0 java/lang/invoke/LambdaMetafactory
interface Top
interface Common : Top
abstract class BaseClass : Common
interface BaseInterface : Common
class ConcreteType : BaseClass(), BaseInterface
class ConcreteType2 : BaseClass(), BaseInterface
fun box(): String {
example(0)
return "OK"
}
fun example(input: Int) {
val instance = when (input) {
0 -> GenericHolder<ConcreteType>()
else -> GenericHolder<ConcreteType2>()
}
instance.doOnSuccess {}
instance.doOnSuccess(::functionReference)
}
fun functionReference(x: Any) {}
class GenericHolder<T : Top> {
fun doOnSuccess(onSuccess: Consumer<in T>) {
onSuccess.accept(object : BaseClass() {} as T)
}
}
fun interface Consumer<T : Top> {
fun accept(t: T)
}
@@ -0,0 +1,34 @@
// IGNORE_BACKEND: WASM
// WASM_MUTE_REASON: SAM_CONVERSIONS
// CHECK_BYTECODE_TEXT
// 0 java/lang/invoke/LambdaMetafactory
interface Top
interface Unrelated
interface A : Top, Unrelated
interface B : Top, Unrelated
fun box(): String {
val g = when ("".length) {
0 -> G<A>()
else -> G<B>()
}
g.check {}
g.check(::functionReference)
return "OK"
}
fun functionReference(x: Any) {}
class G<T : Top> {
fun check(x: IFoo<in T>) {
x.accept(object : A {} as T)
}
}
fun interface IFoo<T : Top> {
fun accept(t: T)
}
@@ -0,0 +1,42 @@
// TARGET_BACKEND: JVM
// CHECK_BYTECODE_TEXT
// JVM_IR_TEMPLATES
// 2 java/lang/invoke/LambdaMetafactory
// FILE: test.kt
abstract class BaseClass
interface BaseInterface
class ConcreteType : BaseClass(), BaseInterface
class ConcreteType2 : BaseClass(), BaseInterface
fun box(): String {
example(0)
return "OK"
}
fun example(input: Int) {
val instance = when (input) {
0 -> GenericHolder<ConcreteType>()
else -> GenericHolder<ConcreteType2>()
}
instance.doOnSuccess {}
instance.doOnSuccess(::functionReference)
}
fun functionReference(x: Any) {}
class GenericHolder<T> {
fun doOnSuccess(onSuccess: Consumer<in T>) {
onSuccess.accept(object : BaseClass() {} as T)
}
}
// FILE: Consumer.java
public interface Consumer<T> {
void accept(T t);
}
@@ -0,0 +1,46 @@
// TARGET_BACKEND: JVM
// CHECK_BYTECODE_TEXT
// JVM_IR_TEMPLATES
// 2 java/lang/invoke/LambdaMetafactory
// FILE: test.kt
interface Top
interface Common : Top
abstract class BaseClass : Common
interface BaseInterface : Common
class ConcreteType : BaseClass(), BaseInterface
class ConcreteType2 : BaseClass(), BaseInterface
fun box(): String {
example(0)
return "OK"
}
fun example(input: Int) {
val instance = when (input) {
0 -> GenericHolder<ConcreteType>()
else -> GenericHolder<ConcreteType2>()
}
instance.doOnSuccess {}
instance.doOnSuccess(::functionReference)
}
fun functionReference(x: Any) {}
class GenericHolder<T : Top> {
fun doOnSuccess(onSuccess: Consumer<in T>) {
onSuccess.accept(object : BaseClass() {} as T)
}
}
// FILE: Consumer.java
public interface Consumer<T extends Top> {
void accept(T t);
}
@@ -0,0 +1,38 @@
// TARGET_BACKEND: JVM
// CHECK_BYTECODE_TEXT
// JVM_IR_TEMPLATES
// 2 java/lang/invoke/LambdaMetafactory
// FILE: test.kt
interface Top
interface Unrelated
interface A : Top, Unrelated
interface B : Top, Unrelated
fun box(): String {
val g = when ("".length) {
0 -> G<A>()
else -> G<B>()
}
g.check {}
g.check(::functionReference)
return "OK"
}
fun functionReference(x: Any) {}
class G<T : Top> {
fun check(x: IFoo<in T>) {
x.accept(object : A {} as T)
}
}
// FILE: IFoo.java
public interface IFoo<T extends Top> {
void accept(T t);
}
@@ -15422,6 +15422,24 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
@@ -37730,6 +37748,24 @@ public class BlackBoxCodegenTestGenerated extends AbstractBlackBoxCodegenTest {
runTest("compiler/testData/codegen/box/sam/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("differentFqNames.kt")
public void testDifferentFqNames() throws Exception {
@@ -15446,6 +15446,24 @@ public class IrBlackBoxCodegenTestGenerated extends AbstractIrBlackBoxCodegenTes
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
@@ -37754,6 +37772,24 @@ public class IrBlackBoxCodegenTestGenerated extends AbstractIrBlackBoxCodegenTes
runTest("compiler/testData/codegen/box/sam/castFromAny.kt");
}
@Test
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionType.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@Test
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@Test
@TestMetadata("differentFqNames.kt")
public void testDifferentFqNames() throws Exception {
@@ -12721,6 +12721,21 @@ public class LightAnalysisModeTestGenerated extends AbstractLightAnalysisModeTes
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/funConversionInVararg.kt");
@@ -30107,6 +30122,21 @@ public class LightAnalysisModeTestGenerated extends AbstractLightAnalysisModeTes
runTest("compiler/testData/codegen/box/sam/castFromAny.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/sam/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("differentFqNames.kt")
public void testDifferentFqNames() throws Exception {
runTest("compiler/testData/codegen/box/sam/differentFqNames.kt");
@@ -11225,6 +11225,21 @@ public class IrJsCodegenBoxES6TestGenerated extends AbstractIrJsCodegenBoxES6Tes
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/funConversionInVararg.kt");
@@ -10646,6 +10646,21 @@ public class IrJsCodegenBoxTestGenerated extends AbstractIrJsCodegenBoxTest {
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/funConversionInVararg.kt");
@@ -10646,6 +10646,21 @@ public class JsCodegenBoxTestGenerated extends AbstractJsCodegenBoxTest {
runTest("compiler/testData/codegen/box/funInterface/castFromAny.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("funConversionInVararg.kt")
public void testFunConversionInVararg() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/funConversionInVararg.kt");
@@ -5371,6 +5371,21 @@ public class IrCodegenBoxWasmTestGenerated extends AbstractIrCodegenBoxWasmTest
runTest("compiler/testData/codegen/box/funInterface/basicFunInterface.kt");
}
@TestMetadata("contravariantIntersectionType.kt")
public void testContravariantIntersectionType() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionType.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype.kt");
}
@TestMetadata("contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt")
public void testContravariantIntersectionTypeWithNonTrivialCommonSupertype2() throws Exception {
runTest("compiler/testData/codegen/box/funInterface/contravariantIntersectionTypeWithNonTrivialCommonSupertype2.kt");
}
@TestMetadata("compiler/testData/codegen/box/funInterface/equality")
@TestDataPath("$PROJECT_ROOT")
@RunWith(JUnit3RunnerWithInners.class)