From e6885323daee567ad4ce6771556d2483cb324f84 Mon Sep 17 00:00:00 2001 From: Dmitry Savvinov Date: Mon, 2 Mar 2020 16:25:31 +0300 Subject: [PATCH] Accept incorrect behaviour for run-config tests for AS Short description. It's a corner-case with old MPP plugins and AS, so we don't care too much that it works incorrectly, but we'd like to avoid muting it in order to keep track of this "known issue" Long description. In IDEA, KotlinJvmTestMethodGradleConfigurationProducer successfully returns run configuration; in AS, it fails to do so. This is becasuse it doesn't override 'forceGradleRunner', which means that in 'setupConfigurationFromContext' we'll delegate to super-call, which will pull 'GradleProjectSettings.getTestRunner()'. In IDEA, it will return GRADLE, but in AS it will return PLATFORM, because AS uses special instance of GradleProjectSettings which forces runner to PLATFORM. Note that KotlinMultiplatformJvmTestMethodGradleConfigurationProducer does override 'forceGradleRunner' to true, that's why other tests work successfully. However, this test uses old 1.2.X-MPP plugins, therefore all new KotlinMultiplatform*ConfigurationProducers won't work here.\ --- .../src/test/kotlin/MyKotlinTest.kt.as35 | 7 +++++++ .../src/test/kotlin/MyKotlinTest.kt.as36 | 7 +++++++ .../src/test/kotlin/MyKotlinTest.kt.as40 | 7 +++++++ .../src/test/kotlin/MyKotlinTest.kt.as35 | 11 +++++++++++ .../src/test/kotlin/MyKotlinTest.kt.as36 | 11 +++++++++++ .../src/test/kotlin/MyKotlinTest.kt.as40 | 11 +++++++++++ 6 files changed, 54 insertions(+) create mode 100755 idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as35 create mode 100755 idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as36 create mode 100755 idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as40 create mode 100755 idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as35 create mode 100755 idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as36 create mode 100755 idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as40 diff --git a/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as35 b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as35 new file mode 100755 index 00000000000..916ff6fe794 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as35 @@ -0,0 +1,7 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } +} \ No newline at end of file diff --git a/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as36 b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as36 new file mode 100755 index 00000000000..916ff6fe794 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as36 @@ -0,0 +1,7 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } +} \ No newline at end of file diff --git a/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as40 b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as40 new file mode 100755 index 00000000000..916ff6fe794 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/kotlinJUnitSettings/src/test/kotlin/MyKotlinTest.kt.as40 @@ -0,0 +1,7 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } +} \ No newline at end of file diff --git a/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as35 b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as35 new file mode 100755 index 00000000000..e5ec5c75062 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as35 @@ -0,0 +1,11 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } + + @Test + fun testB() { + } +} \ No newline at end of file diff --git a/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as36 b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as36 new file mode 100755 index 00000000000..e5ec5c75062 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as36 @@ -0,0 +1,11 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } + + @Test + fun testB() { + } +} \ No newline at end of file diff --git a/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as40 b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as40 new file mode 100755 index 00000000000..e5ec5c75062 --- /dev/null +++ b/idea/testData/gradle/testRunConfigurations/preferredConfigurations/src/test/kotlin/MyKotlinTest.kt.as40 @@ -0,0 +1,11 @@ +import org.junit.Test + +class MyKotlinTest { + @Test + fun testA() { + } + + @Test + fun testB() { + } +} \ No newline at end of file