[FIR] Cleanup: drop AMBIGUOUS_ACTUALS diagnostic from the frontend

Motivation: AMBIGUOUS_ACTUALS can't be reported on frontend (because it
requires expect to actual mapping, but the mapping is only available on
backend)

In scope of KT-59938
Review: https://jetbrains.team/p/kt/reviews/13760
This commit is contained in:
Nikita Bobko
2023-12-05 16:12:34 +01:00
committed by Space Team
parent f1ce57f08f
commit e6860054ea
7 changed files with 0 additions and 32 deletions
@@ -3779,16 +3779,6 @@ internal val KT_DIAGNOSTIC_CONVERTER = KtDiagnosticConverterBuilder.buildConvert
token,
)
}
add(FirErrors.AMBIGUOUS_ACTUALS) { firDiagnostic ->
AmbiguousActualsImpl(
firSymbolBuilder.buildSymbol(firDiagnostic.a),
firDiagnostic.b.map { firBasedSymbol ->
firSymbolBuilder.buildSymbol(firBasedSymbol)
},
firDiagnostic as KtPsiDiagnostic,
token,
)
}
add(FirErrors.AMBIGUOUS_EXPECTS) { firDiagnostic ->
AmbiguousExpectsImpl(
firSymbolBuilder.buildSymbol(firDiagnostic.a),
@@ -2642,12 +2642,6 @@ sealed interface KtFirDiagnostic<PSI : PsiElement> : KtDiagnosticWithPsi<PSI> {
val compatibility: Map<ExpectActualCompatibility<FirBasedSymbol<*>>, List<KtSymbol>>
}
interface AmbiguousActuals : KtFirDiagnostic<KtNamedDeclaration> {
override val diagnosticClass get() = AmbiguousActuals::class
val declaration: KtSymbol
val candidates: List<KtSymbol>
}
interface AmbiguousExpects : KtFirDiagnostic<KtNamedDeclaration> {
override val diagnosticClass get() = AmbiguousExpects::class
val declaration: KtSymbol
@@ -3183,13 +3183,6 @@ internal class ActualWithoutExpectImpl(
token: KtLifetimeToken,
) : KtAbstractFirDiagnostic<KtNamedDeclaration>(firDiagnostic, token), KtFirDiagnostic.ActualWithoutExpect
internal class AmbiguousActualsImpl(
override val declaration: KtSymbol,
override val candidates: List<KtSymbol>,
firDiagnostic: KtPsiDiagnostic,
token: KtLifetimeToken,
) : KtAbstractFirDiagnostic<KtNamedDeclaration>(firDiagnostic, token), KtFirDiagnostic.AmbiguousActuals
internal class AmbiguousExpectsImpl(
override val declaration: KtSymbol,
override val modules: List<FirModuleData>,