From e65112fcabcda8a5d0f145f88e3497c47af19fa8 Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Tue, 10 Oct 2017 12:12:03 +0300 Subject: [PATCH] Disable "Replace camel-case name with spaces" intention for JS / common So #KT-18773 Fixed --- .../ConvertCamelCaseTestFunctionToSpacedIntention.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertCamelCaseTestFunctionToSpacedIntention.kt b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertCamelCaseTestFunctionToSpacedIntention.kt index 5b4ac9d28cf..9b75f0c355a 100644 --- a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertCamelCaseTestFunctionToSpacedIntention.kt +++ b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertCamelCaseTestFunctionToSpacedIntention.kt @@ -29,8 +29,11 @@ import com.intellij.psi.PsiDocumentManager import com.intellij.refactoring.rename.RenameProcessor import org.jetbrains.kotlin.asJava.toLightMethods import org.jetbrains.kotlin.idea.core.quoteIfNeeded +import org.jetbrains.kotlin.idea.project.platform import org.jetbrains.kotlin.idea.util.application.runWriteAction +import org.jetbrains.kotlin.js.resolve.JsPlatform import org.jetbrains.kotlin.psi.KtNamedFunction +import org.jetbrains.kotlin.resolve.TargetPlatform import org.jetbrains.kotlin.util.capitalizeDecapitalize.decapitalizeSmart import org.jetbrains.kotlin.utils.SmartList @@ -38,6 +41,8 @@ class ConvertCamelCaseTestFunctionToSpacedIntention : SelfTargetingRangeIntentio KtNamedFunction::class.java, "Replace camel-case name with spaces" ) { override fun applicabilityRange(element: KtNamedFunction): TextRange? { + val platform = element.platform + if (platform == TargetPlatform.Common || platform == JsPlatform) return null val range = element.nameIdentifier?.textRange ?: return null val name = element.name ?: return null @@ -62,7 +67,7 @@ class ConvertCamelCaseTestFunctionToSpacedIntention : SelfTargetingRangeIntentio val result = SmartList() var previousCase = Case.OTHER var from = 0 - for (i in 0..name.length - 1) { + for (i in 0 until name.length) { val c = name[i] val currentCase = when { Character.isUpperCase(c) -> Case.UPPER