From e62a2bbf2f7230f52fa3b75f72e576ad60144330 Mon Sep 17 00:00:00 2001
From: Alexander Udalov <Alexander.Udalov@jetbrains.com>
Date: Mon, 2 Sep 2013 23:03:08 +0400
Subject: [PATCH] Support any constant expressions as annotation arguments

---
 .../impl/JavaAnnotationArgumentImpl.java      |  8 +++++---
 .../JavaLiteralAnnotationArgumentImpl.java    | 20 ++++++++++---------
 ...tationWithArithmeticExpressionInParam.java | 10 ++++++++++
 ...otationWithArithmeticExpressionInParam.txt | 14 +++++++++++++
 ...otationWithStringConcatenationInParam.java | 10 ++++++++++
 ...notationWithStringConcatenationInParam.txt | 13 ++++++++++++
 .../AnnotationWithStringConstantInParam.java  | 12 +++++++++++
 .../AnnotationWithStringConstantInParam.txt   | 17 ++++++++++++++++
 .../AnnotationWithStringInParam.java          | 10 ++++++++++
 .../AnnotationWithStringInParam.txt           | 13 ++++++++++++
 .../jvm/compiler/LoadJavaTestGenerated.java   | 20 +++++++++++++++++++
 11 files changed, 135 insertions(+), 12 deletions(-)
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.java
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.txt
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.java
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.txt
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.java
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.txt
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.java
 create mode 100644 compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.txt

diff --git a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaAnnotationArgumentImpl.java b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaAnnotationArgumentImpl.java
index 53ee1b144fc..f601c77f785 100644
--- a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaAnnotationArgumentImpl.java
+++ b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaAnnotationArgumentImpl.java
@@ -32,10 +32,12 @@ public abstract class JavaAnnotationArgumentImpl extends JavaElementImpl<PsiAnno
 
     @NotNull
     /* package */ static JavaAnnotationArgument create(@NotNull PsiAnnotationMemberValue argument, @Nullable Name name) {
-        if (argument instanceof PsiLiteralExpression) {
-            return new JavaLiteralAnnotationArgumentImpl((PsiLiteralExpression) argument, name);
+        Object value = JavaPsiFacade.getInstance(argument.getProject()).getConstantEvaluationHelper().computeConstantExpression(argument);
+        if (value != null || argument instanceof PsiLiteralExpression) {
+            return new JavaLiteralAnnotationArgumentImpl(name, value);
         }
-        else if (argument instanceof PsiReferenceExpression) {
+
+        if (argument instanceof PsiReferenceExpression) {
             return new JavaReferenceAnnotationArgumentImpl((PsiReferenceExpression) argument, name);
         }
         else if (argument instanceof PsiArrayInitializerMemberValue) {
diff --git a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaLiteralAnnotationArgumentImpl.java b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaLiteralAnnotationArgumentImpl.java
index 227bae73fc2..0453afe1b4f 100644
--- a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaLiteralAnnotationArgumentImpl.java
+++ b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/structure/impl/JavaLiteralAnnotationArgumentImpl.java
@@ -16,26 +16,28 @@
 
 package org.jetbrains.jet.lang.resolve.java.structure.impl;
 
-import com.intellij.psi.PsiLiteralExpression;
-import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.jetbrains.jet.lang.resolve.java.structure.JavaLiteralAnnotationArgument;
 import org.jetbrains.jet.lang.resolve.name.Name;
 
-public class JavaLiteralAnnotationArgumentImpl extends JavaAnnotationArgumentImpl implements JavaLiteralAnnotationArgument {
-    protected JavaLiteralAnnotationArgumentImpl(@NotNull PsiLiteralExpression psiLiteralExpression, @Nullable Name name) {
-        super(psiLiteralExpression, name);
+public class JavaLiteralAnnotationArgumentImpl implements JavaLiteralAnnotationArgument {
+    private final Name name;
+    private final Object value;
+
+    public JavaLiteralAnnotationArgumentImpl(@Nullable Name name, @Nullable Object value) {
+        this.name = name;
+        this.value = value;
     }
 
-    @NotNull
     @Override
-    public PsiLiteralExpression getPsi() {
-        return (PsiLiteralExpression) super.getPsi();
+    @Nullable
+    public Name getName() {
+        return name;
     }
 
     @Override
     @Nullable
     public Object getValue() {
-        return getPsi().getValue();
+        return value;
     }
 }
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.java b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.java
new file mode 100644
index 00000000000..eb604cd3505
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.java
@@ -0,0 +1,10 @@
+package test;
+
+public class AnnotationWithArithmeticExpressionInParam {
+    public @interface Anno {
+        int value();
+    }
+
+    @Anno(2 * 8 + 13 * (239 - 237))
+    public static class Class {}
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.txt b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.txt
new file mode 100644
index 00000000000..82b416ae8e2
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.txt
@@ -0,0 +1,14 @@
+package test
+
+public open class AnnotationWithArithmeticExpressionInParam : java.lang.Object {
+    public constructor AnnotationWithArithmeticExpressionInParam()
+    
+    public final annotation class Anno : jet.Annotation {
+        public constructor Anno(/*0*/ value: jet.Int)
+        public abstract fun value(): jet.Int
+    }
+    
+    test.AnnotationWithArithmeticExpressionInParam.Anno(value = 42.toInt(): jet.Int) public open class Class : java.lang.Object {
+        public constructor Class()
+    }
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.java b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.java
new file mode 100644
index 00000000000..cf4eddb40cb
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.java
@@ -0,0 +1,10 @@
+package test;
+
+public interface AnnotationWithStringConcatenationInParam {
+    public @interface Anno {
+        String value();
+    }
+
+    @Anno("he" + "l" + "lo")
+    public static class Class { }
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.txt b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.txt
new file mode 100644
index 00000000000..d8eb89f1b6c
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.txt
@@ -0,0 +1,13 @@
+package test
+
+public trait AnnotationWithStringConcatenationInParam : java.lang.Object {
+    
+    public final annotation class Anno : jet.Annotation {
+        public constructor Anno(/*0*/ value: jet.String?)
+        public abstract fun value(): jet.String?
+    }
+    
+    test.AnnotationWithStringConcatenationInParam.Anno(value = "hello": jet.String) public open class Class : java.lang.Object {
+        public constructor Class()
+    }
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.java b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.java
new file mode 100644
index 00000000000..55fa5fa4046
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.java
@@ -0,0 +1,12 @@
+package test;
+
+public interface AnnotationWithStringConstantInParam {
+    public static final String HEL = "hel";
+
+    public @interface Anno {
+        String value();
+    }
+
+    @Anno(HEL + "lo")
+    public static class Class { }
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.txt b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.txt
new file mode 100644
index 00000000000..016a295c193
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.txt
@@ -0,0 +1,17 @@
+package test
+
+public trait AnnotationWithStringConstantInParam : java.lang.Object {
+    
+    public final annotation class Anno : jet.Annotation {
+        public constructor Anno(/*0*/ value: jet.String?)
+        public abstract fun value(): jet.String?
+    }
+    
+    test.AnnotationWithStringConstantInParam.Anno(value = "hello": jet.String) public open class Class : java.lang.Object {
+        public constructor Class()
+    }
+}
+
+package AnnotationWithStringConstantInParam {
+    public val HEL: jet.String
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.java b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.java
new file mode 100644
index 00000000000..bee4f5c7516
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.java
@@ -0,0 +1,10 @@
+package test;
+
+public interface AnnotationWithStringInParam {
+    public @interface Anno {
+        String value();
+    }
+
+    @Anno("hello")
+    public static class Class { }
+}
diff --git a/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.txt b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.txt
new file mode 100644
index 00000000000..431ba6634eb
--- /dev/null
+++ b/compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.txt
@@ -0,0 +1,13 @@
+package test
+
+public trait AnnotationWithStringInParam : java.lang.Object {
+    
+    public final annotation class Anno : jet.Annotation {
+        public constructor Anno(/*0*/ value: jet.String?)
+        public abstract fun value(): jet.String?
+    }
+    
+    test.AnnotationWithStringInParam.Anno(value = "hello": jet.String) public open class Class : java.lang.Object {
+        public constructor Class()
+    }
+}
diff --git a/compiler/tests/org/jetbrains/jet/jvm/compiler/LoadJavaTestGenerated.java b/compiler/tests/org/jetbrains/jet/jvm/compiler/LoadJavaTestGenerated.java
index ac18ffbb81f..a99a35340ca 100644
--- a/compiler/tests/org/jetbrains/jet/jvm/compiler/LoadJavaTestGenerated.java
+++ b/compiler/tests/org/jetbrains/jet/jvm/compiler/LoadJavaTestGenerated.java
@@ -1065,6 +1065,11 @@ public class LoadJavaTestGenerated extends AbstractLoadJavaTest {
                 doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithAnnotationInParam.java");
             }
             
+            @TestMetadata("AnnotationWithArithmeticExpressionInParam.java")
+            public void testAnnotationWithArithmeticExpressionInParam() throws Exception {
+                doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArithmeticExpressionInParam.java");
+            }
+            
             @TestMetadata("AnnotationWithArrayOfEnumInParam.java")
             public void testAnnotationWithArrayOfEnumInParam() throws Exception {
                 doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithArrayOfEnumInParam.java");
@@ -1090,6 +1095,21 @@ public class LoadJavaTestGenerated extends AbstractLoadJavaTest {
                 doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithPrimitiveValueInParam.java");
             }
             
+            @TestMetadata("AnnotationWithStringConcatenationInParam.java")
+            public void testAnnotationWithStringConcatenationInParam() throws Exception {
+                doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConcatenationInParam.java");
+            }
+            
+            @TestMetadata("AnnotationWithStringConstantInParam.java")
+            public void testAnnotationWithStringConstantInParam() throws Exception {
+                doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringConstantInParam.java");
+            }
+            
+            @TestMetadata("AnnotationWithStringInParam.java")
+            public void testAnnotationWithStringInParam() throws Exception {
+                doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/AnnotationWithStringInParam.java");
+            }
+            
             @TestMetadata("CustomAnnotation.java")
             public void testCustomAnnotation() throws Exception {
                 doTestCompiledJava("compiler/testData/loadJava/compiledJava/annotations/CustomAnnotation.java");