Parcelable: Add quick fixes

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/basic.after.kt

@@ -0,0 +1,30 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>companion object : Parceler<Foo> {
+
+        override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/basic.before.Main.kt

@@ -0,0 +1,36 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    override fun describeContents(): Int {
+        return 0
+    }
+
+    companion object CREATOR : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/complexCase1.after.kt

@@ -0,0 +1,34 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    companion object : Parceler<Foo> {
+        <caret>override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo = TODO()
+    }
+
+    private abstract class Creator : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/complexCase1.before.Main.kt

@@ -0,0 +1,34 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    companion object {
+        @JvmField
+        val <caret>CREATOR: Parcelable.Creator<Foo> = object : Creator() {}
+    }
+
+    private abstract class Creator : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/customDescribeContents.after.kt

@@ -0,0 +1,34 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>override fun describeContents(): Int {
+        return 50
+    }
+
+    companion object : Parceler<Foo> {
+
+        override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/customDescribeContents.before.Main.kt

@@ -0,0 +1,36 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    override fun describeContents(): Int {
+        return 50
+    }
+
+    companion object CREATOR : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/fromCreatorObject.after.kt

@@ -0,0 +1,30 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    companion object <caret>: Parceler<Foo> {
+
+        override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/fromCreatorObject.before.Main.kt

@@ -0,0 +1,32 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    companion object <caret>CREATOR : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/innerClassFactory.after.kt

@@ -0,0 +1,36 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    companion object : Parceler<Foo> {
+        <caret>override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+
+    private class Creator : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/innerClassFactory.before.Main.kt

@@ -0,0 +1,34 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    companion object {
+        @JvmField
+        val <caret>CREATOR: Parcelable.Creator<Foo> = Creator()
+    }
+
+    private class Creator : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/jvmField.after.kt

@@ -0,0 +1,26 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    companion object : Parceler<Foo> {
+        <caret>override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/jvmField.before.Main.kt

@@ -0,0 +1,32 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(parcel.readString(), parcel.readInt())
+
+    override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    companion object {
+        @JvmField
+        val <caret>CREATOR = object : Parcelable.Creator<Foo> {
+            override fun createFromParcel(parcel: Parcel): Foo {
+                return Foo(parcel)
+            }
+
+            override fun newArray(size: Int): Array<Foo?> {
+                return arrayOfNulls(size)
+            }
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/noWriteToParcel.after.kt

@@ -0,0 +1,25 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    companion object <caret>: Parceler<Foo> {
+
+        fun Foo.write(parcel: Parcel, flags: Int) = TODO()
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/noWriteToParcel.before.Main.kt

@@ -0,0 +1,30 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    override fun describeContents(): Int {
+        return 0
+    }
+
+    companion object <caret>CREATOR : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/withoutDescribeContents.after.kt

@@ -0,0 +1,30 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parceler
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>companion object : Parceler<Foo> {
+
+        override fun Foo.write(parcel: Parcel, flags: Int) {
+            parcel.writeString(firstName)
+            parcel.writeInt(age)
+        }
+
+        override fun create(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+    }
+}

plugins/android-extensions/android-extensions-idea/testData/android/parcel/quickfix/migrations/withoutDescribeContents.before.Main.kt

@@ -0,0 +1,32 @@
+// "Migrate to ''Parceler'' companion object" "true"
+// ERROR: 'CREATOR' definition is not allowed. Use 'Parceler' companion object instead.
+// ERROR: Overriding 'writeToParcel' is not allowed. Use 'Parceler' companion object instead.
+// WITH_RUNTIME
+
+package com.myapp.activity
+
+import android.os.*
+import kotlinx.android.parcel.Parcelize
+
+@Parcelize
+class Foo(val firstName: String, val age: Int) : Parcelable {
+    constructor(parcel: Parcel) : this(
+            parcel.readString(),
+            parcel.readInt()) {
+    }
+
+    <caret>override fun writeToParcel(parcel: Parcel, flags: Int) {
+        parcel.writeString(firstName)
+        parcel.writeInt(age)
+    }
+
+    companion object CREATOR : Parcelable.Creator<Foo> {
+        override fun createFromParcel(parcel: Parcel): Foo {
+            return Foo(parcel)
+        }
+
+        override fun newArray(size: Int): Array<Foo?> {
+            return arrayOfNulls(size)
+        }
+    }
+}