diff --git a/core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/specialBuiltinMembers.kt b/core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/specialBuiltinMembers.kt index 798037373cb..1f7990eb438 100644 --- a/core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/specialBuiltinMembers.kt +++ b/core/descriptor.loader.java/src/org/jetbrains/kotlin/load/java/specialBuiltinMembers.kt @@ -60,7 +60,7 @@ object BuiltinSpecialProperties { } private fun CallableMemberDescriptor.hasBuiltinSpecialPropertyFqNameImpl(): Boolean { - if (FQ_NAMES.containsRaw(fqNameOrNull())) return true + if (fqNameOrNull() in FQ_NAMES) return true if (!isFromBuiltins()) return false return overriddenDescriptors.any { hasBuiltinSpecialPropertyFqName(it) } @@ -108,7 +108,7 @@ object BuiltinMethodsWithSpecialGenericSignature { ERASED_VALUE_PARAMETERS_FQ_NAMES.map { it.shortName() }.toSet() private val CallableMemberDescriptor.hasErasedValueParametersInJava: Boolean - get() = ERASED_VALUE_PARAMETERS_FQ_NAMES.containsRaw(fqNameOrNull()) + get() = fqNameOrNull() in ERASED_VALUE_PARAMETERS_FQ_NAMES @JvmStatic fun getOverriddenBuiltinFunctionWithErasedValueParametersInJava( @@ -122,7 +122,7 @@ object BuiltinMethodsWithSpecialGenericSignature { fun getDefaultValueForOverriddenBuiltinFunction(functionDescriptor: FunctionDescriptor): DefaultValue? { if (functionDescriptor.name !in ERASED_VALUE_PARAMETERS_SHORT_NAMES) return null return functionDescriptor.firstOverridden { - GENERIC_PARAMETERS_METHODS_TO_DEFAULT_VALUES_MAP.keys.containsRaw(it.fqNameOrNull()) + it.fqNameOrNull() in GENERIC_PARAMETERS_METHODS_TO_DEFAULT_VALUES_MAP.keys }?.let { GENERIC_PARAMETERS_METHODS_TO_DEFAULT_VALUES_MAP[it.fqNameSafe] } } diff --git a/idea/src/org/jetbrains/kotlin/idea/codeInsight/KotlinCopyPasteReferenceProcessor.kt b/idea/src/org/jetbrains/kotlin/idea/codeInsight/KotlinCopyPasteReferenceProcessor.kt index 266eecbf744..819717f67b1 100644 --- a/idea/src/org/jetbrains/kotlin/idea/codeInsight/KotlinCopyPasteReferenceProcessor.kt +++ b/idea/src/org/jetbrains/kotlin/idea/codeInsight/KotlinCopyPasteReferenceProcessor.kt @@ -68,8 +68,8 @@ public class KotlinCopyPasteReferenceProcessor() : CopyPastePostProcessor()) private val IGNORE_REFERENCES_INSIDE: Array> = arrayOf( - javaClass(), - javaClass() + KtImportList::class.java, + KtPackageDirective::class.java ) override fun extractTransferableData(content: Transferable): List { @@ -139,7 +139,7 @@ public class KotlinCopyPasteReferenceProcessor() : CopyPastePostProcessor(canGoInside = { it.javaClass !in IGNORE_REFERENCES_INSIDE }) { element -> + element.forEachDescendantOfType(canGoInside = { it.javaClass as Class<*> !in IGNORE_REFERENCES_INSIDE }) { element -> val reference = element.mainReference ?: return@forEachDescendantOfType val descriptors = reference.resolveToDescriptors(element.analyze()) //TODO: we could use partial body resolve for all references together diff --git a/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinEditorTextProvider.kt b/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinEditorTextProvider.kt index c4786e614d4..68a04a61bf1 100644 --- a/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinEditorTextProvider.kt +++ b/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinEditorTextProvider.kt @@ -116,10 +116,10 @@ class KotlinEditorTextProvider : EditorTextProvider { } private val NOT_ACCEPTED_AS_CONTEXT_TYPES = - arrayOf(javaClass(), javaClass(), javaClass()) + arrayOf(KtUserType::class.java, KtImportDirective::class.java, KtPackageDirective::class.java) fun isAcceptedAsCodeFragmentContext(element: PsiElement): Boolean { - return element.javaClass !in NOT_ACCEPTED_AS_CONTEXT_TYPES && + return element.javaClass as Class<*> !in NOT_ACCEPTED_AS_CONTEXT_TYPES && PsiTreeUtil.getParentOfType(element, *NOT_ACCEPTED_AS_CONTEXT_TYPES) == null } } diff --git a/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinPositionManager.kt b/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinPositionManager.kt index 19242d41a5d..eef172bf589 100644 --- a/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinPositionManager.kt +++ b/idea/src/org/jetbrains/kotlin/idea/debugger/KotlinPositionManager.kt @@ -420,7 +420,7 @@ public class KotlinPositionManager(private val myDebugProcess: DebugProcess) : M KtAnonymousInitializer::class.java) private fun getElementToCalculateClassName(notPositionedElement: PsiElement?): KtElement? { - if (notPositionedElement?.javaClass in TYPES_TO_CALCULATE_CLASSNAME ) return notPositionedElement as KtElement + if (notPositionedElement?.javaClass as Class<*> in TYPES_TO_CALCULATE_CLASSNAME) return notPositionedElement as KtElement return PsiTreeUtil.getParentOfType(notPositionedElement, *TYPES_TO_CALCULATE_CLASSNAME) } diff --git a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertFunctionToPropertyIntention.kt b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertFunctionToPropertyIntention.kt index 528cb9e92d3..7f121005a1c 100644 --- a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertFunctionToPropertyIntention.kt +++ b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertFunctionToPropertyIntention.kt @@ -132,7 +132,7 @@ public class ConvertFunctionToPropertyIntention : SelfTargetingIntention false - element is KtBinaryExpression && OperatorConventions.ASSIGNMENT_OPERATIONS.containsKeyRaw(element.operationToken) -> true - element is KtUnaryExpression && OperatorConventions.INCREMENT_OPERATIONS.containsRaw(element.operationToken) -> true + element is KtBinaryExpression && OperatorConventions.ASSIGNMENT_OPERATIONS.contains(element.operationToken) -> true + element is KtUnaryExpression && OperatorConventions.INCREMENT_OPERATIONS.contains(element.operationToken) -> true element is KtCallExpression -> element.getResolvedCall(context)?.resultingDescriptor is ConstructorDescriptor else -> element.children.any { needSeparateVariable(it) } } @@ -210,7 +210,7 @@ class KotlinFunctionCallUsage( } } - var expressionToReplace: KtExpression = nameCounterpartMap.getRaw(ref.element) ?: continue + var expressionToReplace: KtExpression = nameCounterpartMap[ref.element] ?: continue val parent = expressionToReplace.parent if (parent is KtThisExpression) { diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractableAnalysisUtil.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractableAnalysisUtil.kt index 9f8596c3b8a..0f0a51d30e2 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractableAnalysisUtil.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractableAnalysisUtil.kt @@ -305,9 +305,9 @@ private fun ExtractionData.analyzeControlFlow( } val outParameters = - parameters.filter { it.mirrorVarName != null && modifiedVarDescriptors.getRaw(it.originalDescriptor) != null }.sortedBy { it.nameForRef } + parameters.filter { it.mirrorVarName != null && modifiedVarDescriptors[it.originalDescriptor] != null }.sortedBy { it.nameForRef } val outDeclarations = - declarationsToCopy.filter { modifiedVarDescriptors.getRaw(bindingContext[BindingContext.DECLARATION_TO_DESCRIPTOR, it]) != null } + declarationsToCopy.filter { modifiedVarDescriptors[bindingContext[BindingContext.DECLARATION_TO_DESCRIPTOR, it]] != null } val modifiedValueCount = outParameters.size + outDeclarations.size val outputValues = ArrayList() @@ -339,7 +339,7 @@ private fun ExtractionData.analyzeControlFlow( val descriptor = bindingContext[BindingContext.DECLARATION_TO_DESCRIPTOR, it] as? CallableDescriptor Initializer(it as KtProperty, descriptor?.returnType ?: module.builtIns.defaultParameterType) } - outParameters.mapTo(outputValues) { ParameterUpdate(it, modifiedVarDescriptors.getRaw(it.originalDescriptor)!!) } + outParameters.mapTo(outputValues) { ParameterUpdate(it, modifiedVarDescriptors[it.originalDescriptor]!!) } if (outputValues.isNotEmpty()) { if (jumpExits.isNotEmpty()) return outputAndExitsError diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractorUtil.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractorUtil.kt index 82093066cda..60227e42690 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractorUtil.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/extractorUtil.kt @@ -459,7 +459,7 @@ fun ExtractionGeneratorConfiguration.generateDeclaration( val counterpartMap = createNameCounterpartMap(currentResultExpression, expressionToUnifyWith ?: newResultExpression) counterpartMap.entries.forEach { val (cmOriginalExpr, cmNewExpr) = it - nameByOffset.entrySet().find { it.value.containsRaw(cmOriginalExpr) }?.let { + nameByOffset.entrySet().find { cmOriginalExpr in it.value }?.let { nameByOffset.remove(it.key, cmOriginalExpr) nameByOffset.putValue(it.key, cmNewExpr) } @@ -512,7 +512,7 @@ fun ExtractionGeneratorConfiguration.generateDeclaration( val jumpValue = descriptor.controlFlow.jumpOutputValue if (jumpValue != null) { replacingReturn = psiFactory.createExpression(if (jumpValue.conditional) "return true" else "return") - returnsForLabelRemoval.removeAllRaw(jumpValue.elementsToReplace) + returnsForLabelRemoval.removeAll(jumpValue.elementsToReplace) expressionsToReplaceWithReturn = getCounterparts(jumpValue.elementsToReplace, body, bodyOffset, file) } else { diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/inferParameterInfo.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/inferParameterInfo.kt index 45f2f0768ab..44dfeb85db8 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/inferParameterInfo.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/introduce/extractionEngine/inferParameterInfo.kt @@ -101,7 +101,7 @@ internal fun ExtractionData.inferParametersInfo( if (currentName == null) { currentName = KotlinNameSuggester.suggestNamesByType(getParameterType(options.allowSpecialClassNames), varNameValidator, "p").first() } - mirrorVarName = if (modifiedVarDescriptors.containsRaw(descriptorToExtract)) KotlinNameSuggester.suggestNameByName(name, varNameValidator) else null + mirrorVarName = if (descriptorToExtract in modifiedVarDescriptors) KotlinNameSuggester.suggestNameByName(name, varNameValidator) else null info.parameters.add(this) } } diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/pullUp/pullUpConflictsUtils.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/pullUp/pullUpConflictsUtils.kt index bc6ee25e7c8..00570d622e5 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/pullUp/pullUpConflictsUtils.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/pullUp/pullUpConflictsUtils.kt @@ -164,10 +164,10 @@ private fun KotlinPullUpData.checkVisibility( val childrenToCheck = member.allChildren.toArrayList() if (memberInfo.isToAbstract && member is KtCallableDeclaration) { when (member) { - is KtNamedFunction -> childrenToCheck.remove(member.bodyExpression) + is KtNamedFunction -> childrenToCheck.remove(member.bodyExpression as PsiElement?) is KtProperty -> { - childrenToCheck.remove(member.initializer) - childrenToCheck.remove(member.delegateExpression) + childrenToCheck.remove(member.initializer as PsiElement?) + childrenToCheck.remove(member.delegateExpression as PsiElement?) childrenToCheck.removeAll(member.accessors) } }