Fix #KT-26353 'Make variable immutable' is a bad name for a quickfix that changes 'var' to 'val'

idea/src/org/jetbrains/kotlin/idea/quickfix/ChangeVariableMutabilityFix.kt

@@ -36,7 +36,7 @@ class ChangeVariableMutabilityFix(
     private val actionText: String? = null
 ) : KotlinQuickFixAction<KtValVarKeywordOwner>(element) {
 
-    override fun getText() = actionText ?: if (makeVar) "Make variable mutable" else "Make variable immutable"
+    override fun getText() = actionText ?: if (makeVar) "Change to var" else "Change to val"
 
     override fun getFamilyName(): String = text
 

idea/testData/quickfix/foldTryCatch/conditional.kt

@@ -1,5 +1,5 @@
 // "class org.jetbrains.kotlin.idea.quickfix.LiftAssignmentOutOfTryFix" "false"
-// ACTION: Make variable mutable
+// ACTION: Change to var
 // ERROR: Val cannot be reassigned
 // WITH_RUNTIME
 

idea/testData/quickfix/foldTryCatch/shadow.kt

@@ -1,5 +1,5 @@
 // "class org.jetbrains.kotlin.idea.quickfix.LiftAssignmentOutOfTryFix" "false"
-// ACTION: Make variable mutable
+// ACTION: Change to var
 // ERROR: Val cannot be reassigned
 // ERROR: Val cannot be reassigned
 // WITH_RUNTIME

idea/testData/quickfix/lateinit/val.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 class A() {
     <caret>lateinit val foo: String

idea/testData/quickfix/lateinit/val.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 class A() {
     <caret>lateinit var foo: String

idea/testData/quickfix/variables/changeMutability/canBeVal/const.kt

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 object Test {
     <caret>const var foo = "123"
 }

idea/testData/quickfix/variables/changeMutability/canBeVal/const.kt.after

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 object Test {
     <caret>const val foo = "123"
 }

idea/testData/quickfix/variables/changeMutability/canBeVal/multiVariable.kt

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 fun foo(p: Int) {
     <caret>var (v1, v2) = getPair()!!
     v1

idea/testData/quickfix/variables/changeMutability/canBeVal/multiVariable.kt.after

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 fun foo(p: Int) {
     <caret>val (v1, v2) = getPair()!!
     v1

idea/testData/quickfix/variables/changeMutability/canBeVal/singleVariable.kt

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 fun foo(p: Int) {
     <caret>var v: Int
     if (p > 0) v = 1 else v = 2

idea/testData/quickfix/variables/changeMutability/canBeVal/singleVariable.kt.after

@@ -1,4 +1,4 @@
-// "Make variable immutable" "true"
+// "Change to val" "true"
 fun foo(p: Int) {
     <caret>val v: Int
     if (p > 0) v = 1 else v = 2

idea/testData/quickfix/variables/changeMutability/capturedMemberValInitialization.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 class Test {
     val a: String

idea/testData/quickfix/variables/changeMutability/capturedMemberValInitialization.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 class Test {
     var a: String

idea/testData/quickfix/variables/changeMutability/capturedValInitialization.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 fun exec(f: () -> Unit) = f()
 
 fun foo() {

idea/testData/quickfix/variables/changeMutability/capturedValInitialization.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 fun exec(f: () -> Unit) = f()
 
 fun foo() {

idea/testData/quickfix/variables/changeMutability/funParameter.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "false"
+// "Change to var" "false"
 // ACTION: Remove redundant assignment
 // ERROR: Val cannot be reassigned
 fun fun1(i: Int) {

idea/testData/quickfix/variables/changeMutability/localInGetter.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 val String.prop: Int
     get() {

idea/testData/quickfix/variables/changeMutability/localInGetter.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 
 val String.prop: Int
     get() {

idea/testData/quickfix/variables/changeMutability/valOverrideVar.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 open class A {
     open var x = 42;
 }

idea/testData/quickfix/variables/changeMutability/valOverrideVar.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 open class A {
     open var x = 42;
 }

idea/testData/quickfix/variables/changeMutability/valOverrideVarConstructorParameter.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 open class A {
     open var x = 42;
 }

idea/testData/quickfix/variables/changeMutability/valOverrideVarConstructorParameter.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 open class A {
     open var x = 42;
 }

idea/testData/quickfix/variables/changeMutability/valReassignmentLocal.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 fun foo() {
     val a = 1
     <caret>a = 3

idea/testData/quickfix/variables/changeMutability/valReassignmentLocal.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 fun foo() {
     var a = 1
     <caret>a = 3

idea/testData/quickfix/variables/changeMutability/valReassignmentOuterDecl.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 val a = 4
 
 fun bar() {

idea/testData/quickfix/variables/changeMutability/valReassignmentOuterDecl.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 var a = 4
 
 fun bar() {

idea/testData/quickfix/variables/changeMutability/valReassignmentProperty.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A() {
     val a = 1
 

idea/testData/quickfix/variables/changeMutability/valReassignmentProperty.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A() {
     var a = 1
 

idea/testData/quickfix/variables/changeMutability/valReassignmentPropertyConstructorParameter.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A(val a: Int) {
     fun foo() {
         <caret>a = 5

idea/testData/quickfix/variables/changeMutability/valReassignmentPropertyConstructorParameter.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A(var a: Int) {
     fun foo() {
         a = 5

idea/testData/quickfix/variables/changeMutability/valWithSetter.kt

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A() {
     val a: Int = 0
         <caret>set(v: Int) {}

idea/testData/quickfix/variables/changeMutability/valWithSetter.kt.after

@@ -1,4 +1,4 @@
-// "Make variable mutable" "true"
+// "Change to var" "true"
 class A() {
     var a: Int = 0
         set(v: Int) {}