diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt index 9fdc2c7fb91..73c8aaaa57e 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt @@ -79,10 +79,9 @@ private fun gradleVersionFromFile(psiFile: PsiFile): GradleVersion? { val MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX = GradleVersion.version("4.4") -fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String): Boolean { +fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String, gradleVersion: GradleVersion): Boolean { if (!preferNewSyntax) return false - val gradleVersion = fetchGradleVersion(scriptFile) if (gradleVersion < MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX) return false if (isConfiguredWithOldSyntax(kotlinPluginName)) return false @@ -91,4 +90,18 @@ fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String): Bool val hasOldApply = fileText.contains("apply plugin:") return !hasOldApply +} + +private val MIN_GRADLE_VERSION_FOR_API_AND_IMPLEMENTATION = GradleVersion.version("3.4") + +fun GradleVersion.scope(directive: String): String { + if (this < MIN_GRADLE_VERSION_FOR_API_AND_IMPLEMENTATION) { + return when (directive) { + "implementation" -> "compile" + "testImplementation" -> "testCompile" + else -> throw IllegalArgumentException("Unknown directive `$directive`") + } + } + + return directive } \ No newline at end of file diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt.173 b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt.173 index bf967b30bd9..f89534e77eb 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt.173 +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleBuildScriptManipulator.kt.173 @@ -65,6 +65,10 @@ interface GradleBuildScriptManipulator { fun addResolutionStrategy(pluginId: String) } + +// Kept for compatibility reasons (pre-181.3 IDEAs) +val BuildScriptDataBuilder.gradleVersion get() = GradleVersion.version("0.0") + fun fetchGradleVersion(psiFile: PsiFile): GradleVersion { return gradleVersionFromFile(psiFile) ?: GradleVersion.current() } @@ -75,13 +79,9 @@ private fun gradleVersionFromFile(psiFile: PsiFile): GradleVersion? { val MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX = GradleVersion.version("4.4") -// Kept for compatibility reasons (pre-181.3 IDEAs) -val BuildScriptDataBuilder.gradleVersion get() = GradleVersion.version("0.0") - -fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String): Boolean { +fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String, gradleVersion: GradleVersion): Boolean { if (!preferNewSyntax) return false - val gradleVersion = fetchGradleVersion(scriptFile) if (gradleVersion < MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX) return false if (isConfiguredWithOldSyntax(kotlinPluginName)) return false @@ -90,4 +90,18 @@ fun GradleBuildScriptManipulator<*>.useNewSyntax(kotlinPluginName: String): Bool val hasOldApply = fileText.contains("apply plugin:") return !hasOldApply +} + +private val MIN_GRADLE_VERSION_FOR_API_AND_IMPLEMENTATION = GradleVersion.version("3.4") + +fun GradleVersion.scope(directive: String): String { + if (this < MIN_GRADLE_VERSION_FOR_API_AND_IMPLEMENTATION) { + return when (directive) { + "implementation" -> "compile" + "testImplementation" -> "testCompile" + else -> throw IllegalArgumentException("Unknown directive `$directive`") + } + } + + return directive } \ No newline at end of file diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleKotlinFrameworkSupportProvider.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleKotlinFrameworkSupportProvider.kt index e62b90cbd77..bb97676180c 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleKotlinFrameworkSupportProvider.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GradleKotlinFrameworkSupportProvider.kt @@ -81,7 +81,8 @@ abstract class GradleKotlinFrameworkSupportProvider( kotlinVersion = LAST_SNAPSHOT_VERSION } - val useNewSyntax = buildScriptData.gradleVersion >= MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX + val gradleVersion = buildScriptData.gradleVersion + val useNewSyntax = gradleVersion >= MIN_GRADLE_VERSION_FOR_NEW_PLUGIN_SYNTAX if (useNewSyntax) { if (additionalRepository != null) { val oneLineRepository = additionalRepository.toGroovyRepositorySnippet().replace('\n', ' ') @@ -117,14 +118,16 @@ abstract class GradleKotlinFrameworkSupportProvider( buildScriptData.addRepositoriesDefinition("mavenCentral()") for (dependency in getDependencies(sdk)) { - buildScriptData.addDependencyNotation(KotlinWithGradleConfigurator.getGroovyDependencySnippet(dependency, "compile", !useNewSyntax)) + buildScriptData.addDependencyNotation( + KotlinWithGradleConfigurator.getGroovyDependencySnippet(dependency, "implementation", !useNewSyntax, gradleVersion) + ) } for (dependency in getTestDependencies()) { buildScriptData.addDependencyNotation( if (":" in dependency) - "testCompile \"$dependency\"" + "${gradleVersion.scope("testImplementation")} \"$dependency\"" else - KotlinWithGradleConfigurator.getGroovyDependencySnippet(dependency, "testCompile", !useNewSyntax) + KotlinWithGradleConfigurator.getGroovyDependencySnippet(dependency, "testImplementation", !useNewSyntax, gradleVersion) ) } diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GroovyBuildScriptManipulator.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GroovyBuildScriptManipulator.kt index 5ffb5f81afa..b77ef384a9b 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GroovyBuildScriptManipulator.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/GroovyBuildScriptManipulator.kt @@ -21,6 +21,7 @@ import com.intellij.openapi.roots.ExternalLibraryDescriptor import com.intellij.openapi.util.text.StringUtil import com.intellij.psi.PsiElement import com.intellij.psi.codeStyle.CodeStyleManager +import org.gradle.util.GradleVersion import org.jetbrains.kotlin.cli.common.arguments.CliArgumentStringBuilder.buildArgumentString import org.jetbrains.kotlin.cli.common.arguments.CliArgumentStringBuilder.replaceLanguageFeature import org.jetbrains.kotlin.config.LanguageFeature @@ -43,6 +44,8 @@ class GroovyBuildScriptManipulator( override val scriptFile: GroovyFile, override val preferNewSyntax: Boolean ) : GradleBuildScriptManipulator { + private val gradleVersion = fetchGradleVersion(scriptFile) + override fun isConfiguredWithOldSyntax(kotlinPluginName: String): Boolean { val fileText = runReadAction { scriptFile.text } return containsDirective(fileText, getApplyPluginDirective(kotlinPluginName)) && @@ -67,7 +70,7 @@ class GroovyBuildScriptManipulator( ): Boolean { val oldText = scriptFile.text - val useNewSyntax = useNewSyntax(kotlinPluginName) + val useNewSyntax = useNewSyntax(kotlinPluginName, gradleVersion) if (useNewSyntax) { scriptFile .getPluginsBlock() @@ -109,7 +112,11 @@ class GroovyBuildScriptManipulator( } scriptFile.getDependenciesBlock().apply { - addExpressionOrStatementInBlockIfNeeded(getGroovyDependencySnippet(stdlibArtifactName, !useNewSyntax), false, false) + addExpressionOrStatementInBlockIfNeeded( + getGroovyDependencySnippet(stdlibArtifactName, !useNewSyntax, gradleVersion), + isStatement = false, + isFirst = false + ) } if (jvmTarget != null) { @@ -121,7 +128,7 @@ class GroovyBuildScriptManipulator( } override fun configureProjectBuildScript(kotlinPluginName: String, version: String): Boolean { - if (useNewSyntax(kotlinPluginName)) return false + if (useNewSyntax(kotlinPluginName, gradleVersion)) return false val oldText = scriptFile.text scriptFile.apply { @@ -347,8 +354,9 @@ class GroovyBuildScriptManipulator( private fun getGroovyDependencySnippet( artifactName: String, - withVersion: Boolean - ) = "implementation \"org.jetbrains.kotlin:$artifactName${if (withVersion) ":\$kotlin_version" else ""}\"" + withVersion: Boolean, + gradleVersion: GradleVersion + ) = "${gradleVersion.scope("implementation")} \"org.jetbrains.kotlin:$artifactName${if (withVersion) ":\$kotlin_version" else ""}\"" private fun getApplyPluginDirective(pluginName: String) = "apply plugin: '$pluginName'" diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinBuildScriptManipulator.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinBuildScriptManipulator.kt index 424fbfd9a3f..7c719cf5a3e 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinBuildScriptManipulator.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinBuildScriptManipulator.kt @@ -37,6 +37,8 @@ class KotlinBuildScriptManipulator( override val scriptFile: KtFile, override val preferNewSyntax: Boolean ) : GradleBuildScriptManipulator { + private val gradleVersion = fetchGradleVersion(scriptFile) + override fun isConfiguredWithOldSyntax(kotlinPluginName: String) = runReadAction { scriptFile.containsApplyKotlinPlugin(kotlinPluginName) && scriptFile.containsCompileStdLib() } @@ -46,7 +48,7 @@ class KotlinBuildScriptManipulator( } override fun configureProjectBuildScript(kotlinPluginName: String, version: String): Boolean { - if (useNewSyntax(kotlinPluginName)) return false + if (useNewSyntax(kotlinPluginName, gradleVersion)) return false val originalText = scriptFile.text scriptFile.getBuildScriptBlock()?.apply { @@ -73,7 +75,7 @@ class KotlinBuildScriptManipulator( jvmTarget: String? ): Boolean { val originalText = scriptFile.text - val useNewSyntax = useNewSyntax(kotlinPluginName) + val useNewSyntax = useNewSyntax(kotlinPluginName, gradleVersion) scriptFile.apply { if (useNewSyntax) { createPluginInPluginsGroupIfMissing(kotlinPluginExpression, version) @@ -179,7 +181,7 @@ class KotlinBuildScriptManipulator( } private fun KtBlockExpression.addNoVersionCompileStdlibIfMissing(stdlibArtifactName: String): KtCallExpression? = - findStdLibDependency() ?: addExpressionIfMissing("compile(${getKotlinModuleDependencySnippet(stdlibArtifactName, null)})") as? KtCallExpression + findStdLibDependency() ?: addExpressionIfMissing("implementation(${getKotlinModuleDependencySnippet(stdlibArtifactName, null)})") as? KtCallExpression private fun KtFile.containsCompileStdLib(): Boolean = findScriptInitializer("dependencies")?.getBlock()?.findStdLibDependency() != null @@ -470,13 +472,20 @@ class KotlinBuildScriptManipulator( groupId: String, artifactId: String, version: String?, - compileScope: String = "compile" + compileScope: String = "implementation" ): String { if (groupId != KOTLIN_GROUP_ID) { return "$compileScope(\"$groupId:$artifactId:$version\")" } - if (useNewSyntax(if (scriptFile.module?.getBuildSystemType() == AndroidGradle) "kotlin-android" else KotlinGradleModuleConfigurator.KOTLIN)) { + val kotlinPluginName = + if (scriptFile.module?.getBuildSystemType() == AndroidGradle) { + "kotlin-android" + } else { + KotlinGradleModuleConfigurator.KOTLIN + } + + if (useNewSyntax(kotlinPluginName, gradleVersion)) { return "$compileScope(${getKotlinModuleDependencySnippet(artifactId)})" } diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinDslGradleKotlinFrameworkSupportProvider.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinDslGradleKotlinFrameworkSupportProvider.kt index a595356d94d..b3ac2a53282 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinDslGradleKotlinFrameworkSupportProvider.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinDslGradleKotlinFrameworkSupportProvider.kt @@ -121,7 +121,7 @@ class KotlinDslGradleKotlinJavaFrameworkSupportProvider : override fun getPluginDefinition() = "kotlin(\"jvm\")" override fun getRuntimeLibrary(rootModel: ModifiableRootModel, version: String?) = - "compile(${getKotlinModuleDependencySnippet(getStdlibArtifactId(rootModel.sdk, bundledRuntimeVersion()), version)})" + "implementation(${getKotlinModuleDependencySnippet(getStdlibArtifactId(rootModel.sdk, bundledRuntimeVersion()), version)})" override fun addSupport( projectId: ProjectId, @@ -147,7 +147,7 @@ class KotlinDslGradleKotlinJSFrameworkSupportProvider : override fun getPluginDefinition(): String = "id(\"kotlin2js\")" override fun getRuntimeLibrary(rootModel: ModifiableRootModel, version: String?) = - "compile(${getKotlinModuleDependencySnippet(MAVEN_JS_STDLIB_ID.removePrefix("kotlin-"), version)})" + "implementation(${getKotlinModuleDependencySnippet(MAVEN_JS_STDLIB_ID.removePrefix("kotlin-"), version)})" override fun addSupport( projectId: ProjectId, diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinJsGradleModuleConfigurator.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinJsGradleModuleConfigurator.kt index 76875203986..44be31810bd 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinJsGradleModuleConfigurator.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinJsGradleModuleConfigurator.kt @@ -34,7 +34,9 @@ class KotlinJsGradleModuleConfigurator : KotlinWithGradleConfigurator() { override fun getStdlibArtifactName(sdk: Sdk?, version: String): String = MAVEN_JS_STDLIB_ID override fun addElementsToFile(file: PsiFile, isTopLevelProjectFile: Boolean, version: String): Boolean { - if (getManipulator(file).useNewSyntax(kotlinPluginName)) { + val gradleVersion = fetchGradleVersion(file) + + if (getManipulator(file).useNewSyntax(kotlinPluginName, gradleVersion)) { val settingsPsiFile = if (isTopLevelProjectFile) { file.module?.getTopLevelBuildScriptSettingsPsiFile() } else { diff --git a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinWithGradleConfigurator.kt b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinWithGradleConfigurator.kt index 438876c4d99..84976c9d460 100644 --- a/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinWithGradleConfigurator.kt +++ b/idea/idea-gradle/src/org/jetbrains/kotlin/idea/configuration/KotlinWithGradleConfigurator.kt @@ -25,6 +25,7 @@ import com.intellij.psi.PsiElement import com.intellij.psi.PsiFile import com.intellij.psi.PsiManager import com.intellij.util.PathUtil +import org.gradle.util.GradleVersion import org.jetbrains.kotlin.config.ApiVersion import org.jetbrains.kotlin.config.CoroutineSupport import org.jetbrains.kotlin.config.LanguageFeature @@ -302,8 +303,12 @@ abstract class KotlinWithGradleConfigurator : KotlinProjectConfigurator { private val KOTLIN_BUILD_SCRIPT_NAME = "build.gradle.kts" private val KOTLIN_SETTINGS_SCRIPT_NAME = "settings.gradle.kts" - fun getGroovyDependencySnippet(artifactName: String, scope: String, withVersion: Boolean) = - "$scope \"org.jetbrains.kotlin:$artifactName${if (withVersion) ":\$kotlin_version" else ""}\"" + fun getGroovyDependencySnippet(artifactName: String, scope: String, withVersion: Boolean, gradleVersion: GradleVersion): String { + val updatedScope = gradleVersion.scope(scope) + val versionStr = if (withVersion) ":\$kotlin_version" else "" + + return "$updatedScope \"org.jetbrains.kotlin:$artifactName$versionStr\"" + } fun getGroovyApplyPluginDirective(pluginName: String) = "apply plugin: '$pluginName'" diff --git a/idea/testData/configuration/android-gsk/emptyFile_after.gradle.kts b/idea/testData/configuration/android-gsk/emptyFile_after.gradle.kts index dabcddba2d0..a45c4cd0f81 100644 --- a/idea/testData/configuration/android-gsk/emptyFile_after.gradle.kts +++ b/idea/testData/configuration/android-gsk/emptyFile_after.gradle.kts @@ -13,7 +13,7 @@ apply { plugin("kotlin-android") } dependencies { - compile(kotlinModule("stdlib-jdk7", kotlin_version)) + implementation(kotlinModule("stdlib-jdk7", kotlin_version)) } repositories { mavenCentral() diff --git a/idea/testData/configuration/android-gsk/helloWorld_after.gradle.kts b/idea/testData/configuration/android-gsk/helloWorld_after.gradle.kts index 9e91e473dd4..9021f5a6284 100644 --- a/idea/testData/configuration/android-gsk/helloWorld_after.gradle.kts +++ b/idea/testData/configuration/android-gsk/helloWorld_after.gradle.kts @@ -41,7 +41,7 @@ android { dependencies { compile("com.android.support:appcompat-v7:23.4.0") compile("com.android.support.constraint:constraint-layout:1.0.0-alpha8") - compile(kotlinModule("stdlib-jdk7", kotlin_version)) + implementation(kotlinModule("stdlib-jdk7", kotlin_version)) } repositories { diff --git a/idea/testData/configuration/gradle/default/build_after.gradle b/idea/testData/configuration/gradle/default/build_after.gradle index 0349e42b87f..99c361d1386 100644 --- a/idea/testData/configuration/gradle/default/build_after.gradle +++ b/idea/testData/configuration/gradle/default/build_after.gradle @@ -10,7 +10,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" } buildscript { ext.kotlin_version = '$VERSION$' diff --git a/idea/testData/configuration/gradle/eapVersion/build_after.gradle b/idea/testData/configuration/gradle/eapVersion/build_after.gradle index aabfdd7f5eb..441bc5941b7 100644 --- a/idea/testData/configuration/gradle/eapVersion/build_after.gradle +++ b/idea/testData/configuration/gradle/eapVersion/build_after.gradle @@ -11,7 +11,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" } buildscript { ext.kotlin_version = '$VERSION$' diff --git a/idea/testData/configuration/gradle/jreLib/build_after.gradle b/idea/testData/configuration/gradle/jreLib/build_after.gradle index 3f5d1aa6989..0e094bf9adc 100644 --- a/idea/testData/configuration/gradle/jreLib/build_after.gradle +++ b/idea/testData/configuration/gradle/jreLib/build_after.gradle @@ -5,7 +5,7 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-jre8" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jre8" } compileKotlin { kotlinOptions { diff --git a/idea/testData/configuration/gradle/js/build_after.gradle b/idea/testData/configuration/gradle/js/build_after.gradle index 650032e83fd..6215b95b6ae 100644 --- a/idea/testData/configuration/gradle/js/build_after.gradle +++ b/idea/testData/configuration/gradle/js/build_after.gradle @@ -7,5 +7,5 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-js" + implementation "org.jetbrains.kotlin:kotlin-stdlib-js" } diff --git a/idea/testData/configuration/gradle/m04Version/build_after.gradle b/idea/testData/configuration/gradle/m04Version/build_after.gradle index cca5b8e6941..cd1414642c6 100644 --- a/idea/testData/configuration/gradle/m04Version/build_after.gradle +++ b/idea/testData/configuration/gradle/m04Version/build_after.gradle @@ -11,7 +11,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" } buildscript { ext.kotlin_version = '$VERSION$' diff --git a/idea/testData/configuration/gradle/missedLibrary/build_after.gradle b/idea/testData/configuration/gradle/missedLibrary/build_after.gradle index 84127f7cabe..cf7fdaea8ff 100644 --- a/idea/testData/configuration/gradle/missedLibrary/build_after.gradle +++ b/idea/testData/configuration/gradle/missedLibrary/build_after.gradle @@ -6,7 +6,7 @@ version = '1.0' dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" } buildscript { diff --git a/idea/testData/configuration/gradle/plugin_present/build_after.gradle b/idea/testData/configuration/gradle/plugin_present/build_after.gradle index 8be3603e4d7..2f836845c71 100644 --- a/idea/testData/configuration/gradle/plugin_present/build_after.gradle +++ b/idea/testData/configuration/gradle/plugin_present/build_after.gradle @@ -6,7 +6,7 @@ version = '1.0' dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" } buildscript { diff --git a/idea/testData/configuration/gradle/rcVersion/build_after.gradle b/idea/testData/configuration/gradle/rcVersion/build_after.gradle index aabfdd7f5eb..441bc5941b7 100644 --- a/idea/testData/configuration/gradle/rcVersion/build_after.gradle +++ b/idea/testData/configuration/gradle/rcVersion/build_after.gradle @@ -11,7 +11,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" } buildscript { ext.kotlin_version = '$VERSION$' diff --git a/idea/testData/configuration/gradle/withJava9ModuleInfo/build_after.gradle b/idea/testData/configuration/gradle/withJava9ModuleInfo/build_after.gradle index 6c063e5ed82..14d6839b949 100644 --- a/idea/testData/configuration/gradle/withJava9ModuleInfo/build_after.gradle +++ b/idea/testData/configuration/gradle/withJava9ModuleInfo/build_after.gradle @@ -10,7 +10,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.11' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" } buildscript { ext.kotlin_version = '$VERSION$' diff --git a/idea/testData/configuration/gsk/eap11Version/build_after.gradle.kts b/idea/testData/configuration/gsk/eap11Version/build_after.gradle.kts index e036bc6e987..81f75371138 100644 --- a/idea/testData/configuration/gsk/eap11Version/build_after.gradle.kts +++ b/idea/testData/configuration/gsk/eap11Version/build_after.gradle.kts @@ -17,7 +17,7 @@ repositories { dependencies { testCompile("junit:junit:4.12") - compile(kotlin("stdlib-jre8")) + implementation(kotlin("stdlib-jre8")) } // VERSION: $VERSION$ diff --git a/idea/testData/configuration/gsk/eapVersion/build_after.gradle.kts b/idea/testData/configuration/gsk/eapVersion/build_after.gradle.kts index 6fef107ce2d..77222888439 100644 --- a/idea/testData/configuration/gsk/eapVersion/build_after.gradle.kts +++ b/idea/testData/configuration/gsk/eapVersion/build_after.gradle.kts @@ -16,7 +16,7 @@ repositories { dependencies { testCompile("junit:junit:4.12") - compile(kotlin("stdlib")) + implementation(kotlin("stdlib")) } // VERSION: $VERSION$ \ No newline at end of file diff --git a/idea/testData/configuration/gsk/helloWorld/build_after.gradle.kts b/idea/testData/configuration/gsk/helloWorld/build_after.gradle.kts index 5f4f58832bb..c014d09670b 100644 --- a/idea/testData/configuration/gsk/helloWorld/build_after.gradle.kts +++ b/idea/testData/configuration/gsk/helloWorld/build_after.gradle.kts @@ -16,7 +16,7 @@ repositories { dependencies { testCompile("junit:junit:4.12") - compile(kotlin("stdlib-jdk8")) + implementation(kotlin("stdlib-jdk8")) } val compileKotlin: KotlinCompile by tasks compileKotlin.kotlinOptions { diff --git a/idea/testData/configuration/gsk/missedLibrary/build_after.gradle.kts b/idea/testData/configuration/gsk/missedLibrary/build_after.gradle.kts index 76de301b61c..b01aee1ea7e 100644 --- a/idea/testData/configuration/gsk/missedLibrary/build_after.gradle.kts +++ b/idea/testData/configuration/gsk/missedLibrary/build_after.gradle.kts @@ -30,7 +30,7 @@ repositories { dependencies { testCompile("junit:junit:4.12") - compile(kotlin("stdlib-jdk8")) + implementation(kotlin("stdlib-jdk8")) } val compileKotlin: KotlinCompile by tasks compileKotlin.kotlinOptions { diff --git a/idea/testData/configuration/gsk/pluginPresent/build_after.gradle.kts b/idea/testData/configuration/gsk/pluginPresent/build_after.gradle.kts index d41d03ae47a..64273ad8577 100644 --- a/idea/testData/configuration/gsk/pluginPresent/build_after.gradle.kts +++ b/idea/testData/configuration/gsk/pluginPresent/build_after.gradle.kts @@ -20,7 +20,7 @@ repositories { dependencies { testCompile("junit:junit:4.12") - compile(kotlin("stdlib-jdk8")) + implementation(kotlin("stdlib-jdk8")) } val compileKotlin: KotlinCompile by tasks compileKotlin.kotlinOptions { diff --git a/idea/testData/gradle/configurator/configure10/build.gradle.3.5.after b/idea/testData/gradle/configurator/configure10/build.gradle.3.5.after index 1da77db838f..3a362c4cdd1 100644 --- a/idea/testData/gradle/configurator/configure10/build.gradle.3.5.after +++ b/idea/testData/gradle/configurator/configure10/build.gradle.3.5.after @@ -13,5 +13,5 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" } diff --git a/idea/testData/gradle/configurator/configure10/build.gradle.4.9.after b/idea/testData/gradle/configurator/configure10/build.gradle.4.9.after index 1d379070701..fa5f5827147 100644 --- a/idea/testData/gradle/configurator/configure10/build.gradle.4.9.after +++ b/idea/testData/gradle/configurator/configure10/build.gradle.4.9.after @@ -11,5 +11,5 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib" + implementation "org.jetbrains.kotlin:kotlin-stdlib" } diff --git a/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.3.5.after b/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.3.5.after index 8c6dd573435..f862a3a0f71 100644 --- a/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.3.5.after +++ b/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.3.5.after @@ -16,7 +16,7 @@ apply { plugin("kotlin") } dependencies { - compile(kotlinModule("stdlib-jre8", kotlin_version)) + implementation(kotlinModule("stdlib-jre8", kotlin_version)) } repositories { mavenCentral() diff --git a/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.4.9.after b/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.4.9.after index f9a75c1f617..6e7d6d04835 100644 --- a/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.4.9.after +++ b/idea/testData/gradle/configurator/configureGSK/build.gradle.kts.4.9.after @@ -10,7 +10,7 @@ buildscript { } } dependencies { - compile(kotlin("stdlib-jre8")) + implementation(kotlin("stdlib-jre8")) } repositories { mavenCentral() diff --git a/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.3.5.after b/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.3.5.after index 19c478a2dec..2334b29c5c3 100644 --- a/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.3.5.after +++ b/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.3.5.after @@ -18,7 +18,7 @@ apply { plugin("kotlin") } dependencies { - compile(kotlinModule("stdlib-jdk8", kotlin_version)) + implementation(kotlinModule("stdlib-jdk8", kotlin_version)) } repositories { maven { setUrl("https://teamcity.jetbrains.com/guestAuth/app/rest/builds/buildType:(id:Kotlin_dev_Compiler),number:1.2.60-dev-286,branch:default:any/artifacts/content/maven/") } diff --git a/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.4.9.after b/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.4.9.after index 557b0088363..fa8cdd6acba 100644 --- a/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.4.9.after +++ b/idea/testData/gradle/configurator/configureGradleKtsKotlinDevVersion/build.gradle.kts.4.9.after @@ -6,7 +6,7 @@ plugins { group = "testgroup" version = "1.0-SNAPSHOT" dependencies { - compile(kotlin("stdlib-jdk8")) + implementation(kotlin("stdlib-jdk8")) } repositories { maven { setUrl("https://teamcity.jetbrains.com/guestAuth/app/rest/builds/buildType:(id:Kotlin_dev_Compiler),number:1.2.60-dev-286,branch:default:any/artifacts/content/maven/") } diff --git a/idea/testData/gradle/configurator/configureJsEAPWithBuildGradle/build.gradle.after b/idea/testData/gradle/configurator/configureJsEAPWithBuildGradle/build.gradle.after index b9ff59dc4a0..bb61241e3ab 100644 --- a/idea/testData/gradle/configurator/configureJsEAPWithBuildGradle/build.gradle.after +++ b/idea/testData/gradle/configurator/configureJsEAPWithBuildGradle/build.gradle.after @@ -9,5 +9,5 @@ repositories { maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' } } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-js" + implementation "org.jetbrains.kotlin:kotlin-stdlib-js" } diff --git a/idea/testData/gradle/configurator/configureJsEAPWithBuildGradleKts/build.gradle.kts.after b/idea/testData/gradle/configurator/configureJsEAPWithBuildGradleKts/build.gradle.kts.after index dcf73d59582..5e83d211553 100644 --- a/idea/testData/gradle/configurator/configureJsEAPWithBuildGradleKts/build.gradle.kts.after +++ b/idea/testData/gradle/configurator/configureJsEAPWithBuildGradleKts/build.gradle.kts.after @@ -9,5 +9,5 @@ repositories { maven { setUrl("https://dl.bintray.com/kotlin/kotlin-eap") } } dependencies { - compile(kotlin("stdlib-js")) + implementation(kotlin("stdlib-js")) } diff --git a/idea/testData/gradle/configurator/configureJsWithBuildGradle/build.gradle.after b/idea/testData/gradle/configurator/configureJsWithBuildGradle/build.gradle.after index f775d085cc0..1f796bceaca 100644 --- a/idea/testData/gradle/configurator/configureJsWithBuildGradle/build.gradle.after +++ b/idea/testData/gradle/configurator/configureJsWithBuildGradle/build.gradle.after @@ -8,5 +8,5 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-js" + implementation "org.jetbrains.kotlin:kotlin-stdlib-js" } diff --git a/idea/testData/gradle/configurator/configureJsWithBuildGradleKts/build.gradle.kts.after b/idea/testData/gradle/configurator/configureJsWithBuildGradleKts/build.gradle.kts.after index dee724b0b0f..531bd66c15c 100644 --- a/idea/testData/gradle/configurator/configureJsWithBuildGradleKts/build.gradle.kts.after +++ b/idea/testData/gradle/configurator/configureJsWithBuildGradleKts/build.gradle.kts.after @@ -8,5 +8,5 @@ repositories { mavenCentral() } dependencies { - compile(kotlin("stdlib-js")) + implementation(kotlin("stdlib-js")) } diff --git a/idea/testData/gradle/configurator/configureJvmEAPWithBuildGradle/build.gradle.after b/idea/testData/gradle/configurator/configureJvmEAPWithBuildGradle/build.gradle.after index 48a88e91291..80655e995cb 100644 --- a/idea/testData/gradle/configurator/configureJvmEAPWithBuildGradle/build.gradle.after +++ b/idea/testData/gradle/configurator/configureJvmEAPWithBuildGradle/build.gradle.after @@ -15,7 +15,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8" } compileKotlin { kotlinOptions { diff --git a/idea/testData/gradle/configurator/configureJvmWithBuildGradle/build.gradle.after b/idea/testData/gradle/configurator/configureJvmWithBuildGradle/build.gradle.after index af3580bb32b..eca123c5de9 100644 --- a/idea/testData/gradle/configurator/configureJvmWithBuildGradle/build.gradle.after +++ b/idea/testData/gradle/configurator/configureJvmWithBuildGradle/build.gradle.after @@ -14,7 +14,7 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8" } compileKotlin { kotlinOptions { diff --git a/idea/testData/gradle/configurator/configureJvmWithBuildGradleKts/build.gradle.kts.after b/idea/testData/gradle/configurator/configureJvmWithBuildGradleKts/build.gradle.kts.after index 8760802091d..e10865205eb 100644 --- a/idea/testData/gradle/configurator/configureJvmWithBuildGradleKts/build.gradle.kts.after +++ b/idea/testData/gradle/configurator/configureJvmWithBuildGradleKts/build.gradle.kts.after @@ -14,7 +14,7 @@ repositories { dependencies { testCompile("junit", "junit", "4.12") - compile(kotlin("stdlib-jdk8")) + implementation(kotlin("stdlib-jdk8")) } configure { diff --git a/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.3.5.after b/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.3.5.after index fe0f2d7ba0c..218bd63a07b 100644 --- a/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.3.5.after +++ b/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.3.5.after @@ -20,7 +20,7 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" } compileKotlin { kotlinOptions { diff --git a/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.4.9.after b/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.4.9.after index 30599f08a08..28fcdd9a066 100644 --- a/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.4.9.after +++ b/idea/testData/gradle/configurator/configureKotlinDevVersion/build.gradle.4.9.after @@ -10,7 +10,7 @@ repositories { mavenCentral() } dependencies { - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8" } compileKotlin { kotlinOptions { diff --git a/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.3.5.after b/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.3.5.after index d504bc5bea1..8bbf3aeab32 100644 --- a/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.3.5.after +++ b/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.3.5.after @@ -23,5 +23,5 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' - compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" + implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" } diff --git a/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.4.9.after b/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.4.9.after index 6021b4b836d..5f1eab32cb5 100644 --- a/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.4.9.after +++ b/idea/testData/gradle/configurator/configureKotlinWithPluginsBlock/build.gradle.4.9.after @@ -14,5 +14,5 @@ repositories { dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' - compile "org.jetbrains.kotlin:kotlin-stdlib" + implementation "org.jetbrains.kotlin:kotlin-stdlib" }