Add inspection + intention to replace .let { it.foo() } with .foo() #KT-13551 Fixed

idea/testData/intentions/replaceSingleLineLetIntention/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSingleLineLetIntention

idea/testData/intentions/replaceSingleLineLetIntention/let.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.length<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/let.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.length
+}

idea/testData/intentions/replaceSingleLineLetIntention/letMultipleLines.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.length<caret>
+        it.length
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letNoSafeCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String = ""
+    foo.let {
+        it.length<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letNoSafeCall.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String = ""
+    foo.length
+}

idea/testData/intentions/replaceSingleLineLetIntention/letNotUseParameterReceiver.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        text ->
+        "".to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letNotUseReceiver.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        "".to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letUseIt.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to(it)<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letUseItWithMultipleMethodCall1.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to(it).to("").to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letUseItWithMultipleMethodCall2.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("").to(it).to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letUseItWithMultipleMethodCall3.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("").to("").to(it)<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letUseParameter.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        text ->
+        text.to(text)<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithMethodCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithMethodCall.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.to("")
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithMultipleMethodCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("").to("")<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithMultipleMethodCall.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.to("").to("")
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithParameter.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        text ->
+        text.length<caret>
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/letWithParameter.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.length
+}

idea/testData/intentions/replaceSingleLineLetIntention/sameLets.kt

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.toString()?.let {
+        it.to("")<caret>
+    }?.let {
+        it.to("")
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/sameLets.kt.after

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun foo() {
+    val foo: String? = null
+    foo?.toString()?.to("")?.let {
+        it.to("")
+    }
+}

idea/testData/intentions/replaceSingleLineLetIntention/this.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode().hashCode() }
+}

idea/testData/intentions/replaceSingleLineLetIntention/this.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun Int.foo(): Int {
+    return hashCode().hashCode()
+}

idea/testData/intentions/replaceSingleLineLetIntention/thisShort.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode() }
+}

idea/testData/intentions/replaceSingleLineLetIntention/thisShort.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: true
+
+fun Int.foo(): Int {
+    return hashCode()
+}