From e3f85653e9fab789bd7be152d320036d45ae7076 Mon Sep 17 00:00:00 2001 From: Nikolay Krasko Date: Mon, 23 May 2016 18:09:01 +0300 Subject: [PATCH] Don't request write action for RemoveUnusedFunctionParameterFix because it's based on refactoring (KT-12440) Workaround for exception: Refactorings should not be started inside write action because they start progress inside and any read action from the progress task would cause the deadlock #KT-12440 Fixed --- .../kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt b/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt index e7f60ce3ff3..c535f27420d 100644 --- a/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt +++ b/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt @@ -30,6 +30,8 @@ class RemoveUnusedFunctionParameterFix(parameter: KtParameter) : KotlinQuickFixA override fun getText() = "Remove parameter '${element.name}'" + override fun startInWriteAction(): Boolean = false + override fun invoke(project: Project, editor: Editor?, file: KtFile) { val parameterDescriptor = element.resolveToDescriptor() as ValueParameterDescriptor ChangeFunctionSignatureFix.runRemoveParameter(parameterDescriptor, element)