[FIR] Track local variable assigned types for smartcast stability

When a lambda captures a local variable without a contract, future
assignments can impact the smartcast stability for that variable within
the lambda. Because future assignments can appear in both resolved and
unresolved code, track each assignment as encountered. To determine if
a smartcast can be considered stable, check that all future assignments
are resolved and do not revert variable to a super type.

^KT-58191 Fixed
This commit is contained in:
Brian Norman
2024-01-04 15:21:12 -06:00
committed by Space Team
parent e02c28c88a
commit e3ddeff230
8 changed files with 185 additions and 58 deletions
@@ -1,3 +1,4 @@
// SKIP_TXT
// ISSUE: KT-55338
fun test_1() {
@@ -8,7 +9,7 @@ fun test_1() {
s = "hello"
}
<!DEBUG_INFO_SMARTCAST!>s<!>.length // smartcast in K1 and K2
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1, unsafe call in K2 <------------
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1 and K2
}
}
@@ -62,7 +63,7 @@ fun test_3_2() {
s = "world"
}
<!DEBUG_INFO_SMARTCAST!>s<!>.length // smartcast in K1 and K2
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1, unsafe call in K2 <------------
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1 and K2
}
}
@@ -90,7 +91,18 @@ fun test_4_2() {
s = getString()
}
<!DEBUG_INFO_SMARTCAST!>s<!>.length // smartcast in K1 and K2
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1, unsafe call in K2 <------------
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1 and K2
}
}
fun test_5() {
var s: String? = <!VARIABLE_WITH_REDUNDANT_INITIALIZER!>null<!>
for (i in 1..10) {
s = null
s = getString()
<!DEBUG_INFO_SMARTCAST!>s<!>.length // smartcast in K1 and K2
noInlineRun { <!DEBUG_INFO_SMARTCAST!>s<!>.length } // smartcast in K1, unsafe call in K2
}
}