azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[reflect] Fix flaky tests that depend on Reflection.clearCaches()

Browse Source 
* Use ReflectionFactoryImpl as single point of synchronization
* Synchronize all cache-sensitive tests on it in order to be robust in parallel test runners
* Remove redundant cache clear after each test

Merge-request: KT-MR-6842
Merged-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
This commit is contained in:
Vsevolod Tolstopyatov
2022-08-12 14:10:08 +00:00
committed by Space
parent 94abeb64c5
commit e32e5c26a4
8 changed files with 30 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/codegen/box/reflection/methodsFromAny/parametersEqualsWithClearCaches.kt
Vendored
+3 -1
View File
@@ -12,7 +12,9 @@ inline fun check(message: String, generate: () -> Any?) {
x1 = generate()
// Force clear the internal maps, as if the weak values in them are garbage-collected.
kotlin.reflect.jvm.internal.ReflectionFactoryImpl.clearCaches()
synchronized(kotlin.reflect.jvm.internal.ReflectionFactoryImpl::class.java) {
kotlin.reflect.jvm.internal.ReflectionFactoryImpl.clearCaches()
}
x2 = generate()
} catch (e: Throwable) {
compiler/testData/codegen/box/reflection/methodsFromAny/typeParametersEqualsWithClearCaches.kt
Vendored
+3 -1
View File
@@ -11,7 +11,9 @@ inline fun check(message: String, generate: () -> Any?) {
x1 = generate()
// Force clear the internal maps, as if the weak values in them are garbage-collected.
kotlin.reflect.jvm.internal.ReflectionFactoryImpl.clearCaches()
synchronized(kotlin.reflect.jvm.internal.ReflectionFactoryImpl::class.java) {
kotlin.reflect.jvm.internal.ReflectionFactoryImpl.clearCaches()
}
x2 = generate()
} catch (e: Throwable) {