From e2f0b76e2f2a26d566670b548f85aed3c539ae8b Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Thu, 28 May 2020 20:22:28 +0900 Subject: [PATCH] Minor: extract new line allowance check --- .../kotlin/idea/inspections/TrailingCommaInspection.kt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt index 9e0355427a7..ba676b58b56 100644 --- a/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt +++ b/idea/src/org/jetbrains/kotlin/idea/inspections/TrailingCommaInspection.kt @@ -63,9 +63,8 @@ class TrailingCommaInspection( } val last = TrailingCommaHelper.elementAfterLastElement(commaOwner) - val whenEntryWithoutTrailingComma = - commaOwner is KtWhenEntry && TrailingCommaHelper.trailingCommaOrLastElement(commaOwner)?.isComma != true - if (last?.prevLeaf(true)?.isLineBreak() == false && !whenEntryWithoutTrailingComma) { + + if (last?.prevLeaf(true)?.isLineBreak() == false && !allowMissingLineBreak(commaOwner)) { registerProblemForLineBreak( commaOwner, last, @@ -74,6 +73,11 @@ class TrailingCommaInspection( } } + private fun allowMissingLineBreak(commaOwner: KtElement): Boolean { + return commaOwner is KtWhenEntry + && TrailingCommaHelper.trailingCommaOrLastElement(commaOwner)?.isComma != true + } + private fun checkCommaPosition(commaOwner: KtElement) { for (invalidComma in TrailingCommaHelper.findInvalidCommas(commaOwner)) { reportProblem(