azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NI] Fix KotlinResolutionCandidate.isSuccessfull

Browse Source 
Check if ConstrainSystem has any contradiction in 'isSuccessful'.
Otherwise we may erroneously think that there are some successful
candidates in 'TowerResolver.SuccessfullResultCollector.pushCandidates()'
and clear other unsuccessful ones (while they actually may have higher
applicability).
This commit is contained in:
Dmitry Savvinov
2017-11-27 19:52:22 +03:00
parent 78a526c937
commit e2d65adc7e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/model/ResolutionCandidate.kt
+1 -1
View File
@@ -145,7 +145,7 @@ class KotlinResolutionCandidate(
override val isSuccessful: Boolean override val isSuccessful: Boolean
get() { get() {
processParts(stopOnFirstError = true) processParts(stopOnFirstError = true)
return currentApplicability.isSuccess && variableApplicability.isSuccess return currentApplicability.isSuccess && variableApplicability.isSuccess && !getSystem().hasContradiction
} }
override val resultingApplicability: ResolutionCandidateApplicability override val resultingApplicability: ResolutionCandidateApplicability