azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor, cut down unnecessary 'load' in for-progression codegen

Browse Source
This commit is contained in:
Alexander Udalov
2013-06-18 19:47:03 +04:00
parent ee80e0b8ca
commit e22947281c
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/backend/src/org/jetbrains/jet/codegen/ExpressionCodegen.java
+2 -6
View File
@@ -1024,6 +1024,8 @@ public class ExpressionCodegen extends JetVisitor<StackValue, StackValue> implem
@Override @Override
public void conditionAndJump(@NotNull Label loopExit) { public void conditionAndJump(@NotNull Label loopExit) {
v.load(loopParameterVar, asmElementType); v.load(loopParameterVar, asmElementType);
v.load(endVar, asmElementType);
v.load(incrementVar, asmElementType); v.load(incrementVar, asmElementType);
Label negativeIncrement = new Label(); Label negativeIncrement = new Label();
@@ -1038,13 +1040,11 @@ public class ExpressionCodegen extends JetVisitor<StackValue, StackValue> implem
v.ifle(negativeIncrement); // if increment < 0, jump v.ifle(negativeIncrement); // if increment < 0, jump
// increment > 0 // increment > 0
v.load(endVar, asmElementType);
v.ificmpgt(loopExit); v.ificmpgt(loopExit);
v.goTo(afterIf); v.goTo(afterIf);
// increment < 0 // increment < 0
v.visitLabel(negativeIncrement); v.visitLabel(negativeIncrement);
v.load(endVar, asmElementType);
v.ificmplt(loopExit); v.ificmplt(loopExit);
v.visitLabel(afterIf); v.visitLabel(afterIf);
@@ -1056,14 +1056,12 @@ public class ExpressionCodegen extends JetVisitor<StackValue, StackValue> implem
v.ifle(negativeIncrement); // if increment < 0, jump v.ifle(negativeIncrement); // if increment < 0, jump
// increment > 0 // increment > 0
v.load(endVar, asmElementType);
v.lcmp(); v.lcmp();
v.ifgt(loopExit); v.ifgt(loopExit);
v.goTo(afterIf); v.goTo(afterIf);
// increment < 0 // increment < 0
v.visitLabel(negativeIncrement); v.visitLabel(negativeIncrement);
v.load(endVar, asmElementType);
v.lcmp(); v.lcmp();
v.iflt(loopExit); v.iflt(loopExit);
v.visitLabel(afterIf); v.visitLabel(afterIf);
@@ -1082,14 +1080,12 @@ public class ExpressionCodegen extends JetVisitor<StackValue, StackValue> implem
v.ifle(negativeIncrement); // if increment < 0, jump v.ifle(negativeIncrement); // if increment < 0, jump
// increment > 0 // increment > 0
v.load(endVar, asmElementType);
v.cmpg(asmElementType); // if loop parameter is NaN, exit from loop, as well v.cmpg(asmElementType); // if loop parameter is NaN, exit from loop, as well
v.ifgt(loopExit); v.ifgt(loopExit);
v.goTo(afterIf); v.goTo(afterIf);
// increment < 0 // increment < 0
v.visitLabel(negativeIncrement); v.visitLabel(negativeIncrement);
v.load(endVar, asmElementType);
v.cmpl(asmElementType); // if loop parameter is NaN, exit from loop, as well v.cmpl(asmElementType); // if loop parameter is NaN, exit from loop, as well
v.iflt(loopExit); v.iflt(loopExit);
v.visitLabel(afterIf); v.visitLabel(afterIf);