azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

K1: don't report UNRESOLVED_WITH_TARGET on hidden setters

Browse Source
This commit is contained in:
Mikhail Glukhikh
2022-07-22 14:06:37 +02:00
committed by teamcity
parent 00d1e46c5a
commit e20efc1398
6 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/kotlin/checkers/utils/DebugInfoUtil.kt
+8 -1
View File
@@ -16,12 +16,14 @@ import org.jetbrains.kotlin.diagnostics.DiagnosticFactory
import org.jetbrains.kotlin.diagnostics.Errors
import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
import org.jetbrains.kotlin.resolve.calls.util.getResolvedCall
import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.BindingContextUtils
import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
import org.jetbrains.kotlin.resolve.calls.tasks.isDynamic
import org.jetbrains.kotlin.types.error.ErrorUtils
import org.jetbrains.kotlin.types.expressions.BasicExpressionTypingVisitor
import org.jetbrains.kotlin.util.slicedMap.WritableSlice
import java.util.HashMap
@@ -172,7 +174,12 @@ object DebugInfoUtil {
}
if (resolved && markedWithError) {
if (Errors.UNRESOLVED_REFERENCE_DIAGNOSTICS.contains(factory)) {
debugInfoReporter.reportUnresolvedWithTarget(expression, target!!)
// This check is to avoid reporting UnresolvedWithTarget on hidden setters
if (expression !is KtSimpleNameExpression ||
!BasicExpressionTypingVisitor.isLValue(expression, expression.getStrictParentOfType<KtBinaryExpression>())
) {
debugInfoReporter.reportUnresolvedWithTarget(expression, target!!)
}
}
} else if (!resolved && !markedWithError) {
debugInfoReporter.reportMissingUnresolved(expression)