azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR checker: introduce NO_(GET|SET)_METHOD

Browse Source 
Besides introducing new diagnostics, this commit unifies source usages
for array accesses in PSI & LT.
This commit is contained in:
Tianyu Geng
2021-03-11 16:01:58 -08:00
committed by Mikhail Glukhikh
parent 651fd4ad9f
commit e1c80ac75c
32 changed files with 137 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/LValueAssignment.fir.kt
Vendored
+1 -1
View File
@@ -128,7 +128,7 @@ class Test() {
(f@ a)[3] = 4
<!UNRESOLVED_REFERENCE!>this[54] = 34<!>
this<!NO_SET_METHOD!>[54]<!> = 34
}
}
compiler/testData/diagnostics/tests/annotations/rendering/memberProjectedOut.fir.kt
Vendored
+1 -1
View File
@@ -12,5 +12,5 @@ class C<T> {
}
fun test(a: C<out CharSequence>) {
<!INAPPLICABLE_CANDIDATE!>a[1] = 25<!>
<!INAPPLICABLE_CANDIDATE!>a[1]<!> = 25
}
compiler/testData/diagnostics/tests/checkArguments/arrayAccessSet.fir.kt
Vendored
+1 -1
View File
@@ -31,5 +31,5 @@ fun test() {
D[0] = ""
D[0] = 2.72
<!INAPPLICABLE_CANDIDATE!>Z[0] = ""<!>
<!INAPPLICABLE_CANDIDATE!>Z[0]<!> = ""
}
compiler/testData/diagnostics/tests/checkArguments/arrayAccessSetTooManyArgs.fir.kt
Vendored
+1 -1
View File
@@ -6,6 +6,6 @@ class A {
operator fun set(x: String, value: Int) {}
fun d(x: Int) {
<!INAPPLICABLE_CANDIDATE!>this["", 1] = 1<!>
<!INAPPLICABLE_CANDIDATE!>this["", 1]<!> = 1
}
}
compiler/testData/diagnostics/tests/collectionLiterals/noCollectionLiterals.fir.kt
Vendored
+1 -1
View File
@@ -1,7 +1,7 @@
// !WITH_NEW_INFERENCE
fun test(): Array<Int> {
[1, 2]
<!UNRESOLVED_REFERENCE!>[1, 2][0]<!>
[1, 2]<!NO_GET_METHOD!>[0]<!>
[1, 2].<!UNRESOLVED_REFERENCE!>get<!>(0)
foo([""])
compiler/testData/diagnostics/tests/generics/projectionsScope/projectedOutConventions.fir.kt
Vendored
+1 -1
View File
@@ -9,6 +9,6 @@ class A<T> {
fun test(a: A<out CharSequence>) {
a <!INAPPLICABLE_CANDIDATE!>+<!> ""
<!INAPPLICABLE_CANDIDATE!>a[1] = ""<!>
<!INAPPLICABLE_CANDIDATE!>a[1]<!> = ""
<!INAPPLICABLE_CANDIDATE!>a[""]<!>
}
compiler/testData/diagnostics/tests/generics/projectionsScope/typeMismatchConventions.fir.kt
Vendored
+1 -1
View File
@@ -11,7 +11,7 @@ class Out<out F>
fun test(a: A<out CharSequence>, y: Out<CharSequence>) {
a <!INAPPLICABLE_CANDIDATE!>+<!> y
<!INAPPLICABLE_CANDIDATE!>a[1] = y<!>
<!INAPPLICABLE_CANDIDATE!>a[1]<!> = y
<!INAPPLICABLE_CANDIDATE!>a[y]<!>
a + Out<Nothing>()
compiler/testData/diagnostics/tests/incompleteCode/diagnosticWithSyntaxError/arrayExpression.fir.kt
Vendored
+1 -1
View File
@@ -4,5 +4,5 @@ package bar
fun main() {
class Some
Some[<!SYNTAX!><!>] <!UNRESOLVED_REFERENCE!>names<!> <!UNRESOLVED_REFERENCE!><!SYNTAX!>=<!> ["ads"]<!>
Some[<!SYNTAX!><!>] <!UNRESOLVED_REFERENCE!>names<!> <!SYNTAX!>=<!> <!NO_GET_METHOD!>["ads"]<!>
}
compiler/testData/diagnostics/tests/incompleteCode/kt4866UnresolvedArrayAccess.fir.kt
Vendored
+2 -2
View File
@@ -1,5 +1,5 @@
//KT-4866 Resolve does not work inside brackets with unresolved reference before
fun test(i: Int, j: Int) {
<!UNRESOLVED_REFERENCE!><!UNRESOLVED_REFERENCE!>foo<!>[i, j]<!>
}
<!UNRESOLVED_REFERENCE!>foo<!><!NO_GET_METHOD!>[i, j]<!>
}
compiler/testData/diagnostics/tests/inference/kt28598.fir.kt
Vendored
+2 -2
View File
@@ -15,7 +15,7 @@ fun case_1(a: MutableList<out MutableList<MutableList<MutableList<MutableList<Mu
if (f != null) {
val g = f[0]
if (g != null) {
val h = <!UNRESOLVED_REFERENCE!>g[0]<!>
val h = g<!NO_GET_METHOD!>[0]<!>
if (h != null) {
h.<!UNRESOLVED_REFERENCE!>inc<!>()
}
@@ -43,7 +43,7 @@ fun case_2(a: MutableList<out MutableList<MutableList<MutableList<out MutableLis
if (f != null) {
val g = f[0]
if (g != null) {
val h = <!UNRESOLVED_REFERENCE!>g[0]<!> // no SMARTCAST diagnostic
val h = g<!NO_GET_METHOD!>[0]<!> // no SMARTCAST diagnostic
if (h != null) {
h.<!UNRESOLVED_REFERENCE!>inc<!>()
}
compiler/testData/diagnostics/tests/platformTypes/nullabilityWarnings/array.fir.kt
Vendored
-31
View File
@@ -1,31 +0,0 @@
// FILE: J.java
import org.jetbrains.annotations.*;
public class J {
@NotNull
public static Integer[] staticNN;
@Nullable
public static Integer[] staticN;
public static Integer[] staticJ;
}
// FILE: k.kt
fun test() {
// @NotNull platform type
val platformNN = J.staticNN
// @Nullable platform type
val platformN = J.staticN
// platform type with no annotation
val platformJ = J.staticJ
platformNN[0]
<!UNSAFE_CALL!>platformN[0]<!>
platformJ[0]
platformNN[0] = 1
<!UNSAFE_CALL!>platformN[0] = 1<!>
platformJ[0] = 1
}
compiler/testData/diagnostics/tests/platformTypes/nullabilityWarnings/array.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// FILE: J.java
import org.jetbrains.annotations.*;
compiler/testData/diagnostics/tests/platformTypes/nullabilityWarnings/primitiveArray.fir.kt
Vendored
-31
View File
@@ -1,31 +0,0 @@
// FILE: J.java
import org.jetbrains.annotations.*;
public class J {
@NotNull
public static int[] staticNN;
@Nullable
public static int[] staticN;
public static int[] staticJ;
}
// FILE: k.kt
fun test() {
// @NotNull platform type
val platformNN = J.staticNN
// @Nullable platform type
val platformN = J.staticN
// platform type with no annotation
val platformJ = J.staticJ
platformNN[0]
<!UNSAFE_CALL!>platformN[0]<!>
platformJ[0]
platformNN[0] = 1
<!UNSAFE_CALL!>platformN[0] = 1<!>
platformJ[0] = 1
}
compiler/testData/diagnostics/tests/platformTypes/nullabilityWarnings/primitiveArray.kt
Vendored
+1
View File
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// FILE: J.java
import org.jetbrains.annotations.*;
compiler/testData/diagnostics/tests/smartCasts/kt2865.fir.kt
Vendored
+1 -1
View File
@@ -7,6 +7,6 @@ fun foo(a: MutableMap<String, String>, x: String?) {
}
fun foo1(a: MutableMap<String, String>, x: String?) {
<!INAPPLICABLE_CANDIDATE!>a[x] = x!!<!>
<!INAPPLICABLE_CANDIDATE!>a[x]<!> = x!!
a[x!!] = x
}