From e141f4f4072a008c251a7b7b2f704a7c4e7d30b8 Mon Sep 17 00:00:00 2001
From: Mikhail Glukhikh <mikhail.glukhikh@jetbrains.com>
Date: Tue, 8 May 2018 18:09:30 +0300
Subject: [PATCH] Convert array to vararg: extract text variants to constants

---
 .../ConvertArrayParameterToVarargIntention.kt      | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertArrayParameterToVarargIntention.kt b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertArrayParameterToVarargIntention.kt
index d05b891f02e..7757f7c6d74 100644
--- a/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertArrayParameterToVarargIntention.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/intentions/ConvertArrayParameterToVarargIntention.kt
@@ -14,7 +14,7 @@ import org.jetbrains.kotlin.psi.*
 import org.jetbrains.kotlin.psi.psiUtil.getChildOfType
 
 class ConvertArrayParameterToVarargIntention : SelfTargetingIntention<KtParameter>(
-    KtParameter::class.java, "Convert to vararg parameter"
+    KtParameter::class.java, DEFAULT_TEXT
 ) {
 
     override fun isApplicableTo(element: KtParameter, caretOffset: Int): Boolean {
@@ -25,7 +25,7 @@ class ConvertArrayParameterToVarargIntention : SelfTargetingIntention<KtParamete
         val type = element.descriptor?.type ?: return false
         return when {
             KotlinBuiltIns.isPrimitiveArray(type) -> {
-                text = "Convert to vararg parameter"
+                text = DEFAULT_TEXT
                 true
             }
             KotlinBuiltIns.isArray(type) -> {
@@ -35,9 +35,9 @@ class ConvertArrayParameterToVarargIntention : SelfTargetingIntention<KtParamete
                     text = if (!typeProjection.hasModifier(KtTokens.OUT_KEYWORD)
                         && !KotlinBuiltIns.isPrimitiveType(element.builtIns.getArrayElementType(type))
                     ) {
-                        "Convert to vararg parameter (may break code)"
+                        BREAKING_TEXT
                     } else {
-                        "Convert to vararg parameter"
+                        DEFAULT_TEXT
                     }
                     true
                 } else {
@@ -59,4 +59,10 @@ class ConvertArrayParameterToVarargIntention : SelfTargetingIntention<KtParamete
         element.addModifier(KtTokens.VARARG_KEYWORD)
     }
 
+    companion object {
+        private const val DEFAULT_TEXT = "Convert to vararg parameter"
+
+        private const val BREAKING_TEXT = "$DEFAULT_TEXT (may break code)"
+    }
+
 }
\ No newline at end of file