azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Test refactor: extract big duration adjustment to a separate test

Browse Source
This commit is contained in:
Ilya Gorbunov
2023-05-23 05:42:58 +02:00
committed by Space Team
parent f8f3862f0c
commit e11ebcadb4
1 changed files with 57 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/stdlib/test/time/TimeMarkTest.kt
+57 -40
View File
@@ -92,6 +92,42 @@ class TimeMarkTest {
markPast1.assertHasPassed(true)
}
fun testAdjustmentBig(timeSource: TimeSource.WithComparableMarks) {
val baseMark = timeSource.markNow()
val longDuration = Long.MAX_VALUE.nanoseconds
val long2Duration = longDuration + 1001.milliseconds
val pastMark = baseMark - longDuration
val futureMark = pastMark + long2Duration
val sameMark = futureMark - (long2Duration - longDuration)
val elapsedMark = timeSource.markNow()
run {
val iterations = 1..100
for (i in iterations) {
val elapsedDiff1 = (sameMark.elapsedNow() - baseMark.elapsedNow()).absoluteValue
val elapsedDiff2 = (baseMark.elapsedNow() - sameMark.elapsedNow()).absoluteValue
// some iterations of this assertion can fail due to an unpredictable delay between subsequent elapsedNow calls
// but if the mark adjustment arithmetic was wrong, all of them will fail
if (maxOf(elapsedDiff1, elapsedDiff2) < 1.milliseconds) break
if (i == iterations.last) fail("$elapsedDiff1, $elapsedDiff2")
}
}
// may not pass exactly for double-based value time marks in JS/WASM due to rounding
// assertEquals(elapsedMark - baseMark, elapsedMark - sameMark, "$elapsedMark; $baseMark; $sameMark")
val elapsedBaseDiff = elapsedMark - baseMark
val elapsedSameDiff = elapsedMark - sameMark
assertTrue((elapsedBaseDiff - elapsedSameDiff).absoluteValue < 1.milliseconds, "elapsedMark=$elapsedMark; baseMark=$baseMark; sameMark=$sameMark")
}
@Test
fun adjustmentBig() {
testAdjustmentBig(TestTimeSource())
for (unit in units) {
testAdjustmentBig(LongTimeSource(unit))
}
}
fun testAdjustmentInfinite(timeSource: TimeSource.WithComparableMarks) {
val baseMark = timeSource.markNow()
val infiniteFutureMark = baseMark + Duration.INFINITE
@@ -122,32 +158,6 @@ class TimeMarkTest {
assertEqualMarks(infiniteMark, infiniteMark - offset)
}
}
val longDuration = Long.MAX_VALUE.nanoseconds
val long2Duration = longDuration + 1001.milliseconds
val pastMark = baseMark - longDuration
val futureMark = pastMark + long2Duration
val sameMark = futureMark - (long2Duration - longDuration)
val elapsedMark = timeSource.markNow()
run {
val iterations = 1..100
for (i in iterations) {
val elapsedDiff1 = (sameMark.elapsedNow() - baseMark.elapsedNow()).absoluteValue
val elapsedDiff2 = (baseMark.elapsedNow() - sameMark.elapsedNow()).absoluteValue
// some iterations of this assertion can fail due to an unpredictable delay between subsequent elapsedNow calls
// but if the mark adjustment arithmetic was wrong, all of them will fail
if (maxOf(elapsedDiff1, elapsedDiff2) < 1.milliseconds) break
if (i == iterations.last) fail("$elapsedDiff1, $elapsedDiff2")
}
}
// TODO: doesn't pass exactly for double-based value time marks in JS/WASM due to rounding
// assertEquals(elapsedMark - baseMark, elapsedMark - sameMark, "$elapsedMark; $baseMark; $sameMark")
val elapsedBaseDiff = elapsedMark - baseMark
val elapsedSameDiff = elapsedMark - sameMark
assertTrue((elapsedBaseDiff - elapsedSameDiff).absoluteValue < 1.milliseconds, "elapsedMark=$elapsedMark; baseMark=$baseMark; sameMark=$sameMark")
}
@Test
@@ -356,23 +366,11 @@ class TimeMarkTest {
}
@Test
fun defaultTimeMarkAdjustmentInfinite() {
testAdjustmentInfinite(TimeSource.Monotonic)
fun defaultTimeMarkAdjustmentBig() {
testAdjustmentBig(TimeSource.Monotonic)
// do the same with specialized methods
val baseMark = TimeSource.Monotonic.markNow()
val infiniteFutureMark = baseMark + Duration.INFINITE
val infinitePastMark = baseMark - Duration.INFINITE
assertEquals(-Duration.INFINITE, infiniteFutureMark.elapsedNow())
assertTrue(infiniteFutureMark.hasNotPassedNow())
assertEquals(Duration.INFINITE, infinitePastMark.elapsedNow())
assertTrue(infinitePastMark.hasPassedNow())
assertFailsWith<IllegalArgumentException> { infiniteFutureMark - Duration.INFINITE }
assertFailsWith<IllegalArgumentException> { infinitePastMark + Duration.INFINITE }
val longDuration = Long.MAX_VALUE.nanoseconds
val long2Duration = longDuration + 1001.milliseconds
@@ -397,6 +395,25 @@ class TimeMarkTest {
assertTrue((elapsedBaseDiff - elapsedSameDiff).absoluteValue < 1.milliseconds, "elapsedMark=$elapsedMark; baseMark=$baseMark; sameMark=$sameMark")
}
@Test
fun defaultTimeMarkAdjustmentInfinite() {
testAdjustmentInfinite(TimeSource.Monotonic)
// do the same with specialized methods
val baseMark = TimeSource.Monotonic.markNow()
val infiniteFutureMark = baseMark + Duration.INFINITE
val infinitePastMark = baseMark - Duration.INFINITE
assertEquals(-Duration.INFINITE, infiniteFutureMark.elapsedNow())
assertTrue(infiniteFutureMark.hasNotPassedNow())
assertEquals(Duration.INFINITE, infinitePastMark.elapsedNow())
assertTrue(infinitePastMark.hasPassedNow())
assertFailsWith<IllegalArgumentException> { infiniteFutureMark - Duration.INFINITE }
assertFailsWith<IllegalArgumentException> { infinitePastMark + Duration.INFINITE }
}
@Test
fun defaultTimeMarkDifferenceAndComparison() {
val baseMark = TimeSource.Monotonic.markNow()