From df8132b84411454edb7108c0f5a0d285d598fc29 Mon Sep 17 00:00:00 2001 From: "Aleksei.Cherepanov" Date: Thu, 20 Apr 2023 12:58:14 +0200 Subject: [PATCH] Revert "[Maven] Filter duplicated source roots to avoid multiple module declarations exception" This reverts commit 07d20c6ee158b0dc31451a579cdbd42851801e54. --- .../pom.xml | 104 ------------------ .../src/main/java/foo/bar/Foo.java | 4 - .../src/main/java/module-info.java | 6 - .../src/main/kotlin/koo/bar/Koo.kt | 4 - .../verify.bsh | 6 - .../kotlin/maven/KotlinCompileMojoBase.java | 3 +- 6 files changed, 1 insertion(+), 126 deletions(-) delete mode 100644 libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/pom.xml delete mode 100644 libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/foo/bar/Foo.java delete mode 100644 libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/module-info.java delete mode 100644 libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/kotlin/koo/bar/Koo.kt delete mode 100644 libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/verify.bsh diff --git a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/pom.xml b/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/pom.xml deleted file mode 100644 index ceedbcdebed..00000000000 --- a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/pom.xml +++ /dev/null @@ -1,104 +0,0 @@ - - - 4.0.0 - - org.jetbrains.kotlin - test-sourceRootsRegisteredSeveralTimes - 1.0-SNAPSHOT - - - - junit - junit - 4.13.1 - - - org.jetbrains.kotlin - kotlin-stdlib - ${kotlin.version} - - - - - - - - true - 17 - 17 - true - UTF-8 - - - - - - kotlin-maven-plugin - org.jetbrains.kotlin - ${kotlin.version} - - - compile - - compile - - - - ${project.basedir}/src/main/kotlin - ${project.basedir}/src/main/java - - - - - test-compile - - test-compile - - - - ${project.basedir}/src/test/kotlin - ${project.basedir}/src/test/java - - - - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.10.1 - - ${java.version} - ${java.version} - - - - default-compile - none - - - default-testCompile - none - - - java-compile - compile - - compile - - - - java-test-compile - test-compile - - testCompile - - - - - - - - diff --git a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/foo/bar/Foo.java b/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/foo/bar/Foo.java deleted file mode 100644 index 4fa5201b7e1..00000000000 --- a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/foo/bar/Foo.java +++ /dev/null @@ -1,4 +0,0 @@ -package foo.bar; - -public class Foo { -} diff --git a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/module-info.java b/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/module-info.java deleted file mode 100644 index cb68639ee71..00000000000 --- a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/java/module-info.java +++ /dev/null @@ -1,6 +0,0 @@ -module foo.bar { - exports foo.bar; - - - requires kotlin.stdlib; -} diff --git a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/kotlin/koo/bar/Koo.kt b/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/kotlin/koo/bar/Koo.kt deleted file mode 100644 index 9b6f13d88b5..00000000000 --- a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/src/main/kotlin/koo/bar/Koo.kt +++ /dev/null @@ -1,4 +0,0 @@ -package koo.bar - -class Koo { -} diff --git a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/verify.bsh b/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/verify.bsh deleted file mode 100644 index 573d8510644..00000000000 --- a/libraries/tools/kotlin-maven-plugin-test/src/it/java9/test-sourceRootsRegisteredSeveralTimes/verify.bsh +++ /dev/null @@ -1,6 +0,0 @@ -import java.io.*; - -File file = new File(basedir, "target/test-sourceRootsRegisteredSeveralTimes-1.0-SNAPSHOT.jar"); -if (!file.exists() || !file.isFile()) { - throw new FileNotFoundException("Could not find generated JAR: " + file); -} diff --git a/libraries/tools/kotlin-maven-plugin/src/main/java/org/jetbrains/kotlin/maven/KotlinCompileMojoBase.java b/libraries/tools/kotlin-maven-plugin/src/main/java/org/jetbrains/kotlin/maven/KotlinCompileMojoBase.java index 70eb59469aa..5ae03c7434e 100644 --- a/libraries/tools/kotlin-maven-plugin/src/main/java/org/jetbrains/kotlin/maven/KotlinCompileMojoBase.java +++ b/libraries/tools/kotlin-maven-plugin/src/main/java/org/jetbrains/kotlin/maven/KotlinCompileMojoBase.java @@ -41,7 +41,6 @@ import java.lang.reflect.Field; import java.util.*; import java.util.regex.Matcher; import java.util.regex.Pattern; -import java.util.stream.Collectors; import static org.jetbrains.kotlin.maven.Util.joinArrays; @@ -83,7 +82,7 @@ public abstract class KotlinCompileMojoBase e List list = new ArrayList<>(); if (sourceDirs != null && !sourceDirs.isEmpty()) list.addAll(sourceDirs); list.addAll(project.getCompileSourceRoots()); - return list.stream().distinct().collect(Collectors.toList()); + return list; } @NotNull