Fixes for 173 after 28.08.17 changes in IDEA (#1271)
* `JarFileSystem.getJarRootForLocalFile` now is nullable in IDEA * Spring-related renamings following ones in IDEA
This commit is contained in:
@@ -175,7 +175,7 @@ class UpdateConfigurationQuickFixTest : LightPlatformCodeInsightFixtureTestCase(
|
|||||||
val editor = NewLibraryEditor()
|
val editor = NewLibraryEditor()
|
||||||
editor.name = "KotlinJavaRuntime"
|
editor.name = "KotlinJavaRuntime"
|
||||||
|
|
||||||
editor.addRoot(JarFileSystem.getInstance().getJarRootForLocalFile(tempVFile), OrderRootType.CLASSES)
|
editor.addRoot(JarFileSystem.getInstance().getJarRootForLocalFile(tempVFile)!!, OrderRootType.CLASSES)
|
||||||
|
|
||||||
ConfigLibraryUtil.addLibrary(editor, model)
|
ConfigLibraryUtil.addLibrary(editor, model)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -37,7 +37,8 @@ import com.intellij.spring.model.SpringModelSearchParameters
|
|||||||
import com.intellij.spring.model.actions.generate.GenerateSpringBeanDependenciesUtil
|
import com.intellij.spring.model.actions.generate.GenerateSpringBeanDependenciesUtil
|
||||||
import com.intellij.spring.model.actions.generate.GenerateSpringBeanDependenciesUtil.*
|
import com.intellij.spring.model.actions.generate.GenerateSpringBeanDependenciesUtil.*
|
||||||
import com.intellij.spring.model.actions.generate.SpringBeanClassMember
|
import com.intellij.spring.model.actions.generate.SpringBeanClassMember
|
||||||
import com.intellij.spring.model.highlighting.SpringConstructorArgResolveUtil
|
import com.intellij.spring.model.highlighting.xml.SpringConstructorArgResolveUtil
|
||||||
|
|
||||||
import com.intellij.spring.model.utils.SpringBeanCoreUtils
|
import com.intellij.spring.model.utils.SpringBeanCoreUtils
|
||||||
import com.intellij.spring.model.utils.SpringBeanUtils
|
import com.intellij.spring.model.utils.SpringBeanUtils
|
||||||
import com.intellij.spring.model.utils.SpringModelSearchers
|
import com.intellij.spring.model.utils.SpringModelSearchers
|
||||||
|
|||||||
+2
-1
@@ -18,7 +18,8 @@ package org.jetbrains.kotlin.idea.spring.inspections
|
|||||||
|
|
||||||
import com.intellij.codeInspection.ProblemsHolder
|
import com.intellij.codeInspection.ProblemsHolder
|
||||||
import com.intellij.psi.PsiElementVisitor
|
import com.intellij.psi.PsiElementVisitor
|
||||||
import com.intellij.spring.model.highlighting.SpringJavaAutowiredMembersInspection
|
import com.intellij.spring.model.highlighting.autowire.SpringJavaAutowiredMembersInspection
|
||||||
|
|
||||||
import org.jetbrains.kotlin.asJava.toLightClass
|
import org.jetbrains.kotlin.asJava.toLightClass
|
||||||
import org.jetbrains.kotlin.idea.inspections.AbstractKotlinInspection
|
import org.jetbrains.kotlin.idea.inspections.AbstractKotlinInspection
|
||||||
import org.jetbrains.kotlin.idea.inspections.registerWithElementsUnwrapped
|
import org.jetbrains.kotlin.idea.inspections.registerWithElementsUnwrapped
|
||||||
|
|||||||
+8
-8
@@ -16,8 +16,8 @@ import com.intellij.spring.CommonSpringModel
|
|||||||
import com.intellij.spring.SpringBundle
|
import com.intellij.spring.SpringBundle
|
||||||
import com.intellij.spring.model.SpringBeanPointer
|
import com.intellij.spring.model.SpringBeanPointer
|
||||||
import com.intellij.spring.model.converters.SpringConverterUtil
|
import com.intellij.spring.model.converters.SpringConverterUtil
|
||||||
import com.intellij.spring.model.highlighting.SpringAutowireUtil
|
import com.intellij.spring.model.highlighting.autowire.SpringJavaInjectionPointsAutowiringInspection
|
||||||
import com.intellij.spring.model.highlighting.SpringJavaAutowiringInspection
|
import com.intellij.spring.model.utils.SpringAutowireUtil
|
||||||
import org.jetbrains.kotlin.asJava.elements.KtLightField
|
import org.jetbrains.kotlin.asJava.elements.KtLightField
|
||||||
import org.jetbrains.kotlin.asJava.elements.KtLightMethod
|
import org.jetbrains.kotlin.asJava.elements.KtLightMethod
|
||||||
import org.jetbrains.kotlin.asJava.toLightClass
|
import org.jetbrains.kotlin.asJava.toLightClass
|
||||||
@@ -30,7 +30,7 @@ import org.jetbrains.kotlin.psi.*
|
|||||||
import org.jetbrains.kotlin.psi.psiUtil.*
|
import org.jetbrains.kotlin.psi.psiUtil.*
|
||||||
|
|
||||||
class SpringKotlinAutowiringInspection : AbstractKotlinInspection() {
|
class SpringKotlinAutowiringInspection : AbstractKotlinInspection() {
|
||||||
// Based on SpringJavaAutowiringInspection.AddSpringBeanQualifierFix
|
// Based on SpringJavaInjectionPointsAutowiringInspection.AddSpringBeanQualifierFix
|
||||||
class AddQualifierFix(
|
class AddQualifierFix(
|
||||||
modifierListOwner: KtModifierListOwner,
|
modifierListOwner: KtModifierListOwner,
|
||||||
private val beanPointers: Collection<SpringBeanPointer<*>>,
|
private val beanPointers: Collection<SpringBeanPointer<*>>,
|
||||||
@@ -86,16 +86,16 @@ class SpringKotlinAutowiringInspection : AbstractKotlinInspection() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private val javaInspection by lazy { SpringJavaAutowiringInspection() }
|
private val javaInspection by lazy { SpringJavaInjectionPointsAutowiringInspection() }
|
||||||
|
|
||||||
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean) = object : KtVisitorVoid() {
|
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean) = object : KtVisitorVoid() {
|
||||||
// TODO: SpringJavaAutowiringInspection.checkAutowiredMethod() is not accessible here
|
// TODO: SpringJavaInjectionPointsAutowiringInspection.checkAutowiredMethod() is not accessible here
|
||||||
private fun checkAutowiredMethod(psiMethod: PsiMethod, holder: ProblemsHolder, springModel: CommonSpringModel, required: Boolean) {
|
private fun checkAutowiredMethod(psiMethod: PsiMethod, holder: ProblemsHolder, springModel: CommonSpringModel, required: Boolean) {
|
||||||
val resourceAnnotation = SpringAutowireUtil.getResourceAnnotation(psiMethod)
|
val resourceAnnotation = SpringAutowireUtil.getResourceAnnotation(psiMethod)
|
||||||
when {
|
when {
|
||||||
resourceAnnotation != null -> {
|
resourceAnnotation != null -> {
|
||||||
val propertyType = PropertyUtil.getPropertyType(psiMethod) ?: return
|
val propertyType = PropertyUtil.getPropertyType(psiMethod) ?: return
|
||||||
SpringJavaAutowiringInspection.checkAutowiredPsiMember(psiMethod, propertyType, holder, springModel, required)
|
SpringJavaInjectionPointsAutowiringInspection.checkInjectionPoint(psiMethod, propertyType, holder, springModel, required)
|
||||||
}
|
}
|
||||||
psiMethod.parameterList.parametersCount == 0 &&
|
psiMethod.parameterList.parametersCount == 0 &&
|
||||||
SpringAutowireUtil.isAutowiredByAnnotation(psiMethod) -> {
|
SpringAutowireUtil.isAutowiredByAnnotation(psiMethod) -> {
|
||||||
@@ -107,7 +107,7 @@ class SpringKotlinAutowiringInspection : AbstractKotlinInspection() {
|
|||||||
else -> {
|
else -> {
|
||||||
for (parameter in psiMethod.parameterList.parameters) {
|
for (parameter in psiMethod.parameterList.parameters) {
|
||||||
if (AnnotationUtil.isAnnotated(parameter, "org.springframework.beans.factory.annotation.Value", true)) continue
|
if (AnnotationUtil.isAnnotated(parameter, "org.springframework.beans.factory.annotation.Value", true)) continue
|
||||||
SpringJavaAutowiringInspection.checkAutowiredPsiMember(parameter, parameter.type, holder, springModel, required)
|
SpringJavaInjectionPointsAutowiringInspection.checkInjectionPoint(parameter, parameter.type, holder, springModel, required)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -153,7 +153,7 @@ class SpringKotlinAutowiringInspection : AbstractKotlinInspection() {
|
|||||||
private fun PsiField.processLightField() {
|
private fun PsiField.processLightField() {
|
||||||
if (!SpringAutowireUtil.isAutowiredByAnnotation(this)) return
|
if (!SpringAutowireUtil.isAutowiredByAnnotation(this)) return
|
||||||
processLightMember { holder, model, required ->
|
processLightMember { holder, model, required ->
|
||||||
SpringJavaAutowiringInspection.checkAutowiredPsiMember(this, type, holder, model, required)
|
SpringJavaInjectionPointsAutowiringInspection.checkInjectionPoint(this, type, holder, model, required)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -20,8 +20,8 @@ import com.intellij.codeInsight.lookup.LookupElement
|
|||||||
import com.intellij.psi.*
|
import com.intellij.psi.*
|
||||||
import com.intellij.spring.model.DefaultSpringBeanQualifier
|
import com.intellij.spring.model.DefaultSpringBeanQualifier
|
||||||
import com.intellij.spring.model.converters.SpringConverterUtil
|
import com.intellij.spring.model.converters.SpringConverterUtil
|
||||||
import com.intellij.spring.model.highlighting.SpringAutowireUtil
|
|
||||||
import com.intellij.spring.model.jam.qualifiers.SpringJamQualifier
|
import com.intellij.spring.model.jam.qualifiers.SpringJamQualifier
|
||||||
|
import com.intellij.spring.model.utils.SpringAutowireUtil
|
||||||
import com.intellij.spring.model.utils.SpringModelSearchers
|
import com.intellij.spring.model.utils.SpringModelSearchers
|
||||||
import com.intellij.spring.references.SpringQualifierReference
|
import com.intellij.spring.references.SpringQualifierReference
|
||||||
import org.jetbrains.kotlin.asJava.elements.KtLightElement
|
import org.jetbrains.kotlin.asJava.elements.KtLightElement
|
||||||
|
|||||||
Reference in New Issue
Block a user