MoveLambdaOutsideParentheses: intention -> inspection #KT-21413 Fixed

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.MoveLambdaOutsideParenthesesInspection

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/ambigousOverload.kt

@@ -0,0 +1,12 @@
+// IS_AVAILABLE: true
+// ERROR: None of the following functions can be called with the arguments supplied: <br>public fun bar(a: Int = ..., f: (Int) -> Int): Unit defined in root package in file ambigousOverload.kt<br>public fun bar(a: Int, b: Int, f: (Int) -> Int): Unit defined in root package in file ambigousOverload.kt
+// ERROR: Unresolved reference: it
+// SKIP_ERRORS_AFTER
+
+fun foo() {
+    bar(<caret>{ it })
+}
+
+fun bar(a: Int = 0, f: (Int) -> Int) { }
+fun bar(a: Int, b: Int, f: (Int) -> Int) { }
+

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/ambigousOverload.kt.after

@@ -0,0 +1,12 @@
+// IS_AVAILABLE: true
+// ERROR: None of the following functions can be called with the arguments supplied: <br>public fun bar(a: Int = ..., f: (Int) -> Int): Unit defined in root package in file ambigousOverload.kt<br>public fun bar(a: Int, b: Int, f: (Int) -> Int): Unit defined in root package in file ambigousOverload.kt
+// ERROR: Unresolved reference: it
+// SKIP_ERRORS_AFTER
+
+fun foo() {
+    bar<caret> { it }
+}
+
+fun bar(a: Int = 0, f: (Int) -> Int) { }
+fun bar(a: Int, b: Int, f: (Int) -> Int) { }
+

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/functionalValueCall.kt

@@ -0,0 +1,3 @@
+fun foo(p: (Int, () -> Int) -> Unit) {
+    p(1, <caret>{ 2 })
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/functionalValueCall.kt.after

@@ -0,0 +1,3 @@
+fun foo(p: (Int, () -> Int) -> Unit) {
+    p(1<caret>) { 2 }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/inapplicable1.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun foo() {
+    bar() <caret>{ it }
+}
+
+fun bar(b: (Int) -> Int) {
+    b(1)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/inapplicable2.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+fun <T> doSomething(a: T) {}
+
+fun foo(x: Int) {
+    if (x == 1) <caret>{
+        doSomething(x)
+    }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/inapplicable3.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+fun <T> doSomething(a: T) {}
+
+fun foo(x: Int) {
+    if (x == 1) {
+        doSomething(x)
+    }
+}
+
+fun x() <caret>{ doSomething("x") }

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/inapplicableAlreadyHasFunctionLiteral.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+fun foo() {
+    bar(<caret>{ it }) {it}
+}
+
+fun bar(p1: (Int) -> Int, p2: (Int) -> Int) { }

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/inapplicableOptionalParametersAfter.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+fun foo() {
+    bar(<caret>{ it })
+}
+
+fun bar(b: (Int) -> Int, option: Int = 0) { }

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/labeledLambda.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2, <caret>l@{ it })
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/labeledLambda.kt.after

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2) l@{ it }
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar({
+        <caret>val a = foo(1, 2)
+    })
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas.kt.after

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar {
+        val a = foo(1, 2)
+    }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas2.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(x: Int, f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar(1, {
+        <caret>val a = foo(1, 2)
+    })
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas2.kt.after

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(x: Int, f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar(1) {
+        val a = foo(1, 2)
+    }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas3.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(a: Int, b: Int, f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar(1, 2, /* , , */ {
+        <caret>val a = foo(1, 2)
+    })
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/lambdaWithCommas3.kt.after

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: true
+fun bar(a: Int, b: Int, f: () -> Unit) {}
+fun foo(a: Int, b: Int) = 2
+
+fun test() {
+    bar(1, 2 /* , , */) {
+        val a = foo(1, 2)
+    }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda1.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2, <caret>{ it })
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda1.kt.after

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2) { it }
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda2.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(a = 2, b = {<caret> it })
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda2.kt.after

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(a = 2) { it }
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda3.kt

@@ -0,0 +1,12 @@
+// IS_APPLICABLE: true
+// ERROR: Type mismatch: inferred type is () -> ??? but Int was expected
+// ERROR: No value passed for parameter 'b'
+// ERROR: Unresolved reference: it
+// SKIP_ERRORS_AFTER
+fun foo() {
+    bar({ it <caret>})
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda3.kt.after

@@ -0,0 +1,12 @@
+// IS_APPLICABLE: true
+// ERROR: Type mismatch: inferred type is () -> ??? but Int was expected
+// ERROR: No value passed for parameter 'b'
+// ERROR: Unresolved reference: it
+// SKIP_ERRORS_AFTER
+fun foo() {
+    bar<caret> { it }
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda4.kt

@@ -0,0 +1,11 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2, {
+        val x = 3
+        it * x
+    <caret>})
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda4.kt.after

@@ -0,0 +1,11 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(2) {
+        val x = 3
+        it * x
+    }
+}
+
+fun bar(a: Int, b: (Int) -> Int) {
+    b(a)
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda5.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(name1 = 3, name2 = 2, name3 = 1, <caret>name4 = { it })
+}
+
+fun bar(name1: Int, name2: Int, name3: Int, name4: (Int) -> Int) : Int {
+    return name4(name1) + name2 + name3
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda5.kt.after

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(name1 = 3, name2 = 2, name3 = 1) { it }
+}
+
+fun bar(name1: Int, name2: Int, name3: Int, name4: (Int) -> Int) : Int {
+    return name4(name1) + name2 + name3
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda6.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(3, 2, 1, { it <caret>})
+}
+
+fun bar(name1: Int, name2: Int, name3: Int, name4: (Int) -> Int) : Int {
+    return name4(name1) + name2 + name3
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/moveLambda6.kt.after

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: true
+fun foo() {
+    bar(3, 2, 1) { it }
+}
+
+fun bar(name1: Int, name2: Int, name3: Int, name4: (Int) -> Int) : Int {
+    return name4(name1) + name2 + name3
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/noTwoConsequentLambdas.kt

@@ -0,0 +1,7 @@
+fun bar() {
+    foo { "one" } (<caret>{ "two" })
+}
+
+fun foo(a: () -> String): (() -> String) -> Unit {
+    return { }
+}

idea/testData/inspectionsLocal/moveLambdaOutsideParentheses/noTwoConsequentLambdas.kt.after

@@ -0,0 +1,7 @@
+fun bar() {
+    foo { "one" } () { "two" }
+}
+
+fun foo(a: () -> String): (() -> String) -> Unit {
+    return { }
+}