[FE] Prohibit missed MUST_BE_INITIALIZED when there is no primary constructor

^KT-58472 Fixed
Review: https://jetbrains.team/p/kt/reviews/9967

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/implicitPrimaryConstructor_errorAnyway.kt

@@ -0,0 +1,11 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneInheritedSecondary_mustBeInitializedError.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Base(x: Int)
+class Foo : Base {
+    constructor() : super(1)
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneInheritedSecondary_mustBeInitializedWarning.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Base(x: Int)
+class Foo : Base {
+    constructor() : super(1)
+    <!MUST_BE_INITIALIZED_WARNING!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_deferredInitInSecondary_mustBeInitializedError.kt

@@ -0,0 +1,11 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    constructor() {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_deferredInitInSecondary_mustBeInitializedWarning.kt

@@ -0,0 +1,11 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    <!MUST_BE_INITIALIZED_WARNING!>var x: String<!>
+        set(value) {}
+
+    constructor() {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_mustBeInitializedError.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    constructor()
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_mustBeInitializedWarning.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    constructor()
+    <!MUST_BE_INITIALIZED_WARNING!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openValError_mustBeInitializedError.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor, +ProhibitOpenValDeferredInitialization
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT!>open val x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openValError_mustBeInitializedWarning.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor, +ProhibitOpenValDeferredInitialization
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT_WARNING!>open val x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openValWarning_mustBeInitializedError.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor, -ProhibitOpenValDeferredInitialization
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT_WARNING!>open val x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openValWarning_mustBeInitializedWarning.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor, -ProhibitOpenValDeferredInitialization
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT_WARNING!>open val x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openVar_mustBeInitializedError.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT!>open var x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_oneSecondary_openVar_mustBeInitializedWarning.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+open class Foo {
+    constructor()
+
+    <!MUST_BE_INITIALIZED_OR_FINAL_OR_ABSTRACT_WARNING!>open var x: String<!>
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_partialDeferredInitInSecondary_errorAnyway.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+class Foo {
+    <!MUST_BE_INITIALIZED!>var foo: Int<!>
+        set(value) {}
+
+    constructor() {
+        if (1 != 1) {
+            foo = 1
+        }
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_partialDeferredInitInTwoSecondaries_errorAnyway.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+class Foo {
+    <!MUST_BE_INITIALIZED!>var foo: Int<!>
+        set(value) {}
+
+    constructor(x: Int) {}
+    constructor() {
+        foo = 1
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_twoSecondary_mustBeInitializedError.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !LANGUAGE:+ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    constructor()
+    constructor(x: Int)
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/noPrimary_twoSecondary_mustBeInitializedWarning.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo {
+    constructor()
+    constructor(x: Int)
+    <!MUST_BE_INITIALIZED_WARNING!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/backingField/prohibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor/onePrimary_oneSecondary_errorAnyway.kt

@@ -0,0 +1,13 @@
+// FIR_IDENTICAL
+// !LANGUAGE:-ProhibitMissedMustBeInitializedWhenThereIsNoPrimaryConstructor
+// !DIAGNOSTICS: -DEBUG_INFO_LEAKING_THIS
+class Foo() {
+    constructor(x: Int) : this()
+
+    <!MUST_BE_INITIALIZED!>var x: String<!>
+        set(value) {}
+
+    init {
+        x = ""
+    }
+}

compiler/testData/diagnostics/tests/constructorConsistency/inspection.fir.kt

@@ -33,8 +33,8 @@ class SecondDerived : Second() {
     override fun foo() = y
 }
 
-open class Third {
-    open var x: String
+abstract class Third {
+    abstract var x: String
 
     constructor() {
         x = "X" // Non-final property access

compiler/testData/diagnostics/tests/constructorConsistency/inspection.kt

@@ -33,8 +33,8 @@ class SecondDerived : Second() {
     override fun foo() = y
 }
 
-open class Third {
-    open var x: String
+abstract class Third {
+    abstract var x: String
 
     constructor() {
         <!DEBUG_INFO_LEAKING_THIS!>x<!> = "X" // Non-final property access

compiler/testData/diagnostics/tests/constructorConsistency/inspection.txt

@@ -42,9 +42,9 @@ public final class SecondDerived : Second {
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
 }
 
-public open class Third {
+public abstract class Third {
     public constructor Third()
-    public open var x: kotlin.String
+    public abstract var x: kotlin.String
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
     public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String

compiler/testData/diagnostics/tests/constructorConsistency/openProperty.fir.kt

@@ -1,7 +1,7 @@
-open class Base {
-    open var x: Int
+abstract class Base {
+    abstract var x: Int
 
-    open var y: Int
+    abstract var y: Int
 
     constructor() {
         x = 42
@@ -9,6 +9,5 @@ open class Base {
         val temp = this.x
         this.x = y
         y = temp
-
     }
 }

compiler/testData/diagnostics/tests/constructorConsistency/openProperty.kt

@@ -1,7 +1,7 @@
-open class Base {
-    open var x: Int
+abstract class Base {
+    abstract var x: Int
 
-    open var y: Int
+    abstract var y: Int
 
     constructor() {
         <!DEBUG_INFO_LEAKING_THIS!>x<!> = 42
@@ -9,6 +9,5 @@ open class Base {
         val temp = this.<!DEBUG_INFO_LEAKING_THIS!>x<!>
         this.<!DEBUG_INFO_LEAKING_THIS!>x<!> = <!DEBUG_INFO_LEAKING_THIS!>y<!>
         <!DEBUG_INFO_LEAKING_THIS!>y<!> = temp
-
     }
 }

compiler/testData/diagnostics/tests/constructorConsistency/openProperty.txt

@@ -1,9 +1,9 @@
 package
 
-public open class Base {
+public abstract class Base {
     public constructor Base()
-    public open var x: kotlin.Int
-    public open var y: kotlin.Int
+    public abstract var x: kotlin.Int
+    public abstract var y: kotlin.Int
     public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
     public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
     public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String