Simplify loop building by encoding open/closed bound information in the

HeaderInfo object, and modifying the operator in the loop condition.

The "additional emptiness condition" is no longer necessary with this.
The open/closed property was removed from HeaderInfo in an earlier
commit, but bringing it back in to simplify the loop building makes
more sense.

Also expanded tests for evaluation order of range bounds.

compiler/testData/codegen/box/ranges/evaluationOrder/forInDownToEvaluationOrder.kt

@@ -0,0 +1,21 @@
+// KJS_WITH_FULL_RUNTIME
+// WITH_RUNTIME
+import kotlin.test.*
+
+val log = StringBuilder()
+
+fun logged(message: String, value: Int) =
+    value.also { log.append(message) }
+
+fun box(): String {
+    var sum = 0
+    for (i in logged("start;", 4) downTo logged("end;", 1)) {
+        sum = sum * 10 + i
+    }
+
+    assertEquals(4321, sum)
+
+    assertEquals("start;end;", log.toString())
+
+    return "OK"
+}

compiler/testData/codegen/box/ranges/evaluationOrder/forInRangeLiteralEvaluationOrder.kt

@@ -5,15 +5,15 @@ import kotlin.test.*
 val log = StringBuilder()
 
 fun logged(message: String, value: Int) =
-        value.also { log.append(message) }
+    value.also { log.append(message) }
 
 fun box(): String {
-    var s = 0
-    for (i in (logged("start;", 1) .. logged("end;", 2)).reversed()) {
-        s += i
+    var sum = 0
+    for (i in logged("start;", 1)..logged("end;", 4)) {
+        sum = sum * 10 + i
     }
 
-    assertEquals(3, s)
+    assertEquals(1234, sum)
 
     assertEquals("start;end;", log.toString())
 

compiler/testData/codegen/box/ranges/evaluationOrder/forInReversedDownToEvaluationOrder.kt

@@ -5,15 +5,15 @@ import kotlin.test.*
 val log = StringBuilder()
 
 fun logged(message: String, value: Int) =
-        value.also { log.append(message) }
+    value.also { log.append(message) }
 
 fun box(): String {
-    var s = 0
-    for (i in (logged("start;", 2) downTo logged("end;", 1)).reversed()) {
-        s += i
+    var sum = 0
+    for (i in (logged("start;", 4) downTo logged("end;", 1)).reversed()) {
+        sum = sum * 10 + i
     }
 
-    assertEquals(3, s)
+    assertEquals(1234, sum)
 
     assertEquals("start;end;", log.toString())
 

compiler/testData/codegen/box/ranges/evaluationOrder/forInReversedRangeLiteralEvaluationOrder.kt

@@ -0,0 +1,21 @@
+// KJS_WITH_FULL_RUNTIME
+// WITH_RUNTIME
+import kotlin.test.*
+
+val log = StringBuilder()
+
+fun logged(message: String, value: Int) =
+    value.also { log.append(message) }
+
+fun box(): String {
+    var sum = 0
+    for (i in (logged("start;", 1)..logged("end;", 4)).reversed()) {
+        sum = sum * 10 + i
+    }
+
+    assertEquals(4321, sum)
+
+    assertEquals("start;end;", log.toString())
+
+    return "OK"
+}

compiler/testData/codegen/box/ranges/evaluationOrder/forInReversedUntilEvaluationOrder.kt

@@ -5,15 +5,15 @@ import kotlin.test.*
 val log = StringBuilder()
 
 fun logged(message: String, value: Int) =
-        value.also { log.append(message) }
+    value.also { log.append(message) }
 
 fun box(): String {
-    var s = 0
-    for (i in (logged("start;", 1) until logged("end;", 3)).reversed()) {
-        s += i
+    var sum = 0
+    for (i in (logged("start;", 1) until logged("end;", 5)).reversed()) {
+        sum = sum * 10 + i
     }
 
-    assertEquals(3, s)
+    assertEquals(4321, sum)
 
     assertEquals("start;end;", log.toString())
 

compiler/testData/codegen/box/ranges/evaluationOrder/forInUntilEvaluationOrder.kt

@@ -0,0 +1,21 @@
+// KJS_WITH_FULL_RUNTIME
+// WITH_RUNTIME
+import kotlin.test.*
+
+val log = StringBuilder()
+
+fun logged(message: String, value: Int) =
+    value.also { log.append(message) }
+
+fun box(): String {
+    var sum = 0
+    for (i in logged("start;", 1) until logged("end;", 5)) {
+        sum = sum * 10 + i
+    }
+
+    assertEquals(1234, sum)
+
+    assertEquals("start;end;", log.toString())
+
+    return "OK"
+}