azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop KFunctionFromReferenceImpl, make FunctionImpl an interface

Browse Source 
23 invokes in KFunctionFromReferenceImpl (and consequently, in FunctionImpl)
were needed before 1576160390: a wrapped function
reference must have had the necessary invoke to be called as an instance of a
specific function type. After 1576160390, this is
not needed anymore because KFunctionFromReferenceImpl is now an internal
implementation detail of reflection, and no invoke is ever called on it.
This commit is contained in:
Alexander Udalov
2016-09-07 11:43:49 +03:00
parent fbfa61da5d
commit dcc66a6400
12 changed files with 48 additions and 322 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/compilingEvaluator.kt
+4 -4
View File
@@ -65,11 +65,11 @@ private fun defineClasses(
}
}
// The order is relevant here: if we load Lambda first instead, during the definition of Lambda the class loader will look for
// its superclasses and will try to load FunctionImpl itself. It will succeed, probably with the help of some parent class loader,
// and the subsequent attempt to define the patched version of FunctionImpl will fail with LinkageError (cannot redefine class)
// This list should contain all superclasses of lambda classes.
// The order is relevant here: if we load Lambda first instead, during the definition of Lambda the class loader will try
// to load its superclass. It will succeed, probably with the help of some parent class loader, and the subsequent attempt to define
// the patched version of that superclass will fail with LinkageError (cannot redefine class)
private val LAMBDA_SUPERCLASSES = listOf(
ClassBytes("kotlin.jvm.internal.FunctionImpl"),
ClassBytes("kotlin.jvm.internal.Lambda")
)