Use smartcast info that related to call in change signature quick fix

There is an inconsistency on how we record smartcasts in old and new
 inference, but we definitely should use all possible information about
 smartcasts in quick-fixes

 #KT-25144 Fixed

idea/src/org/jetbrains/kotlin/idea/quickfix/AddFunctionParametersFix.kt

@@ -31,6 +31,7 @@ import org.jetbrains.kotlin.psi.KtFile
 import org.jetbrains.kotlin.psi.ValueArgument
 import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
 import org.jetbrains.kotlin.resolve.BindingContext
+import org.jetbrains.kotlin.resolve.calls.callUtil.getCall
 import org.jetbrains.kotlin.resolve.descriptorUtil.builtIns
 import org.jetbrains.kotlin.types.KotlinType
 import org.jetbrains.kotlin.types.checker.KotlinTypeChecker
@@ -89,6 +90,7 @@ class AddFunctionParametersFix(
             override fun configure(originalDescriptor: KotlinMethodDescriptor): KotlinMethodDescriptor {
                 return originalDescriptor.modify {
                     val callElement = callElement ?: return@modify
+                    val call = callElement.getCall(callElement.analyze()) ?: return@modify
                     val parameters = functionDescriptor.valueParameters
                     val arguments = callElement.valueArguments
                     val validator = CollectingNameValidator()
@@ -101,7 +103,8 @@ class AddFunctionParametersFix(
                             validator.addName(parameters[i].name.asString())
                             val argumentType = expression?.let {
                                 val bindingContext = it.analyze()
-                                bindingContext[BindingContext.SMARTCAST, it]?.defaultType ?: bindingContext.getType(it)
+                                val smartCasts = bindingContext[BindingContext.SMARTCAST, it]
+                                smartCasts?.defaultType ?: smartCasts?.type(call) ?: bindingContext.getType(it)
                             }
                             val parameterType = parameters[i].type
 

idea/testData/quickfix/changeSignature/addFunctionParameterWithSmartcastedArgument.kt

@@ -0,0 +1,14 @@
+// "Change the signature of function 'doSmthWithChild'" "true"
+// DISABLE-ERRORS
+// COMPILER_ARGUMENTS: -XXLanguage:+NewInference
+
+interface Parent
+interface Child : Parent
+
+fun doSmthWithChild(a: Child) {}
+
+fun foobar(parent: Parent) {
+    if (parent is Child) {
+        doSmthWithChild(parent, <caret>123)
+    }
+}

idea/testData/quickfix/changeSignature/addFunctionParameterWithSmartcastedArgument.kt.after

@@ -0,0 +1,14 @@
+// "Change the signature of function 'doSmthWithChild'" "true"
+// DISABLE-ERRORS
+// COMPILER_ARGUMENTS: -XXLanguage:+NewInference
+
+interface Parent
+interface Child : Parent
+
+fun doSmthWithChild(a: Child, i: Int) {}
+
+fun foobar(parent: Parent) {
+    if (parent is Child) {
+        doSmthWithChild(parent, <caret>123)
+    }
+}

idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixTestGenerated.java

@@ -1537,6 +1537,11 @@ public class QuickFixTestGenerated extends AbstractQuickFixTest {
             runTest("idea/testData/quickfix/changeSignature/addFunctionParameterWithSmartCast.kt");
         }
 
+        @TestMetadata("addFunctionParameterWithSmartcastedArgument.kt")
+        public void testAddFunctionParameterWithSmartcastedArgument() throws Exception {
+            runTest("idea/testData/quickfix/changeSignature/addFunctionParameterWithSmartcastedArgument.kt");
+        }
+
         @TestMetadata("addNothingReturnType.kt")
         public void testAddNothingReturnType() throws Exception {
             runTest("idea/testData/quickfix/changeSignature/addNothingReturnType.kt");