From d98da87278910978555d52fa8802cedafda11e62 Mon Sep 17 00:00:00 2001 From: Ilya Kirillov Date: Thu, 21 Sep 2023 20:19:46 +0200 Subject: [PATCH] [FIR] Render dot-separated FQNs instead of slash-separated ones in diagnostics ^KT-62030 fixed --- ...egatedConstructorCall_super_unresolved.txt | 2 +- .../multipleCandidates/ambiguous.txt | 6 +++--- .../multipleCandidates/implicitInvoke.txt | 4 ++-- .../implicitInvokeWithReceiver.txt | 2 +- .../delegatedConstructorInapplicable.txt | 2 +- .../testData/contextCollector/enumValue.txt | 4 ++-- .../contextCollector/extensionFunction.txt | 2 +- .../contextCollector/extensionLambdas.txt | 4 ++-- .../contextCollector/innerClasses.txt | 4 ++-- .../testData/contextCollector/localClass.txt | 4 ++-- .../contextCollector/nestedClasses.txt | 2 +- .../propertyDelegateInitializer.txt | 4 ++-- .../scripts/insideClassMember.txt | 2 +- .../scripts/insideTopLevelFunction.txt | 2 +- .../contextCollector/scripts/topLevel.txt | 2 +- .../testData/contextCollector/simple.txt | 2 +- .../contextCollector/smartCasts/afterLoop.txt | 2 +- .../contextCollector/smartCasts/andRight.txt | 4 ++-- .../contextCollector/smartCasts/argument.txt | 2 +- .../smartCasts/argumentAsReceiver.txt | 2 +- .../smartCasts/dispatchReceiver.txt | 2 +- .../smartCasts/extensionReceiver.txt | 2 +- .../insideLetOnNullableReceiver.txt | 4 ++-- .../smartCasts/insideLoop.txt | 2 +- .../smartCasts/plainCheck.txt | 2 +- .../contextCollector/smartCasts/require.txt | 2 +- .../contextCollector/smartCasts/when.txt | 2 +- .../declaredInClass_fromInner_typeBound.txt | 4 ++-- ...laredInClass_fromInner_typeRefInMember.txt | 6 +++--- .../declaredInClass_fromNested_typeBound.txt | 4 ++-- ...aredInClass_fromNested_typeRefInMember.txt | 2 +- .../dependentCopy/classBodyScript.context.txt | 2 +- .../dependentCopy/classScript.context.txt | 2 +- .../moreStatementsInCopy.context.txt | 2 +- .../testData/dependentCopy/script.context.txt | 2 +- .../dependentCopy/scriptFunction.context.txt | 2 +- .../scriptInsideLastStatement.context.txt | 2 +- .../scriptLastStatement.context.txt | 2 +- .../scriptLastStatementCall.context.txt | 2 +- .../dependentCopy/scriptStatement.context.txt | 2 +- .../scriptStatementCall.context.txt | 2 +- .../invoke/threeReceiversCorrect.kt | 2 +- .../problems/argumentTypeMismatch.kt | 2 +- .../renderer/ConeIdRendererForDiagnostics.kt | 19 +++++++++++++++++++ .../ConeTypeRendererForReadability.kt | 4 ++-- .../kotlin/fir/types/ConeTypeUtils.kt | 7 ++----- .../testData/cli/jvm/compatqualDefault.out | 2 +- .../testData/cli/jvm/compatqualEnable.out | 2 +- .../cli/jvm/conflictingProjection.out | 2 +- .../firFriendlyErrorIfNoJdkOptionIsSet.out | 2 +- compiler/testData/cli/jvm/firLightTreeOff.out | 2 +- compiler/testData/cli/jvm/firLightTreeOn.out | 2 +- .../cli/jvm/instanceAccessBeforeSuperCall.out | 2 +- compiler/testData/cli/jvm/jspecifyDefault.out | 2 +- compiler/testData/cli/jvm/jspecifyStrict.out | 2 +- .../cli/jvm/jsr305DefaultMigration.out | 2 +- .../cli/jvm/jsr305DeprecatedEnable.out | 2 +- .../testData/cli/jvm/jsr305FqNameIgnore.out | 2 +- .../testData/cli/jvm/jsr305FqNameStrict.out | 4 ++-- .../cli/jvm/jsr305MigrationDefault.out | 2 +- compiler/testData/cli/jvm/jsr305Strict.out | 2 +- .../cli/jvm/nullabilityAnnotations.out | 2 +- .../cli/jvm/reportInternalDiagnosticNames.out | 2 +- .../cli/jvm/werrorWithExplicitError.out | 2 +- .../tests/PropertyInitializers.fir.kt | 2 +- .../annotationRenderingInTypes.fir.kt | 6 +++--- .../rendering/memberProjectedOut.fir.kt | 2 +- .../typeMismatchDueToTypeProjections.fir.kt | 2 +- ...ParameterToUnitImplicitLiteralsCase.fir.kt | 4 ++-- ...hReceiverToUnitImplicitLiteralsCase.fir.kt | 4 ++-- ...leNothingNullLiteralMaterializeCase.fir.kt | 2 +- .../kt45461.fir.diag.txt | 2 +- .../kt45461_12.fir.diag.txt | 2 +- .../kt45461_2.fir.diag.txt | 4 ++-- .../kt45461_25.fir.diag.txt | 6 +++--- .../emptyIntersectionTypes/kt45461_25.fir.kt | 2 +- .../kt45461_26.fir.diag.txt | 4 ++-- .../kt45461_5.fir.diag.txt | 2 +- .../kt48765.fir.diag.txt | 6 +++--- .../kt49661.fir.diag.txt | 2 +- ...terWithKotlinNullableWarnings.fir.diag.txt | 4 ++-- .../tests/nullableTypes/kt58844.fir.kt | 4 ++-- .../tests/regressions/kt251.fir.kt | 2 +- .../specialConstructions/elvisAsCall.fir.kt | 2 +- .../exclExclAsCall.fir.kt | 2 +- ...ienPropertyFromInvisibleClass.fir.diag.txt | 4 ++-- ...cTypeArgumentInsteadOfTypeParameter.fir.kt | 2 +- .../upperBoundViolated2.fir.diag.txt | 2 +- .../build.log.expected | 4 ++-- .../diagnostics/localVariables.fir.diag.txt | 6 +++--- .../methodDeclaration.fir.diag.txt | 2 +- .../diagnostics/noAnnotation.fir.diag.txt | 8 ++++---- 92 files changed, 146 insertions(+), 130 deletions(-) create mode 100644 compiler/fir/cones/src/org/jetbrains/kotlin/fir/renderer/ConeIdRendererForDiagnostics.kt diff --git a/analysis/analysis-api/testData/components/callResolver/resolveCall/delegatedConstructorCall_super_unresolved.txt b/analysis/analysis-api/testData/components/callResolver/resolveCall/delegatedConstructorCall_super_unresolved.txt index fea1e628a5a..f1213abf52b 100644 --- a/analysis/analysis-api/testData/components/callResolver/resolveCall/delegatedConstructorCall_super_unresolved.txt +++ b/analysis/analysis-api/testData/components/callResolver/resolveCall/delegatedConstructorCall_super_unresolved.txt @@ -28,4 +28,4 @@ KtErrorCallInfo: callableIdIfNonLocal = null) } ] - diagnostic = ERROR + diagnostic = ERROR \ No newline at end of file diff --git a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/ambiguous.txt b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/ambiguous.txt index ae3f30e5acf..c757e2e17a2 100644 --- a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/ambiguous.txt +++ b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/ambiguous.txt @@ -1,5 +1,5 @@ KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = false partiallyAppliedSymbol = KtPartiallyAppliedSymbol: @@ -30,7 +30,7 @@ KtInapplicableCallCandidateInfo: isInBestCandidates = true KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = false partiallyAppliedSymbol = KtPartiallyAppliedSymbol: @@ -61,7 +61,7 @@ KtInapplicableCallCandidateInfo: isInBestCandidates = true KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = false partiallyAppliedSymbol = KtPartiallyAppliedSymbol: diff --git a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvoke.txt b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvoke.txt index 0592242584f..29b5736c504 100644 --- a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvoke.txt +++ b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvoke.txt @@ -1,5 +1,5 @@ KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = true partiallyAppliedSymbol = KtPartiallyAppliedSymbol: @@ -33,7 +33,7 @@ KtInapplicableCallCandidateInfo: isInBestCandidates = false KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = false partiallyAppliedSymbol = KtPartiallyAppliedSymbol: diff --git a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvokeWithReceiver.txt b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvokeWithReceiver.txt index bebd0818087..ee3511d9b6c 100644 --- a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvokeWithReceiver.txt +++ b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/multipleCandidates/implicitInvokeWithReceiver.txt @@ -1,5 +1,5 @@ KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtSimpleFunctionCall: isImplicitInvoke = false partiallyAppliedSymbol = KtPartiallyAppliedSymbol: diff --git a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/singleCandidate/delegatedConstructorInapplicable.txt b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/singleCandidate/delegatedConstructorInapplicable.txt index 971b33d79aa..0cc9520aa55 100644 --- a/analysis/analysis-api/testData/components/callResolver/resolveCandidates/singleCandidate/delegatedConstructorInapplicable.txt +++ b/analysis/analysis-api/testData/components/callResolver/resolveCandidates/singleCandidate/delegatedConstructorInapplicable.txt @@ -1,5 +1,5 @@ KtInapplicableCallCandidateInfo: - diagnostic = ERROR + diagnostic = ERROR candidate = KtDelegatedConstructorCall: kind = SUPER_CALL partiallyAppliedSymbol = KtPartiallyAppliedSymbol: diff --git a/analysis/low-level-api-fir/testData/contextCollector/enumValue.txt b/analysis/low-level-api-fir/testData/contextCollector/enumValue.txt index 20d8600a3f2..fe69256b6fd 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/enumValue.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/enumValue.txt @@ -16,7 +16,7 @@ Tower Data Context: Element 7 Implicit receiver: FirRegularClassSymbol public final companion object Companion : R|kotlin/Any| - Type: kotlin/Enum.Companion + Type: kotlin.Enum.Companion Element 8 Scope: FirNestedClassifierScopeWithSubstitution Classifiers: @@ -78,4 +78,4 @@ FILE: [ResolvedTo(IMPORTS)] enumValue.kt public final static [ResolvedTo(STATUS)] val entries: R|kotlin/enums/EnumEntries| public [ResolvedTo(STATUS)] get(): R|kotlin/enums/EnumEntries| - } + } \ No newline at end of file diff --git a/analysis/low-level-api-fir/testData/contextCollector/extensionFunction.txt b/analysis/low-level-api-fir/testData/contextCollector/extensionFunction.txt index 9482e735123..efe0eab6b99 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/extensionFunction.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/extensionFunction.txt @@ -18,7 +18,7 @@ Tower Data Context: Element 8 Implicit receiver: FirNamedFunctionSymbol public final fun R|kotlin/String|.test(): R|kotlin/Unit| - Type: kotlin/String + Type: kotlin.String Element 9 Scope: FirLocalScope diff --git a/analysis/low-level-api-fir/testData/contextCollector/extensionLambdas.txt b/analysis/low-level-api-fir/testData/contextCollector/extensionLambdas.txt index f05b815b50b..e8aab9fe896 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/extensionLambdas.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/extensionLambdas.txt @@ -22,7 +22,7 @@ Tower Data Context: Element 10 Implicit receiver: FirAnonymousFunctionSymbol foo@fun R|kotlin/String|.(): R|kotlin/Unit| - Type: kotlin/String + Type: kotlin.String Element 11 Scope: FirLocalScope Element 12 @@ -30,7 +30,7 @@ Tower Data Context: Element 13 Implicit receiver: FirAnonymousFunctionSymbol num@fun R|kotlin/Int|.(): R|kotlin/Unit| - Type: kotlin/Int + Type: kotlin.Int Element 14 Scope: FirLocalScope diff --git a/analysis/low-level-api-fir/testData/contextCollector/innerClasses.txt b/analysis/low-level-api-fir/testData/contextCollector/innerClasses.txt index 3d5aef74f20..896c4b43676 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/innerClasses.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/innerClasses.txt @@ -24,7 +24,7 @@ Tower Data Context: Element 9 Implicit receiver: FirRegularClassSymbol public final class Foo : R|kotlin/Any| - Type: test/Foo + Type: test.Foo Element 10 Scope: FirMemberTypeParameterScope Classifiers: @@ -32,7 +32,7 @@ Tower Data Context: Element 11 Implicit receiver: FirRegularClassSymbol public final inner class Bar : R|kotlin/Any| - Type: test/Foo.Bar + Type: test.Foo.Bar Element 12 Scope: FirLocalScope Properties: diff --git a/analysis/low-level-api-fir/testData/contextCollector/localClass.txt b/analysis/low-level-api-fir/testData/contextCollector/localClass.txt index 97e01e8efc8..1457681f5bc 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/localClass.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/localClass.txt @@ -22,7 +22,7 @@ Tower Data Context: Element 9 Implicit receiver: FirRegularClassSymbol local final class Local : R|kotlin/Any| - Type: /Local + Type: .Local Element 10 Scope: FirLocalScope Element 11 @@ -42,4 +42,4 @@ FILE: [ResolvedTo(IMPORTS)] localClass.kt } R|/Local.Local|().R|/foo|() - } + } \ No newline at end of file diff --git a/analysis/low-level-api-fir/testData/contextCollector/nestedClasses.txt b/analysis/low-level-api-fir/testData/contextCollector/nestedClasses.txt index 20e902a3e9d..1f1f34fac24 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/nestedClasses.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/nestedClasses.txt @@ -24,7 +24,7 @@ Tower Data Context: Element 9 Implicit receiver: FirRegularClassSymbol public final class Bar : R|kotlin/Any| - Type: test/Foo.Bar + Type: test.Foo.Bar Element 10 Scope: FirLocalScope Properties: diff --git a/analysis/low-level-api-fir/testData/contextCollector/propertyDelegateInitializer.txt b/analysis/low-level-api-fir/testData/contextCollector/propertyDelegateInitializer.txt index 0743979e4cb..835455ec88a 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/propertyDelegateInitializer.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/propertyDelegateInitializer.txt @@ -16,7 +16,7 @@ Tower Data Context: Element 7 Implicit receiver: FirRegularClassSymbol public final class Foo : R|kotlin/Any| - Type: test/Foo + Type: test.Foo Element 8 Scope: FirLocalScope Properties: @@ -40,4 +40,4 @@ FILE: [ResolvedTo(IMPORTS)] propertyDelegateInitializer.kt ^ this@R|test/Foo|.D|test/Foo.property|.R|test/MyInterface.getValue|(this@R|test/Foo|, ::R|test/Foo.property|) } - } + } \ No newline at end of file diff --git a/analysis/low-level-api-fir/testData/contextCollector/scripts/insideClassMember.txt b/analysis/low-level-api-fir/testData/contextCollector/scripts/insideClassMember.txt index a3f153330f9..d1b069317b5 100644 --- a/analysis/low-level-api-fir/testData/contextCollector/scripts/insideClassMember.txt +++ b/analysis/low-level-api-fir/testData/contextCollector/scripts/insideClassMember.txt @@ -50,7 +50,7 @@ Tower Data Context: public? get(): public? final? class After_OtherClass : R|kotlin/Any| - Type: kotlin/script/templates/standard/ScriptTemplateWithArgs + Type: kotlin.script.templates.standard.ScriptTemplateWithArgs Label: