Properly remove duplicated inlined classes using capturedConstructors

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/LocalDeclarationsLowering.kt

@@ -104,6 +104,15 @@ class LocalDeclarationsLowering(
         LocalDeclarationsTransformer(irBlock, container, closestParent, classesToLower, functionsToSkip).lowerLocalDeclarations()
     }
 
+    fun lowerWithoutActualChange(irBody: IrBody, container: IrDeclaration) {
+        val oldCapturedConstructors = context.mapping.capturedConstructors.keys
+            .mapNotNull { context.mapping.capturedConstructors[it] }
+        LocalDeclarationsTransformer(irBody, container).cacheLocalConstructors()
+        oldCapturedConstructors
+            .filter { context.mapping.capturedConstructors[it] != null }
+            .forEach { context.mapping.capturedConstructors[it] = null }
+    }
+
     internal class ScopeWithCounter(val irElement: IrElement) {
         // Continuous numbering across all declarations in the container.
         var counter: Int = 0
@@ -266,6 +275,15 @@ class LocalDeclarationsLowering(
         val oldParameterToNew: MutableMap<IrValueParameter, IrValueParameter> = mutableMapOf()
         val newParameterToCaptured: MutableMap<IrValueParameter, IrValueSymbol> = mutableMapOf()
 
+        fun cacheLocalConstructors() {
+            collectLocalDeclarations()
+            collectClosureForLocalDeclarations()
+
+            localClassConstructors.values.forEach {
+                createTransformedConstructorDeclaration(it)
+            }
+        }
+
         fun lowerLocalDeclarations() {
             collectLocalDeclarations()
             if (localFunctions.isEmpty() && localClasses.isEmpty()) return
@@ -777,6 +795,20 @@ class LocalDeclarationsLowering(
             val localClassContext = localClasses[oldDeclaration.parent]!!
             val capturedValues = localClassContext.closure.capturedValues
 
+            // Restore context if constructor was cached
+            context.mapping.capturedConstructors[oldDeclaration]?.let { newDeclaration ->
+                transformedDeclarations[oldDeclaration] = newDeclaration
+                constructorContext.transformedDeclaration = newDeclaration
+                newDeclaration.valueParameters.zip(capturedValues).forEach { (it, capturedValue) ->
+                    newParameterToCaptured[it] = capturedValue
+                }
+                oldDeclaration.valueParameters.zip(newDeclaration.valueParameters).forEach { (v, it) ->
+                    newParameterToOld.putAbsentOrSame(it, v)
+                }
+                newDeclaration.recordTransformedValueParameters(constructorContext)
+                return
+            }
+
             val newDeclaration = context.irFactory.buildConstructor {
                 updateFrom(oldDeclaration)
                 visibility = visibilityPolicy.forConstructor(oldDeclaration, constructorContext.inInlineFunctionScope)

compiler/ir/backend.jvm/lower/src/org/jetbrains/kotlin/backend/jvm/JvmLower.kt

@@ -120,7 +120,7 @@ internal val IrClass.isGeneratedLambdaClass: Boolean
             origin == JvmLoweredDeclarationOrigin.FUNCTION_REFERENCE_IMPL ||
             origin == JvmLoweredDeclarationOrigin.GENERATED_PROPERTY_REFERENCE
 
-private class JvmVisibilityPolicy : VisibilityPolicy {
+internal class JvmVisibilityPolicy : VisibilityPolicy {
     // Note: any condition that results in non-`LOCAL` visibility here should be duplicated in `JvmLocalClassPopupLowering`,
     // else it won't detect the class as local.
     override fun forClass(declaration: IrClass, inInlineFunctionScope: Boolean): DescriptorVisibility =

compiler/ir/backend.jvm/lower/src/org/jetbrains/kotlin/backend/jvm/lower/RemoveDuplicatedInlinedLocalClassesLowering.kt

@@ -9,17 +9,22 @@ import org.jetbrains.kotlin.backend.common.FileLoweringPass
 import org.jetbrains.kotlin.backend.common.ir.getDefaultAdditionalStatementsFromInlinedBlock
 import org.jetbrains.kotlin.backend.common.ir.getNonDefaultAdditionalStatementsFromInlinedBlock
 import org.jetbrains.kotlin.backend.common.ir.getOriginalStatementsFromInlinedBlock
+import org.jetbrains.kotlin.backend.common.lower.LocalDeclarationsLowering
+import org.jetbrains.kotlin.backend.common.lower.parents
 import org.jetbrains.kotlin.backend.common.phaser.makeIrFilePhase
-import org.jetbrains.kotlin.backend.jvm.JvmBackendContext
+import org.jetbrains.kotlin.backend.jvm.*
-import org.jetbrains.kotlin.backend.jvm.functionInliningPhase
-import org.jetbrains.kotlin.backend.jvm.localDeclarationsPhase
 import org.jetbrains.kotlin.ir.IrElement
 import org.jetbrains.kotlin.ir.IrStatement
-import org.jetbrains.kotlin.ir.declarations.IrClass
+import org.jetbrains.kotlin.ir.declarations.*
-import org.jetbrains.kotlin.ir.declarations.IrFile
 import org.jetbrains.kotlin.ir.expressions.*
 import org.jetbrains.kotlin.ir.expressions.impl.IrCompositeImpl
+import org.jetbrains.kotlin.ir.expressions.impl.IrConstructorCallImpl
+import org.jetbrains.kotlin.ir.util.copyTypeAndValueArgumentsFrom
+import org.jetbrains.kotlin.ir.util.defaultType
+import org.jetbrains.kotlin.ir.util.parentAsClass
+import org.jetbrains.kotlin.ir.util.primaryConstructor
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformer
+import org.jetbrains.kotlin.name.NameUtils
 
 internal val removeDuplicatedInlinedLocalClasses = makeIrFilePhase(
     ::RemoveDuplicatedInlinedLocalClassesLowering,
@@ -39,6 +44,16 @@ class RemoveDuplicatedInlinedLocalClassesLowering(val context: JvmBackendContext
     private var insideInlineBlock = false
     private val visited = mutableSetOf<IrElement>()
 
+    private var modifyTree: Boolean = true
+
+    private val capturedConstructors = context.mapping.capturedConstructors
+
+    private fun removeUselessDeclarationsFromCapturedConstructors(irClass: IrClass) {
+        modifyTree = false
+        irClass.parents.first { it !is IrFunction || it.origin != JvmLoweredDeclarationOrigin.INLINE_LAMBDA }
+            .accept(this, false)
+    }
+
     override fun lower(irFile: IrFile) {
         irFile.transformChildren(this, false)
     }
@@ -59,7 +74,61 @@ class RemoveDuplicatedInlinedLocalClassesLowering(val context: JvmBackendContext
             return expression
         }
 
-        return super.visitBlock(expression, data)
+        val anonymousClass = expression.statements.firstOrNull()
+        val result = super.visitBlock(expression, data)
+        if (anonymousClass is IrClass && result is IrBlock && result.statements.firstOrNull() is IrComposite) {
+            reuseConstructorFromOriginalClass(result, anonymousClass)
+        }
+        return result
+    }
+
+    private fun IrAttributeContainer.getOriginalDeclaration(): IrDeclaration? {
+        return when (val original = this.attributeOwnerId) {
+            is IrClass -> return original
+            is IrFunctionExpression -> original.function
+            is IrFunctionReference -> original.symbol.owner
+            else -> null
+        }
+    }
+
+    private fun reuseConstructorFromOriginalClass(block: IrBlock, anonymousClass: IrClass) {
+        val lastStatement = block.statements.last()
+        val constructorCall = (lastStatement as? IrConstructorCall)
+            ?: (lastStatement as IrBlock).statements.last() as IrConstructorCall
+        val constructorParent = constructorCall.symbol.owner.parentAsClass
+
+        // It is possible that inlined class will be lowered before original. In that case we must launch `LocalDeclarationsLowering` and
+        // lower original declaration to get correct captured constructor.
+        val container = anonymousClass.getOriginalDeclaration()?.parents
+            ?.filterIsInstance<IrFunction>()?.firstOrNull()?.takeIf { it.body != null }
+        container?.let {
+            LocalDeclarationsLowering(
+                context, NameUtils::sanitizeAsJavaIdentifier, JvmVisibilityPolicy(),
+                compatibilityModeForInlinedLocalDelegatedPropertyAccessors = true, forceFieldsForInlineCaptures = true
+            ).lowerWithoutActualChange(it.body!!, it)
+        }
+
+        // We must remove all constructors from `capturedConstructors` that belong to the classes that will be removed
+        capturedConstructors.keys.forEach {
+            RemoveDuplicatedInlinedLocalClassesLowering(context).removeUselessDeclarationsFromCapturedConstructors(it.parentAsClass)
+        }
+
+        val originalConstructor = capturedConstructors.keys.single {
+            it.parentAsClass.attributeOwnerId == constructorParent.attributeOwnerId && it.parentAsClass != constructorParent
+        }
+
+        val loweredConstructor = capturedConstructors[originalConstructor]!!
+        val newConstructorCall = IrConstructorCallImpl.fromSymbolOwner(
+            constructorCall.startOffset, constructorCall.endOffset,
+            loweredConstructor.parentAsClass.defaultType, loweredConstructor.symbol, constructorCall.origin
+        )
+        newConstructorCall.copyTypeAndValueArgumentsFrom(constructorCall)
+
+        if (lastStatement is IrConstructorCall) {
+            block.statements[block.statements.lastIndex] = newConstructorCall
+        } else if (lastStatement is IrBlock) {
+            lastStatement.statements[lastStatement.statements.lastIndex] = newConstructorCall
+        }
     }
 
     // Basically we want to remove all anonymous classes after inline. Exceptions are:
@@ -70,10 +139,21 @@ class RemoveDuplicatedInlinedLocalClassesLowering(val context: JvmBackendContext
             return super.visitClass(declaration, data)
         }
 
-        // TODO big note. Here we drop anonymous class declaration but there still present a constructor call that has reference to this class.
+        val constructor = declaration.primaryConstructor!!
-        //  Everything works fine because somewhere in code we still have class declaration with the same name. So this doesn't ruin code
+        capturedConstructors[constructor] = null // this action will do actual `remove`
-        //  generation and will not drop on runtime, but this is something to be aware of.
+        capturedConstructors.keys.map { key -> // for each value in map
-        return IrCompositeImpl(declaration.startOffset, declaration.endOffset, context.irBuiltIns.unitType)
+            capturedConstructors[key]?.let {
+                if (it == constructor) {
+                    capturedConstructors[key] = null
+                }
+            }
+        }
+
+        return if (modifyTree) {
+            IrCompositeImpl(declaration.startOffset, declaration.endOffset, context.irBuiltIns.unitType)
+        } else {
+            super.visitClass(declaration, data)
+        }
     }
 
     override fun visitFunctionReference(expression: IrFunctionReference, data: Boolean): IrElement {