Fixed KotlinLintTestGenerated.testJavaPerformance + refactoring

Moved android lint tests from uast-kotlin to idea-android
2016-11-07 12:18:20 +03:00
parent 3d75b78dc5
commit d90ec3e777
29 changed files with 38 additions and 41 deletions
@@ -0,0 +1,69 @@
+// INSPECTION_CLASS: org.jetbrains.android.inspections.klint.AndroidLintInspectionToolProvider$AndroidKLintCommitPrefEditsInspection
+
+import android.app.Activity
+import android.content.Context
+import android.os.Bundle
+import android.preference.PreferenceManager
+
+@Suppress("UsePropertyAccessSyntax", "UNUSED_VARIABLE", "unused", "UNUSED_PARAMETER", "DEPRECATION")
+class SharedPrefsText(context: Context) : Activity() {
+    // OK 1
+    fun onCreate1(savedInstanceState: Bundle) {
+        super.onCreate(savedInstanceState)
+        val preferences = PreferenceManager.getDefaultSharedPreferences(this)
+        val editor = preferences.edit()
+        editor.putString("foo", "bar")
+        editor.putInt("bar", 42)
+        editor.commit()
+    }
+
+    // OK 2
+    fun onCreate2(savedInstanceState: Bundle, apply: Boolean) {
+        super.onCreate(savedInstanceState)
+        val preferences = PreferenceManager.getDefaultSharedPreferences(this)
+        val editor = preferences.edit()
+        editor.putString("foo", "bar")
+        editor.putInt("bar", 42)
+        if (apply) {
+            editor.apply()
+        }
+    }
+
+    // Not a bug
+    fun test(foo: Foo) {
+        val bar1 = foo.edit()
+        val bar3 = edit()
+        apply()
+    }
+
+    internal fun apply() {
+
+    }
+
+    fun edit(): Bar {
+        return Bar()
+    }
+
+    class Foo {
+        internal fun edit(): Bar {
+            return Bar()
+        }
+    }
+
+    class Bar
+
+    // Bug
+    fun bug1(savedInstanceState: Bundle) {
+        super.onCreate(savedInstanceState)
+        val preferences = PreferenceManager.getDefaultSharedPreferences(this)
+        val editor = preferences.<warning descr="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call">edit()</warning>
+        editor.putString("foo", "bar")
+        editor.putInt("bar", 42)
+    }
+
+    init {
+        val preferences = PreferenceManager.getDefaultSharedPreferences(context)
+        val editor = preferences.<warning descr="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call"><warning descr="`SharedPreferences.edit()` without a corresponding `commit()` or `apply()` call">edit()</warning></warning>
+        editor.putString("foo", "bar")
+    }
+}