azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[LL FIR] KT-57207 Choose combined Java symbol providers cache size

Browse Source
This commit is contained in:
Marco Pennekamp
2023-04-11 13:20:02 +02:00
committed by Space Team
parent e13d4f2328
commit d8f253d07b
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/providers/LLFirCombinedJavaSymbolProvider.kt
+4
View File
@@ -40,6 +40,10 @@ internal class LLFirCombinedJavaSymbolProvider private constructor(
/** /**
* The purpose of this cache is to avoid index access for frequently accessed `ClassId`s, including failures. Because Java symbol * The purpose of this cache is to avoid index access for frequently accessed `ClassId`s, including failures. Because Java symbol
* providers currently cannot benefit from a "name in package" check (see KTIJ-24642), the cache should also store negative results. * providers currently cannot benefit from a "name in package" check (see KTIJ-24642), the cache should also store negative results.
*
* The cache size has been chosen with the help of local benchmarks and performance tests. A cache size of 2500 in comparison to 1000
* resulted in less time spent in [computeClassLikeSymbolByClassId] in local benchmarks. Cache sizes of 5000 and 10000 were tried in
* performance tests, but didn't affect performance. A cache size of 2500 is a good middle ground with a small memory footprint.
*/ */
private val classCache: NullableCaffeineCache<ClassId, FirRegularClassSymbol> = NullableCaffeineCache { it.maximumSize(2500) } private val classCache: NullableCaffeineCache<ClassId, FirRegularClassSymbol> = NullableCaffeineCache { it.maximumSize(2500) }