[FIR] Update testdata of FIR spec tests

compiler/tests-spec/testData/diagnostics/linked/control--and-data-flow-analysis/control-flow-graph/expressions-1/conditional-expressions/p-1/neg/1.1.fir.kt

@@ -1,19 +0,0 @@
-// !LANGUAGE: +NewInference
-// !DIAGNOSTICS:  -IMPLICIT_CAST_TO_ANY -UNUSED_VARIABLE -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE -UNUSED_PARAMETER -UNUSED_EXPRESSION
-// SKIP_TXT
-
-// TESTCASE NUMBER: 1
-
-fun case1() {
-    val b = true
-    val a =  if (b) {
-        "true"
-    }
-}
-
-// TESTCASE NUMBER: 2
-
-fun case2() {
-    val b = true
-    val a = if (b) "true"
-}

compiler/tests-spec/testData/diagnostics/linked/control--and-data-flow-analysis/control-flow-graph/expressions-1/conditional-expressions/p-1/neg/1.1.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !LANGUAGE: +NewInference
 // !DIAGNOSTICS:  -IMPLICIT_CAST_TO_ANY -UNUSED_VARIABLE -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE -UNUSED_PARAMETER -UNUSED_EXPRESSION
 // SKIP_TXT

compiler/tests-spec/testData/diagnostics/linked/control--and-data-flow-analysis/control-flow-graph/expressions-1/conditional-expressions/p-1/neg/1.2.fir.kt

@@ -2,6 +2,15 @@
 // !DIAGNOSTICS:  -IMPLICIT_CAST_TO_ANY -UNUSED_VARIABLE -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE -UNUSED_PARAMETER -UNUSED_EXPRESSION
 // SKIP_TXT
 
+/*
+ * KOTLIN DIAGNOSTICS SPEC TEST (NEGATIVE)
+ *
+ * SPEC VERSION: 0.1-296
+ * MAIN LINK: control--and-data-flow-analysis, control-flow-graph, expressions-1, conditional-expressions -> paragraph 1 -> sentence 1
+ * NUMBER: 2
+ * DESCRIPTION: check if-expressions must have both branches.
+ */
+
 // TESTCASE NUMBER: 1
 
 fun case1() {
@@ -9,7 +18,7 @@ fun case1() {
     val c = true
     val a = if (b) {
         "first true"
-    } else if (c) {
+    } else <!INVALID_IF_AS_EXPRESSION!>if<!> (c) {
         "else if true"
     }
 }

compiler/tests-spec/testData/diagnostics/linked/control--and-data-flow-analysis/control-flow-graph/expressions-1/conditional-expressions/p-1/neg/1.3.fir.kt

@@ -2,6 +2,15 @@
 // !DIAGNOSTICS: -UNREACHABLE_CODE -IMPLICIT_CAST_TO_ANY -UNUSED_VARIABLE -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE -UNUSED_PARAMETER -UNUSED_EXPRESSION
 // SKIP_TXT
 
+/*
+ * KOTLIN DIAGNOSTICS SPEC TEST (NEGATIVE)
+ *
+ * SPEC VERSION: 0.1-296
+ * MAIN LINK: control--and-data-flow-analysis, control-flow-graph, expressions-1, conditional-expressions -> paragraph 1 -> sentence 1
+ * NUMBER: 3
+ * DESCRIPTION: check if-expressions must have both branches. (attempt to pass Nothing to if-condition without 'else' key word)
+ */
+
 fun throwExc(b: Boolean): Boolean {
     if (b) throw Exception()
     else return false
@@ -9,13 +18,13 @@ fun throwExc(b: Boolean): Boolean {
 
 // TESTCASE NUMBER: 1
 fun case1() {
-    val x1 = if (throwExc(false)) true
+    val x1 = <!INVALID_IF_AS_EXPRESSION!>if<!> (throwExc(false)) true
 }
 
 
 // TESTCASE NUMBER: 3
 fun case3() {
-    val x1 = if (throwExc(true)) true
+    val x1 = <!INVALID_IF_AS_EXPRESSION!>if<!> (throwExc(true)) true
 }
 
 /*
@@ -24,18 +33,18 @@ fun case3() {
  * ISSUES: KT-35510
  */
 fun case4() {
-    val x1 = if (throw Exception()) true
+    val x1 = <!INVALID_IF_AS_EXPRESSION!>if<!> (throw Exception()) true
 
-    val x2 = if (TODO()) true
+    val x2 = <!INVALID_IF_AS_EXPRESSION!>if<!> (TODO()) true
 
-    val x0 = if (false) true else if (throw Exception()) ;
+    val x0 = if (false) true else <!INVALID_IF_AS_EXPRESSION!>if<!> (throw Exception()) ;
 
 }
 
 // TESTCASE NUMBER: 5
 fun case5() {
     var flag: Boolean? = null
-    val x1 = if (flag ?: throw Exception()) true
+    val x1 = <!INVALID_IF_AS_EXPRESSION!>if<!> (flag ?: throw Exception()) true
 }
 
 /*
@@ -44,7 +53,7 @@ fun case5() {
  * ISSUES: KT-35510
  */
 fun case6() {
-    val k1 = if(throw Exception());
+    val k1 = <!INVALID_IF_AS_EXPRESSION!>if<!>(throw Exception());
 }
 
 /*
@@ -62,7 +71,7 @@ fun case7(nothing: Nothing) {
  * ISSUES: KT-35510
  */
 fun case8(nothing: Nothing) {
-    val x1 = if (nothing) true
+    val x1 = <!INVALID_IF_AS_EXPRESSION!>if<!> (nothing) true
 }
 
 /*

compiler/tests-spec/testData/diagnostics/linked/control--and-data-flow-analysis/control-flow-graph/expressions-1/conditional-expressions/p-1/neg/2.1.fir.kt

@@ -2,6 +2,16 @@
 // !DIAGNOSTICS: -UNUSED_VARIABLE -ASSIGNED_BUT_NEVER_ACCESSED_VARIABLE -UNUSED_VALUE -UNUSED_PARAMETER -UNUSED_EXPRESSION
 // SKIP_TXT
 
+/*
+ * KOTLIN DIAGNOSTICS SPEC TEST (NEGATIVE)
+ *
+ * SPEC VERSION: 0.1-296
+ * MAIN LINK: control--and-data-flow-analysis, control-flow-graph, expressions-1, conditional-expressions -> paragraph 1 -> sentence 2
+ * NUMBER: 1
+ * DESCRIPTION: check any if-statement in kotlin may be trivially turned into such an expression by replacing the missing branch with a kotlin.Unit object expression.
+ * HELPERS: checkType
+ */
+
 // TESTCASE NUMBER: 1
 
 fun case1() {
@@ -9,7 +19,7 @@ fun case1() {
     if (!b) {
         println("this is statement")
     }
-    val statement = if (!b) { println("statement could not be assigned") }
+    val statement = <!INVALID_IF_AS_EXPRESSION!>if<!> (!b) { println("statement could not be assigned") }
 }
 
 // TESTCASE NUMBER: 2