azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use the same temporary trace for analyzing all candidate calls

Browse Source 
Otherwise, when completing all the unsuccessfull candiates,
resolution of each lambda-arguments starts repeatedly for each candidate
that leads to exponential time

NB: Changes in `completeArguments` are necessary because otherwise
nested lambdas will be analyzed twice:
once for the main resolved call, and then for all candidates
that again leads to exponential complexity

 #KT-16672 Fixed
 #KT-19457 Fixed
This commit is contained in:
Denis Zharkov
2017-08-30 12:51:29 +03:00
parent 84c2e01161
commit d6fbb084b1
7 changed files with 182 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/resolve/nestedCalls/manyInapplicableCandidatesWithLambdas.kt
Vendored
+53
View File
@@ -0,0 +1,53 @@
// !DIAGNOSTICS: -UNUSED_PARAMETER
class A
class B
class C
class D
fun A.bar(x: Int = 0) = ""
fun A.bar(x: Int = 0, y: D.() -> Unit) = ""
fun B.bar(x: Int = 0) = ""
fun B.bar(x: Int = 0, y: D.() -> Unit) = ""
fun C.bar(x: Int = 0) = ""
fun C.bar(x: Int = 0, y: D.() -> Unit) = ""
class E {
fun foo() {
// `bar` calls are inapplicable since both E nor D aren't proper receivers
// But prior to this change, every lambda was analyzed repeatedly for every candidate
// Thus, the resulting time was exponential
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>bar<!> {
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
compiler/testData/diagnostics/tests/resolve/nestedCalls/manyInapplicableCandidatesWithLambdas.txt
Vendored
+44
View File
@@ -0,0 +1,44 @@
package
public fun A.bar(/*0*/ x: kotlin.Int = ...): kotlin.String
public fun A.bar(/*0*/ x: kotlin.Int = ..., /*1*/ y: D.() -> kotlin.Unit): kotlin.String
public fun B.bar(/*0*/ x: kotlin.Int = ...): kotlin.String
public fun B.bar(/*0*/ x: kotlin.Int = ..., /*1*/ y: D.() -> kotlin.Unit): kotlin.String
public fun C.bar(/*0*/ x: kotlin.Int = ...): kotlin.String
public fun C.bar(/*0*/ x: kotlin.Int = ..., /*1*/ y: D.() -> kotlin.Unit): kotlin.String
public final class A {
public constructor A()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class B {
public constructor B()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class C {
public constructor C()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class D {
public constructor D()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
public final class E {
public constructor E()
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public final fun foo(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}
compiler/testData/diagnostics/testsWithStdLib/hugeUnresolvedKotlinxHtml.kt
Vendored
+60
View File
@@ -0,0 +1,60 @@
class A {
fun bar() {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE_WRONG_RECEIVER!>div<!> {
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
<!UNRESOLVED_REFERENCE!>+<!>(<!UNRESOLVED_REFERENCE!>foo<!> ?: "")
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
}
compiler/testData/diagnostics/testsWithStdLib/hugeUnresolvedKotlinxHtml.txt
Vendored
+9
View File
@@ -0,0 +1,9 @@
package
public final class A {
public constructor A()
public final fun bar(): kotlin.Unit
public open override /*1*/ /*fake_override*/ fun equals(/*0*/ other: kotlin.Any?): kotlin.Boolean
public open override /*1*/ /*fake_override*/ fun hashCode(): kotlin.Int
public open override /*1*/ /*fake_override*/ fun toString(): kotlin.String
}