Use lazySync instead of lazyPub to avoid raise on creation LightClasses

compiler/light-classes/src/org/jetbrains/kotlin/asJava/builder/LightClassDataProvider.kt

@@ -56,13 +56,10 @@ class LightClassDataProviderForClassOrObject(
     }
 
     override fun compute(): CachedValueProvider.Result<LightClassDataHolder.ForClass>? {
+        val trackerService = KotlinModificationTrackerService.getInstance(classOrObject.project)
         return CachedValueProvider.Result.create(
-                computeLightClassData(),
-                if (classOrObject.isLocal()) {
-                    KotlinModificationTrackerService.getInstance(classOrObject.project).modificationTracker
-                } else {
-                    KotlinModificationTrackerService.getInstance(classOrObject.project).outOfBlockModificationTracker
-                }
+            computeLightClassData(),
+            if (classOrObject.isLocal) trackerService.modificationTracker else trackerService.outOfBlockModificationTracker
         )
     }
 

compiler/light-classes/src/org/jetbrains/kotlin/asJava/classes/KtLazyLightClass.kt

@@ -19,12 +19,17 @@ package org.jetbrains.kotlin.asJava.classes
 import com.intellij.psi.PsiClass
 import com.intellij.psi.PsiManager
 import org.jetbrains.kotlin.asJava.builder.LightClassData
+import org.jetbrains.kotlin.asJava.elements.KtLightField
+import org.jetbrains.kotlin.asJava.elements.KtLightMethod
 
 abstract class KtLazyLightClass(manager: PsiManager) : KtLightClassBase(manager) {
     abstract val lightClassData: LightClassData
 
     override val clsDelegate: PsiClass by lazyPub { lightClassData.clsDelegate }
 
-    override fun getOwnFields() = lightClassData.getOwnFields(this)
-    override fun getOwnMethods() = lightClassData.getOwnMethods(this)
+    private val _getOwnFields: List<KtLightField> by lazySync { lightClassData.getOwnFields(this) }
+    override fun getOwnFields() = _getOwnFields
+
+    private val _getOwnMethods: List<KtLightMethod> by lazySync { lightClassData.getOwnMethods(this) }
+    override fun getOwnMethods() = _getOwnMethods
 }

compiler/light-classes/src/org/jetbrains/kotlin/asJava/classes/KtLightClassForSourceDeclaration.kt

@@ -97,7 +97,9 @@ abstract class KtLightClassForSourceDeclaration(
     abstract override fun getQualifiedName(): String?
 
     override val lightClassData: LightClassData
-        get() = findLightClassData()
+        get() = _findLightClassData
+
+    private val _findLightClassData: LightClassData by lazySync { findLightClassData() }
 
     protected open fun findLightClassData() = getLightClassDataHolder().findDataForClassOrObject(classOrObject)
 

compiler/light-classes/src/org/jetbrains/kotlin/asJava/classes/implUtils.kt

@@ -20,6 +20,8 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
 // NOTE: avoid using blocking lazy in light classes, it leads to deadlocks
 fun <T> lazyPub(initializer: () -> T) = lazy(LazyThreadSafetyMode.PUBLICATION, initializer)
 
+fun <T> lazySync(initializer: () -> T) = lazy(LazyThreadSafetyMode.SYNCHRONIZED, initializer)
+
 fun LightElement.cannotModify(): Nothing {
     throw IncorrectOperationException("Modification not implemented.")
 }

idea/idea-analysis/src/org/jetbrains/kotlin/idea/caches/lightClasses/LazyLightClassDataHolder.kt

@@ -14,7 +14,7 @@ import com.intellij.psi.impl.java.stubs.PsiJavaFileStub
 import org.jetbrains.kotlin.asJava.LightClassBuilder
 import org.jetbrains.kotlin.asJava.builder.*
 import org.jetbrains.kotlin.asJava.classes.KtLightClass
-import org.jetbrains.kotlin.asJava.classes.lazyPub
+import org.jetbrains.kotlin.asJava.classes.lazySync
 import org.jetbrains.kotlin.asJava.elements.KtLightField
 import org.jetbrains.kotlin.asJava.elements.KtLightFieldImpl
 import org.jetbrains.kotlin.asJava.elements.KtLightMethod
@@ -43,9 +43,11 @@ sealed class LazyLightClassDataHolder(
             cache.computeIfAbsent(lazyLightClassDataHolder, diagnostics)
     }
 
-    private val exactResultLazyValue = lazyPub { builder(exactContextProvider()).stub }
+    private val _builderExactContextProvider: LightClassBuilderResult by lazySync { builder(exactContextProvider()) }
 
-    private val lazyInexactStub by lazyPub {
+    private val exactResultLazyValue = lazySync { _builderExactContextProvider.stub }
+
+    private val lazyInexactStub by lazySync {
         dummyContextProvider?.let { provider -> provider()?.let { context -> builder.invoke(context).stub } }
     }
 
@@ -56,7 +58,7 @@ sealed class LazyLightClassDataHolder(
 
     override val extraDiagnostics: Diagnostics
         get() = diagnosticsHolderProvider().getOrCompute(this) {
-            builder(exactContextProvider()).diagnostics
+            _builderExactContextProvider.diagnostics
                 // Force lazy diagnostics computation because otherwise a lot of memory is retained by computation.
                 // NB: Laziness here is not crucial anyway since somebody already has requested diagnostics and we hope one will use them
                 .takeUnless { it.isEmpty() } ?: Diagnostics.EMPTY
@@ -100,9 +102,9 @@ sealed class LazyLightClassDataHolder(
     private inner class LazyLightClassData(
         findDelegate: (PsiJavaFileStub) -> PsiClass
     ) : LightClassData {
-        override val clsDelegate: PsiClass by lazyPub { findDelegate(javaFileStub) }
+        override val clsDelegate: PsiClass by lazySync { findDelegate(javaFileStub) }
 
-        private val dummyDelegate: PsiClass? by lazyPub { inexactStub?.let(findDelegate) }
+        private val dummyDelegate: PsiClass? by lazySync { inexactStub?.let(findDelegate) }
 
         override fun getOwnFields(containingClass: KtLightClass): List<KtLightField> {
             if (dummyDelegate == null) return KtLightFieldImpl.fromClsFields(clsDelegate, containingClass)